[GitHub] flink pull request #6211: [FLINK-9665] PrometheusReporter does not properly ...

2018-06-27 Thread jelmerk
Github user jelmerk commented on a diff in the pull request: https://github.com/apache/flink/pull/6211#discussion_r198484545 --- Diff: flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTest.java --- @@ -159,6 +162,27

[GitHub] flink pull request #6211: [FLINK-9665] PrometheusReporter does not properly ...

2018-06-27 Thread jelmerk
GitHub user jelmerk opened a pull request: https://github.com/apache/flink/pull/6211 [FLINK-9665] PrometheusReporter does not properly unregister metrics ## What is the purpose of the change Prometheus metrics from canceled jobs are not always correctly cleaned up. This

[GitHub] flink pull request #5616: [FLINK-8828] [stream, dataset, scala] Introduce co...

2018-03-02 Thread jelmerk
GitHub user jelmerk opened a pull request: https://github.com/apache/flink/pull/5616 [FLINK-8828] [stream, dataset, scala] Introduce collect method ## What is the purpose of the change A collect function is a method that takes a Partial Function as its parameter and

[GitHub] flink issue #5603: [FLINK-8814] Control over the extension of part files cre...

2018-03-01 Thread jelmerk
Github user jelmerk commented on the issue: https://github.com/apache/flink/pull/5603 Thanks! ---

[GitHub] flink pull request #5603: [FLINK-8814] Control over the extension of part fi...

2018-03-01 Thread jelmerk
Github user jelmerk closed the pull request at: https://github.com/apache/flink/pull/5603 ---

[GitHub] flink pull request #5603: [FLINK-8814] Control over the extension of part fi...

2018-02-28 Thread jelmerk
GitHub user jelmerk opened a pull request: https://github.com/apache/flink/pull/5603 [FLINK-8814] Control over the extension of part files created by BucketingSink ## What is the purpose of the change Popular tools like hue and the avro connector for spark require files

[GitHub] flink pull request #5376: [FLINK-6214] WindowAssigners do not allow negative...

2018-01-28 Thread jelmerk
GitHub user jelmerk opened a pull request: https://github.com/apache/flink/pull/5376 [FLINK-6214] WindowAssigners do not allow negative offsets ## What is the purpose of the change The javadoc of TumblingEventTimeWindows and TumblingProcessingTimeWindows suggest that it is

[GitHub] flink issue #5296: [FLINK-8432] [filesystem-connector] Add support for opens...

2018-01-26 Thread jelmerk
Github user jelmerk commented on the issue: https://github.com/apache/flink/pull/5296 All valid points, thanks for the review! ---

[GitHub] flink pull request #5296: [FLINK-8432] [filesystem-connector] Add support fo...

2018-01-26 Thread jelmerk
Github user jelmerk commented on a diff in the pull request: https://github.com/apache/flink/pull/5296#discussion_r164158508 --- Diff: flink-filesystems/flink-openstack-fs-hadoop/src/test/java/org/apache/flink/fs/openstackhadoop/HadoopSwiftFileSystemITCase.java --- @@ -0,0 +1,208

[GitHub] flink pull request #5296: [FLINK-8432] [filesystem-connector] Add support fo...

2018-01-26 Thread jelmerk
Github user jelmerk commented on a diff in the pull request: https://github.com/apache/flink/pull/5296#discussion_r164158160 --- Diff: flink-filesystems/flink-openstack-fs-hadoop/src/main/java/org/apache/flink/fs/openstackhadoop/SwiftFileSystemFactory.java --- @@ -0,0 +1,132

[GitHub] flink pull request #5296: [FLINK-8432] [filesystem-connector] Add support fo...

2018-01-26 Thread jelmerk
Github user jelmerk commented on a diff in the pull request: https://github.com/apache/flink/pull/5296#discussion_r164158043 --- Diff: flink-filesystems/flink-openstack-fs-hadoop/src/main/java/org/apache/flink/fs/openstackhadoop/SwiftFileSystemFactory.java --- @@ -0,0 +1,132

[GitHub] flink issue #5296: [FLINK-8432] [filesystem-connector] Add support for opens...

2018-01-15 Thread jelmerk
Github user jelmerk commented on the issue: https://github.com/apache/flink/pull/5296 Hi @tillrohrmann Those files with a lot of changes are unfortunately copied from hadoop, the readme file contains more information about how this works. I am not overly happy about the this

[GitHub] flink pull request #5296: [FLINK-8432] [filesystem-connector] Add support fo...

2018-01-14 Thread jelmerk
GitHub user jelmerk opened a pull request: https://github.com/apache/flink/pull/5296 [FLINK-8432] [filesystem-connector] Add support for openstack's swift filesystem ## What is the purpose of the change Add support for OpenStack's cloud storage solution