[GitHub] flink issue #6290: [Flink-9691] [Kinesis Connector] Attempt to call getRecor...

2018-07-10 Thread jgrier
Github user jgrier commented on the issue: https://github.com/apache/flink/pull/6290 👍 ---

[GitHub] flink pull request #6290: [Flink-9691] [Kinesis Connector] Attempt to call g...

2018-07-09 Thread jgrier
GitHub user jgrier opened a pull request: https://github.com/apache/flink/pull/6290 [Flink-9691] [Kinesis Connector] Attempt to call getRecords() at correct frequency. ## What is the purpose of the change The purpose of this change is to make the Kinesis connector

[GitHub] flink issue #2982: [FLINK-4460] Side Outputs in Flink

2017-03-20 Thread jgrier
Github user jgrier commented on the issue: https://github.com/apache/flink/pull/2982 Nice :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #3204: [FLINK-5634] Flink should not always redirect stdo...

2017-03-20 Thread jgrier
Github user jgrier closed the pull request at: https://github.com/apache/flink/pull/3204 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #3494: [FLINK-5635] [docker] Improve Docker tooling

2017-03-08 Thread jgrier
Github user jgrier commented on a diff in the pull request: https://github.com/apache/flink/pull/3494#discussion_r105065007 --- Diff: flink-contrib/docker-flink/Dockerfile --- @@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin EXPOSE 8081 EXPOSE 6123 +# flink

[GitHub] flink issue #3314: [FLINK-3679] DeserializationSchema should handle zero or ...

2017-02-28 Thread jgrier
Github user jgrier commented on the issue: https://github.com/apache/flink/pull/3314 I think it would be just fine if we allowed a null return given the tradeoffs discussed here. The main thing was to allow users a way to deal with bad data with minimal effort and without throwing

[GitHub] flink issue #3205: [FLINK-5635] Improve Docker tooling to make it easier to ...

2017-02-03 Thread jgrier
Github user jgrier commented on the issue: https://github.com/apache/flink/pull/3205 @ex00 The `--from-local-dist` flag assumes you've already built Flink locally. If you run `mvn clean package -DskipTests` does this error persist? --- If your project is set up for it, you can

[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...

2017-02-03 Thread jgrier
Github user jgrier commented on the issue: https://github.com/apache/flink/pull/3204 Agreed.. If https://issues.apache.org/jira/browse/FLINK-4326 were merged this would also work fine. Whether or not Flink runs in the background or foreground is orthogonal to where the logs go â

[GitHub] flink issue #3205: [FLINK-5635] Improve Docker tooling to make it easier to ...

2017-01-25 Thread jgrier
Github user jgrier commented on the issue: https://github.com/apache/flink/pull/3205 Thanks @ex00. I missed that. Actually there is a new Flink on Docker stub in the top-level docs and I was planning to document these scripts there, however we may want to keep this here and just

[GitHub] flink pull request #3205: [FLINK-5635] Improve Docker tooling to make it eas...

2017-01-24 Thread jgrier
GitHub user jgrier opened a pull request: https://github.com/apache/flink/pull/3205 [FLINK-5635] Improve Docker tooling to make it easier to build images and launch Flink via Docker tools Improvements for Docker on Flink experience. This PR depends on this other one

[GitHub] flink issue #2772: [FLINK-5012] Expose Timestamp in Timely FlatMap Functions

2016-11-10 Thread jgrier
Github user jgrier commented on the issue: https://github.com/apache/flink/pull/2772 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2387: [FLINK-4317, FLIP-3] [docs] Restructure docs

2016-08-22 Thread jgrier
Github user jgrier commented on the issue: https://github.com/apache/flink/pull/2387 This looks great! I really like the left side navigation. I think this is a big improvement. One suggestion: Can we change the name of the "Testing & Debugging" section to

[GitHub] flink issue #2153: [FLINK-4110] Add testing skeleton to quickstart

2016-06-27 Thread jgrier
Github user jgrier commented on the issue: https://github.com/apache/flink/pull/2153 What I would like to see here is that the tests in the quickstart actually test the code from the job in the quickstart. For example if the job in the quickstart is WordCount it would be nice