[GitHub] flink issue #5346: [FLINK-8490] [mesos] Allow custom docker parameters for d...
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/5346 @tillrohrmann Could you take a final look? ---
[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...
Github user joerg84 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5346#discussion_r163624908
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
@@ -365,6 +386,31 @@ public String call(String s) {
}
}
+ public static List
buildDockerParameters(Option dockerParameters) {
+ if (dockerParameters.isEmpty()) {
+ return Collections.emptyList();
+ } else {
+ String[] dockerParameterSpecifications =
dockerParameters.get().split(",");
+
+ List parameters = new
ArrayList<>(dockerParameterSpecifications.length);
+
+ for (String dockerParameterSpecification :
dockerParameterSpecifications) {
+ if
(!dockerParameterSpecification.trim().isEmpty()) {
+ String[] match =
dockerParameterSpecification.split("=", 2);
--- End diff --
I see, thanks for the explanation!
---
[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...
Github user joerg84 commented on a diff in the pull request: https://github.com/apache/flink/pull/5346#discussion_r163477722 --- Diff: docs/ops/deployment/mesos.md --- @@ -264,6 +264,8 @@ May be set to -1 to disable this feature. `mesos.resourcemanager.tasks.container.volumes`: A comma separated list of `[host_path:]`container_path`[:RO|RW]`. This allows for mounting additional volumes into your container. (**NO DEFAULT**) +`mesos.resourcemanager.tasks.container.docker.parameters`: Custom parameters to be passed into docker run command when using the docker containerizer. Comma separated list of key=value pairs. (**NO DEFAULT**) --- End diff -- Same here. ---
[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...
Github user joerg84 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5346#discussion_r163483150
--- Diff:
flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParametersTest.java
---
@@ -84,6 +84,35 @@ public void testContainerVolumes() throws Exception {
assertEquals(Protos.Volume.Mode.RO,
params.containerVolumes().get(0).getMode());
}
+ @Test
+ public void testContainerDockerParameter() throws Exception {
+ Configuration config = new Configuration();
+
config.setString(MesosTaskManagerParameters.MESOS_RM_CONTAINER_DOCKER_PARAMETERS,
"testKey=testValue");
+
+ MesosTaskManagerParameters params =
MesosTaskManagerParameters.create(config);
+ assertEquals(params.dockerParameters().get(0).getKey(),
"testKey");
--- End diff --
maybe check the size first, same below.
---
[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...
Github user joerg84 commented on a diff in the pull request: https://github.com/apache/flink/pull/5346#discussion_r163477651 --- Diff: docs/ops/config.md --- @@ -508,6 +508,8 @@ May be set to -1 to disable this feature. - `mesos.resourcemanager.tasks.container.volumes`: A comma separated list of `[host_path:]`container_path`[:RO|RW]`. This allows for mounting additional volumes into your container. (**NO DEFAULT**) +- `mesos.resourcemanager.tasks.container.docker.parameters`: Custom parameters to be passed into docker run command when using the docker containerizer. Comma separated list of key=value pairs. (**NO DEFAULT**) --- End diff -- 2 blanks between "containerizer. Comma" ---
[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...
Github user joerg84 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5346#discussion_r163495632
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
@@ -365,6 +386,31 @@ public String call(String s) {
}
}
+ public static List
buildDockerParameters(Option dockerParameters) {
+ if (dockerParameters.isEmpty()) {
+ return Collections.emptyList();
+ } else {
+ String[] dockerParameterSpecifications =
dockerParameters.get().split(",");
+
+ List parameters = new
ArrayList<>(dockerParameterSpecifications.length);
+
+ for (String dockerParameterSpecification :
dockerParameterSpecifications) {
+ if
(!dockerParameterSpecification.trim().isEmpty()) {
+ String[] match =
dockerParameterSpecification.split("=", 2);
--- End diff --
I would use split without the limit, i.e., .split("=")
1. You already test for length below
2. this way you would miss invalid specifications such as key2=val1=val3
---
[GitHub] flink issue #5346: [FLINK-8490] [mesos] Allow custom docker parameters for d...
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/5346 Looks great! I need to test that tomorrow in more detail. @tillrohrmann @EronWright ---
[GitHub] flink pull request #5157: [hotfix] [docs] Consistent capitalization in Mesos...
GitHub user joerg84 opened a pull request: https://github.com/apache/flink/pull/5157 [hotfix] [docs] Consistent capitalization in Mesos documentation. *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.* *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.* ## Contribution Checklist - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue. - Name the pull request in the form "[FLINK-] [component] Title of the pull request", where *FLINK-* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component. Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices). - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message (including the JIRA id) - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)* ## Brief change log *(for example:)* - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact* - *Deployments RPC transmits only the blob storage reference* - *TaskManagers retrieve the TaskInfo from the blob cache* ## Verifying this change *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (100MB)* - *Extended integration test for recovery after master (JobManager) failure* - *Added test that validates that TaskInfo is transferred only once across recoveries* - *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) - The serializers: (yes / no / don't know) - The runtime per-record code paths (performance sensitive): (yes / no / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know) - The S3 file system connector: (yes / no / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) You can merge this pull request into a Git repository by running: $ git pull https://github.com/joerg84/flink patch-1 Alternatively you can review and apply these changes as the patch at:
[GitHub] flink pull request #5033: [FLINK-8102][docs] Fixed formatting issues in Meso...
GitHub user joerg84 opened a pull request: https://github.com/apache/flink/pull/5033 [FLINK-8102][docs] Fixed formatting issues in Mesos documentation. This change fixes formatting issues occurring in the markdown rendering. It was tested was building the documentation locally. You can merge this pull request into a Git repository by running: $ git pull https://github.com/joerg84/flink docu Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5033.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5033 commit bb2826b085da4a4119c13a1e6babdd78fc8de6aa Author: Joerg Schad <jo...@mesosphere.io> Date: 2017-11-18T06:23:02Z [FLINK-8102][docs] Fixed formatting issues in Mesos documentation. ---
[GitHub] flink pull request #3349: Updated DC/OS setup instructions.
GitHub user joerg84 opened a pull request:
https://github.com/apache/flink/pull/3349
Updated DC/OS setup instructions.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [X] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joerg84/flink docu
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3349.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3349
commit 256eb6b5ccdd4523e76b0f1ce6e4dc00f3e9
Author: Joerg Schad <jo...@mesosphere.io>
Date: 2017-02-17T15:10:53Z
Updated DC/OS setup instructions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3093 @sachingoel0101 PTAL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3093: [FLINK-5444] Made Flink UI links relative.
Github user joerg84 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3093#discussion_r95783168
--- Diff:
flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee
---
@@ -167,7 +167,7 @@ angular.module('flinkApp')
$scope.uploader['success'] = null
else
$scope.uploader['success'] = "Uploaded!"
- xhr.open("POST", "/jars/upload")
+ xhr.open("POST", "jars/upload")
--- End diff --
Thx for the explanation!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3100: [FLINK-5466] [webfrontend] Set environment to production ...
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3100 LGTM, thanks for fixing this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3093: [FLINK-5444] Made Flink UI links relative.
Github user joerg84 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3093#discussion_r95741031
--- Diff:
flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee
---
@@ -167,7 +167,7 @@ angular.module('flinkApp')
$scope.uploader['success'] = null
else
$scope.uploader['success'] = "Uploaded!"
- xhr.open("POST", "/jars/upload")
+ xhr.open("POST", "jars/upload")
--- End diff --
Thx, @sachingoel0101 could you provide me some more details on why that is
preferrable? Happy to change it, just want to understand the details it :-).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3093 Please retest! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3093 @zentol thanks and yes I verified the expected behavior. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3093 @zentol Thx! Could you check again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3093: [FLINK-5444] Made Flink UI links relative.
GitHub user joerg84 opened a pull request:
https://github.com/apache/flink/pull/3093
[FLINK-5444] Made Flink UI links relative.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joerg84/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3093
commit fa9b0c3642248d4329acb19bf0ac2ef461dbac66
Author: Joerg Schad <jo...@mesosphere.io>
Date: 2017-01-11T13:58:54Z
Made Flink UI links relative.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
