Github user kaelumania commented on the issue:
https://github.com/apache/flink/pull/3086
@mxm thanks :) needs there anything to be done, until this PR can be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kaelumania commented on the issue:
https://github.com/apache/flink/pull/3086
@mxn neither `docker build` nor `docker compose build` support setting
environment variables from outside during the build. Further as the
`docker-compose` documentation states
> N
Github user kaelumania commented on the issue:
https://github.com/apache/flink/pull/3086
@mxn One drawback using `ENV` might be with docker-compose, see
https://docs.docker.com/compose/compose-file/#/args which states
> You can omit the value when specifying a build argum
Github user kaelumania commented on the issue:
https://github.com/apache/flink/pull/3086
I am not sure, why the build fails as I am not deeply familiar with the
Java/Scala world.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kaelumania commented on the issue:
https://github.com/apache/flink/pull/3086
@greghogan No, I didn't create a Ticket (sorry, I was not sure if this
change justifies a Ticket). But I would love to see a Ticket about an automated
build at DockerHub for Flink.
---
If your
Github user kaelumania commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95384257
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,9 +22,9 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
Github user kaelumania commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95384182
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,9 +22,9 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
Github user kaelumania commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95383742
--- Diff: flink-contrib/docker-flink/docker-entrypoint.sh ---
@@ -36,9 +39,9 @@ elif [ "$1" == "taskmanager" ]; then
echo &q
GitHub user kaelumania opened a pull request:
https://github.com/apache/flink/pull/3086
Improve docker setup
Improves the overall docker setup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaelumania/flink improve-docker-setup
