GitHub user liuyuzhong7 opened a pull request:
https://github.com/apache/flink/pull/3532
FLINK-6041[flink-streaming-java] Move StreamingFunctionUtils to
'org.apache.flink.streaming.util'
StreamingFunctionUtils.java is in 'org.apache.flink.streaming.api.util
[
https://issues.apache.org/jira/browse/FLINK-6041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
liuyuzhong7 updated FLINK-6041:
---
Summary: Move StreamingFunctionUtils to 'org.apache.flink.streaming.util'
(was: Move
[
https://issues.apache.org/jira/browse/FLINK-6041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
liuyuzhong7 updated FLINK-6041:
---
Description:
StreamingFunctionUtils.java is in 'org.apache.flink.streaming.api.util
liuyuzhong7 created FLINK-6041:
--
Summary: Move StreamingFunctionUtils to
org.apache.flink.streaming.util
Key: FLINK-6041
URL: https://issues.apache.org/jira/browse/FLINK-6041
Project: Flink
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3485
@StephanEwen
FlatMapFunction "Tokenizer" has move to
org.apache.flink.test.testfunctions.
Help me to review this. Thanks.
And collect other reusable
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3485
OK, get it. So how about just do it now in flink-tests like this pull
request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3485
@StephanEwen It's a good idea. We can remove many duplicate code in
flink-tests in this way.
But I found it also duplicate in other modules. How to solve it in other
modules.
![image
Github user liuyuzhong7 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3485#discussion_r104826690
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/util/Tokenizer.java ---
@@ -0,0 +1,17 @@
+package org.apache.flink.test.util;
--- End
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3485
@uce
1. This pull request has squash in one commit.
2. JIRA has set affects version to 1.2.0
Help me to review this code, Thanks.
---
If your project is set up for it, you can
GitHub user liuyuzhong7 opened a pull request:
https://github.com/apache/flink/pull/3485
FLINK-5976 [tests] Deduplicate Tokenizer in tests
There are some duplicate code like this in flink-test, I think refactor
this will be better.
```
public final class Tokenizer
Github user liuyuzhong7 closed the pull request at:
https://github.com/apache/flink/pull/3482
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3482
@uce Thanks for review. OK, I'll do it later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/FLINK-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
liuyuzhong7 updated FLINK-5976:
---
Affects Version/s: (was: 2.0.0)
1.2.0
Fix Version/s
GitHub user liuyuzhong7 opened a pull request:
https://github.com/apache/flink/pull/3482
Flink-5976
There are some duplicate code like this in flink-test, I think refactor
this will be better.
```
public final class Tokenizer implements FlatMapFunction<String,
Tup
[
https://issues.apache.org/jira/browse/FLINK-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
liuyuzhong7 updated FLINK-5976:
---
Summary: Refactoring duplicate Tokenizer in flink-test (was: refactoring
remove duplicate Tokenizer
liuyuzhong7 created FLINK-5976:
--
Summary: refactoring remove duplicate Tokenizer in flink-test
Key: FLINK-5976
URL: https://issues.apache.org/jira/browse/FLINK-5976
Project: Flink
Issue Type
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3138
@zentol @StephanEwen Please help me to review this PR. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3138
@StephanEwen Fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3138
@StephanEwen What should to to with this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3138
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3138
@zentol Right, Strom LocalCluster can run in a single class without
powermock.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3138
@StephanEwen
Only LocalCluster in storm can't workwith powermock.
And it fail to init if ignore LocalCluster by powermock in
WrapperSetupHelperTest.
So I think delete or give
GitHub user liuyuzhong7 opened a pull request:
https://github.com/apache/flink/pull/3138
#Flink-5522 Storm Local Cluster can't work with powermock
Storm Local Cluster can't work with powermock.
Delete it because WrapperSetupHelperTest.testCreateTopologyContext doesn't
need
Github user liuyuzhong7 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3037#discussion_r96388944
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -186,15 +186,15 @@ public void
liuyuzhong7 created FLINK-5522:
--
Summary: Storm LocalCluster can't run with powermock
Key: FLINK-5522
URL: https://issues.apache.org/jira/browse/FLINK-5522
Project: Flink
Issue Type
Github user liuyuzhong7 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3037#discussion_r96218769
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -186,15 +186,15 @@ public void
Github user liuyuzhong7 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3037#discussion_r95098787
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -186,15 +186,15 @@ public void
GitHub user liuyuzhong7 opened a pull request:
https://github.com/apache/flink/pull/3037
Flink-4450 update storm version to 1.0
@StephanEwen @mxm
The old pull request #2439 was wrong , I use this account make a new pull
request.
Please me to review this pull request
28 matches
Mail list logo
