Github user matadorhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/601#discussion_r28594789
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
@@ -64,15 +64,19 @@
* @return the storage directory used
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/601
[FLINK-1891]Add the input storageDirectory empty check
Add the input storageDirectory empty check, if input of storageDirectory is
empty, we should use tmp as the base dir
And also fix
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/599
[FLINK-1887]Fix the message in runtime exception
RT,
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matadorhong/flink
Github user matadorhong commented on the pull request:
https://github.com/apache/flink/pull/569#issuecomment-89706960
OK. I accept it. I will close the PR. Thanks for your answer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user matadorhong closed the pull request at:
https://github.com/apache/flink/pull/569
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/569
[FLINK-1826]Remove the redundant codes never be executed in function
getNumPages
Remove the code never be executed in function getNumPages, because the
input of numBytes has be validataion
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/568
[FLINK-1825]Fix the constructor comments with correct parameter
.The comment in DefaultMemoryManager's constructor of parameters missing
'numberOfSlots'
You can merge this pull request
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/546
The class IOManagerAsync should use its own Log instance
Although class 'IOManagerAsync' is extended from 'IOManager' in package
'org.apache.flink.runtime.io.disk.iomanager', but I think
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/538
[FLINK]Remove the redunant import code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matadorhong/flink RemoveRedundantImport
Github user matadorhong commented on the pull request:
https://github.com/apache/flink/pull/511#issuecomment-86050415
@StephanEwen I have fixed the code style issue and changed the PR to an
Improvement one in jira.
Finally, great thanks for your help. And I will take more time
Github user matadorhong closed the pull request at:
https://github.com/apache/flink/pull/510
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/529
[FLINK-1779]Rename the function getCurrentyActiveConnections in '
org.apache.flink.runtime.blob'.
I think the function name getCurrentyActiveConnections in '
org.apache.flink.runtime.blob
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/522
[FLINK-1774]Remove the redundant code in try{} block.
Remove the redundant code of fos.close(); fos = null; in try block
because the fos,close() code will always executes in finally block.
You
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/515
Rename the variable 'contentAdressable' to 'contentAddressable'
Rename the variable 'contentAdressable' to 'contentAddressable' in order to
better understanding.
You can merge this pull request
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/514
[FLINK-1768]Fix the bug of BlobServerConnection's LOG.
The LOG in class of BlobServerConnection should be created by classloader
of BlobServerConnection.class
You can merge this pull request
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/511
[FLINK-1766]Fix the bug of equals function of FSKey
The equals function in org.apache.flink.core.fs.FileSystem.FSKey should
first confirm whether obj == this, if obj is the same object.It should
Github user matadorhong closed the pull request at:
https://github.com/apache/flink/pull/509
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/510
Add the class member variables with 'this'
Just add the class member variables with 'this' like other class member
variables in other class member function byunified format for good reading
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/509
[FLINK-1766]Fix the bug of equals function of FSKey
The equals function in org.apache.flink.core.fs.FileSystem.FSKey should
first confirm whether obj == this, if obj is the same object.It should
Github user matadorhong closed the pull request at:
https://github.com/apache/flink/pull/507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user matadorhong commented on the pull request:
https://github.com/apache/flink/pull/511#issuecomment-84489355
Great thanks to Ewen. I will first have a study of how to format code. Then
pull a request.
---
If your project is set up for it, you can reply to this email
Github user matadorhong commented on the pull request:
https://github.com/apache/flink/pull/511#issuecomment-84491491
Thanks for Ewen. That help me a lot to understand how to contribute to
Flink. I will follow the guide in the future.
---
If your project is set up for it, you can
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/507
Add the class member variables with 'this'
Just add the class member variables with 'this' like other class member
variables in other class member function byunified format for good reading
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/502
Remove redundant codes which never been executed
The following codes will never throw any execption, so the code of try
catch are redundant code, should be removed.
LOG.info(Loading
Github user matadorhong commented on the pull request:
https://github.com/apache/flink/pull/492#issuecomment-83649446
As in your comment in this PR, I think you make a small spelling mistake
Renames the package org.apache.flink.compiler to org.apache.fink.optimizer,
which should
Github user matadorhong closed the pull request at:
https://github.com/apache/flink/pull/502
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/499
[FLINK-1739]Fix the bug of JobManager and TaskManager Port Check.
The IPC port of JobManager and IPC port of TaskManager must be great than 0
and less than 65535.
It must have check the port
Github user matadorhong commented on the pull request:
https://github.com/apache/flink/pull/499#issuecomment-83238963
Have modified the port range of TaskManager in [0, 65535]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/490
modify the getlogger of the class
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matadorhong/flink logclass_317
Alternatively you can
Github user matadorhong closed the pull request at:
https://github.com/apache/flink/pull/495
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/495
Merge pull request #1 from apache/master
update
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matadorhong/flink master
Alternatively you
31 matches
Mail list logo
