[GitHub] flink pull request #3756: [FLINK-2013] Create generalized linear model frame...
Github user mtunique commented on a diff in the pull request: https://github.com/apache/flink/pull/3756#discussion_r142308699 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/regression/MultipleLinearRegressionITSuite.scala --- @@ -75,15 +75,16 @@ class MultipleLinearRegressionITSuite val parameters = ParameterMap() -parameters.add(MultipleLinearRegression.Stepsize, 2.0) -parameters.add(MultipleLinearRegression.Iterations, 10) -parameters.add(MultipleLinearRegression.ConvergenceThreshold, 0.001) +parameters.add(WithIterativeSolver.Stepsize, 2.0) +parameters.add(WithIterativeSolver.Iterations, 10) +parameters.add(WithIterativeSolver.ConvergenceThreshold, 0.001) mlr.fit(sparseInputDS, parameters) val weightList = mlr.weightsOption.get.collect() val WeightVector(weights, intercept) = weightList.head +println(weightList) --- End diff -- Ok I will delete it. ---
[GitHub] flink pull request #3719: [FLINK-6303] Documentation support build in docker...
Github user mtunique closed the pull request at: https://github.com/apache/flink/pull/3719 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3720 @StephanEwen I think it is the best way to solve this issue. I will follow the suggestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3720: [FLINK-6302] Documentation build error on ruby 2.4
Github user mtunique commented on a diff in the pull request: https://github.com/apache/flink/pull/3720#discussion_r113186869 --- Diff: docs/Gemfile.lock --- @@ -30,18 +30,19 @@ GEM redcarpet (~> 3.1) safe_yaml (~> 1.0) toml (~> 0.1.0) -jekyll-coffeescript (1.0.1) +jekyll-coffeescript (1.0.2) coffee-script (~> 2.2) + coffee-script-source (~> 1.11.1) jekyll-gist (1.4.0) - octokit (~> 4.3.0) + octokit (~> 4.2) --- End diff -- [https://github.com/jekyll/jekyll-gist/blob/master/jekyll-gist.gemspec](https://github.com/jekyll/jekyll-gist/blob/master/jekyll-gist.gemspec) In that file octokit version is 4.2. I am sorry about I don't have much knowledge about ruby, I don't know why it's 4.2 in previous. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3720: [FLINK-6302] Documentation build error on ruby 2.4
Github user mtunique commented on a diff in the pull request: https://github.com/apache/flink/pull/3720#discussion_r113186880 --- Diff: docs/Gemfile.lock --- @@ -30,18 +30,19 @@ GEM redcarpet (~> 3.1) safe_yaml (~> 1.0) toml (~> 0.1.0) -jekyll-coffeescript (1.0.1) +jekyll-coffeescript (1.0.2) coffee-script (~> 2.2) + coffee-script-source (~> 1.11.1) --- End diff -- I find [https://github.com/jekyll/jekyll/pull/5662](https://github.com/jekyll/jekyll/pull/5662), that PR add the dependency. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3719: [FLINK-6303] Documentation support build in docker on OSX
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3719 @patricklucas I have changed this PR follow #3751. In order to make the PRs clearly, the PR #3751 should just fix the issue FLINK-6330. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3428: [FLINK-1743] Add multinomial logistic regression to machi...
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3428 @thvasilo After #3756 is merged, I will change this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3756: [FLINK-2013] Create generalized linear model framework
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3756 Split from #3428. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3756: [FLINK-2013] Create generalized linear model frame...
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3756
[FLINK-2013] Create generalized linear model framework
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtunique/flink FLINK-2013
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3756.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3756
commit 4623cc91b0548aa8868a073c9ef8aba93a034377
Author: mtunique <oatg...@gmail.com>
Date: 2017-04-22T07:08:24Z
[FLINK-2013] Create generalized linear model framework
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3428: [FLINK-1743] Add multinomial logistic regression to machi...
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3428 Thanks all for the comments. The code from Spark has be labeled like some other codes from Spark. I will spilt this PR into two PRs. The other one is for FLINK-2013. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3428: [FLINK-1743] Add multinomial logistic regression to machi...
Github user mtunique commented on the issue:
https://github.com/apache/flink/pull/3428
@thvasilo
- Add `MultipleLinearRegression ` to provide interfaces for the set of
common properties and functions generalized linear models share.
- Change `LogisticLoss` to let it be with label in {0, 1}
- `LogisticLinerRegression` test: This test is originally from the Apache
Spark project. Training Data: Weights are created randomly. Label is calculated
by given scale and offset.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3719: [FLINK-6303] Documentation support build in docker on OSX
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3719 I will follow the branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3720: [FLINK-6302] Documentation build error on ruby 2.4
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3720
[FLINK-6302] Documentation build error on ruby 2.4
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtunique/flink FLINK-6302
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3720.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3720
commit ef9dc01f6c7bccc4e74afd883b7fe9141bdadb79
Author: mtunique <oatg...@gmail.com>
Date: 2017-04-13T12:22:41Z
[FLINK-6302] Documentation build error on ruby 2.4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3719: [FLINK-6303] Documentation support build in docker...
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3719
[FLINK-6303] Documentation support build in docker on OSX
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtunique/flink FLINK-6303
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3719.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3719
commit bda324c62980d5d3cc54fb91516713ef1e90c956
Author: mtunique <oatg...@gmail.com>
Date: 2017-04-13T12:22:41Z
[FLINK-6303] Documentation support build in docker on OSX
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3718: [FLINK-6112] Support Calcite 1.12's new numerical ...
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3718
[FLINK-6112] Support Calcite 1.12's new numerical functions
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
Because the function `asin` conflicts with the keyword `as`, I add keyword
`ASIN` in `ExpressionParser.scala`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtunique/flink FLINK-6112
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3718.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3718
commit 42ddcb3cf59f2c23e12dfb74b6596dd9a19dddb2
Author: mtunique <oatg...@gmail.com>
Date: 2017-04-07T10:04:03Z
add sin function
commit 8c4c08215446264eaa0439a8d771ff895e92943e
Author: mtunique <oatg...@gmail.com>
Date: 2017-04-11T14:08:03Z
add some builtin function
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3565: [FLINK-5413] [table] Convert TableEnvironmentITCases to u...
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3565 @KurtYoung I sorry about it, I will change it. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3565: [FLINK-5413] [table] Convert TableEnvironmentITCas...
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3565
[FLINK-5413] [table] Convert TableEnvironmentITCases to unit tests
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtunique/flink flink-5413
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3565.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3565
commit f7aa78de627ff2e29cbb685b53c0eda222669747
Author: mtunique <oatg...@gmail.com>
Date: 2017-03-18T08:34:56Z
[FLINK-5413] [table] Convert TableEnvironmentITCases to unit tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3463: [FLINK-5952] JobCancellationWithSavepointHandlersT...
Github user mtunique closed the pull request at: https://github.com/apache/flink/pull/3463 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3463: [FLINK-5952] JobCancellationWithSavepointHandlersT...
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3463
[FLINK-5952] JobCancellationWithSavepointHandlersTest uses deprecated
JsonNode#getValuesAsText
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtunique/flink FLINK-5952
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3463.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3463
commit d73d108ae9f8013aa541fb49b0b2d3d8ee7c3ae5
Author: mtunique <oatg...@gmail.com>
Date: 2017-03-03T03:37:51Z
[FLINK-5952] JobCancellationWithSavepointHandlersTest uses deprecated
JsonNode#getValuesAsText
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3428: [FLINK-1743] Add multinomial logistic regression t...
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3428
[FLINK-1743] Add multinomial logistic regression to machine learning library
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
1. Refactor `MultipleLinearRegression` to extend `GeneralizedLinearModel`
2. Implement `LogisticRegression`
3. Change `LogisticLoss` with label in {0, 1}
4. Add `LogisticLinerRegression` test case
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtunique/flink glm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3428.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3428
commit f2fd9bb4d3b93968ff770180fc6767d0316d8958
Author: mtunique <oatg...@gmail.com>
Date: 2017-02-21T10:30:37Z
add logistic regression
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #1985: [FLINK-1979] Add logistic loss, hinge loss and regulariza...
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/1985 Could this PR be merged ? Maybe this PR blocks to design GLM([FLINK-2013](https://issues.apache.org/jira/browse/FLINK-2013)). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously" inter...
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3087 Maybe we should open an issue about `Checkpointed` java doc to talk about how to replace the APIs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3099: [FLINK-5268] Split TableProgramsTestBase into Tabl...
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3099
[FLINK-5268] Split TableProgramsTestBase into
TableProgramsCollectionTestBase and TableProgramsClusterTestBase
â¦TestBase and TableProgramsClusterTestBase
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtunique/flink flink-5268
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3099.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3099
commit a99b2bfe5a06677163cf62dcc6716bf641422d5e
Author: mtunique <oatg...@gmail.com>
Date: 2017-01-12T09:30:57Z
[FLINK-5268] Split TableProgramsTestBase into
TableProgramsCollectionTestBase and TableProgramsClusterTestBase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3098: [FLINK-5438] Typo in JobGraph generator Exception
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3098
[FLINK-5438] Typo in JobGraph generator Exception
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtunique/flink flink-5438
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3098.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3098
commit 4e141e4573e8fb533d59f0080b6174fafb542a1d
Author: mtunique <oatg...@gmail.com>
Date: 2017-01-12T04:02:49Z
[FLINK-5438] Typo in JobGraph generator Exception
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3097: [FLINK-5448] Fix typo in StateAssignmentOperation ...
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3097
[FLINK-5448] Fix typo in StateAssignmentOperation Exception
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtunique/flink flink-5448
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3097.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3097
commit 99fc15bf59da083764a7e0dd9f599aacaff670dc
Author: mtunique <oatg...@gmail.com>
Date: 2017-01-12T03:55:57Z
[FLINK-5448] Fix typo in StateAssignmentOperation Exception
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously" inter...
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3087 @greghogan I have add the javadoc about replacement. Maybe `Checkpointed` has the same problem about javadoc. Fix it in this PR or create a new issue on jira? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously" inter...
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3087 I am sorry about it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously...
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3087 [FLINK-4917] Deprecate "CheckpointedAsynchronously" interface - [x] General - The pull request references the related JIRA issue ([FLINK-4917] Deprecate "CheckpointedAsynchronously" interface) - The pull request addresses only one issue - Each commit in the PR has a meaningful commit message (including the JIRA id) - [x] Documentation - Documentation has been added for new functionality - Old documentation affected by the pull request has been updated - JavaDoc for public methods has been added - [x] Tests & Build - Functionality added by the pull request is covered by tests - `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtunique/flink flink-4917 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3087.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3087 commit e4ed2142447daf585cdd0c76fadc559429f8ac11 Author: mtunique <oatg...@gmail.com> Date: 2017-01-10T15:05:44Z [FLINK-4917] Deprecate "CheckpointedAsynchronously" interface --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2977: [FLINK-5084] Replace Java Table API integration tests by ...
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/2977 @fhueske Done. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2977: [FLINK-5084] Replace Java Table API integration tests by ...
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/2977 @fhueske I have finished all about comments and rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3041: Flink 5084 tmp
Github user mtunique closed the pull request at: https://github.com/apache/flink/pull/3041 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3041: Flink 5084 tmp
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3041
Flink 5084 tmp
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtunique/flink flink-5084-tmp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3041.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3041
commit 3fa59c4baca5f6f1b5634e4ef173f6e8808b5b96
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-09T05:23:36Z
add table java api ut (join)
commit d2e9303c077b5bb0c60dc8ec9e948a51ca1a40cd
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-09T05:25:35Z
delete table java api it case (join)
commit 7700b266d450f29ce992f98d3b3e2400d126f062
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-09T08:04:00Z
add LogicalPlanFormatUtils
commit 5b3e96eb893bfbd3a53019473f5784a16ebd
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-09T08:05:23Z
join case use logicalplan format
commit 2cbb7f98dedf3c4b9d0072940409b8fc6c629b6f
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-09T08:45:10Z
add table java api ut case (Agg)
commit bd15e481b0831e4c82347214537349a6ac5c9ef3
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-09T11:09:15Z
delete table java api it case (Agg)
commit bbfa34e1e58efcd0481682b4166d0019cdaa515e
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-09T11:14:00Z
[FLINK-5084] Replace Java Table API integration tests by unit tests
commit f457a8685647877a6e3534b32f97b1f2cb534c51
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-10T18:20:50Z
remove validation case from AggregationsITCase
commit 5d746ff311a5731f73519a8af26f2b5e78dc74f5
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-10T18:25:40Z
add AggregationsValidationTest
commit d4da0cfd3499c961ba426ecec0b2a40cd9b2fe36
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-10T18:57:11Z
remove validation case from JoinITCase
commit 9285c81ffebd833b1f6c729bb990b68286aa3c3b
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-10T18:57:42Z
add JoinValidationTest
commit cbccded4d7d0c25b34a316c4c42d703a3c55b0bc
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-10T19:08:07Z
add SetOperatorsValidationTest
commit c3875d855033e2125a7d19c6a6eed18eed69e0b3
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-10T19:08:45Z
add SortValidationTest
commit d00fd6256e4977bbc86033143132d0738abab67d
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-11T06:09:26Z
add CalcValidationTest
commit 0293e0c598beb2d1be3228f3ff3e3de4f4df6bea
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-12T09:02:40Z
delete table java IT case
commit ec20ed6a539f783cf12f1af0450289c6011549ce
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-12T09:15:19Z
add join plan case
commit bacb137d8ae44a2df6294e967a3f6ecd74f6becc
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-12T09:30:12Z
add calc plan test
commit 0f5568ca8bd590055a336c95e885d15e98338c53
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-12T09:30:33Z
add join plan test
commit f8db10e488aa5df32a1533362f52acb054380b97
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-12T09:47:19Z
add agg plan test
commit 4b120ab44416a3c17261dedae699389f772305a9
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-12T10:02:31Z
add cast test
commit 81767b6700e83dc1aa1b0bdadd756ecafdeba089
Author: mtunique <oatg...@gmail.com>
Date: 2016-12-12T10:05:33Z
delete unused import
commit 24753f9a4d7ed0b9b09a98fcb980b8db201be625
Author: mtunique
[GitHub] flink issue #2977: [FLINK-5084] Replace Java Table API integration tests by ...
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/2977 @fhueske I have finish there tasks: - remove `./test/java/org/apache/flink/api/java/batch/ExplainTest` - All tests in `test/java/org/apache/flink/api/java/batch/table` are implemented in Scala and moved to the ./test/scala/ directory. - Move validation tests into new files. - Add plan tests (some have the java version and some are new). It is time to review these codes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2977: [FLINK-5084] Replace Java Table API integration tests by ...
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/2977 Thanks @fhueske . I agree very much. It is necessary to split the tests into a validation and a plan test class. I will follow the suggestions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2977: Flink 5084
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/2977 Flink 5084 I replace the Java Table API ITCases by tests that check that the parsing step produces a valid logical plan. Before I delete the ITCases, I have check there are UTCases in scala. I left the Java special ITCases. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtunique/flink flink-5084 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2977.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2977 commit d683451deb782e6759e931484c102f4cf5a8671a Author: mtunique <oatg...@gmail.com> Date: 2016-12-09T05:23:36Z add table java api ut (join) commit b0acd27d0a1a3b34776da7b85f2c12657a59922f Author: mtunique <oatg...@gmail.com> Date: 2016-12-09T05:25:35Z delete table java api it case (join) commit 278bf89268f9401b4d9347a1609fb93871e28005 Author: mtunique <oatg...@gmail.com> Date: 2016-12-09T08:04:00Z add LogicalPlanFormatUtils commit 48d1c1b35d70b9bd7cd48e395e0836ca828c5bc3 Author: mtunique <oatg...@gmail.com> Date: 2016-12-09T08:05:23Z join case use logicalplan format commit e8d5bb4ac8a0d0777ee75f84e0099ade2b23f441 Author: mtunique <oatg...@gmail.com> Date: 2016-12-09T08:45:10Z add table java api ut case (Agg) commit 081806017f48518c29838ed01214d2e12bc155d1 Author: mtunique <oatg...@gmail.com> Date: 2016-12-09T11:09:15Z delete table java api it case (Agg) commit 5d3d9b8efa786802a98409a2ff99c528482ec93b Author: mtunique <oatg...@gmail.com> Date: 2016-12-09T11:14:00Z [FLINK-5084] Replace Java Table API integration tests by unit tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
