GitHub user nekrassov opened a pull request:
https://github.com/apache/flink/pull/6298
[FLINK-9784] Fix inconsistent use of 'static' in AsyncIOExample.java
## What is the purpose of the change
This patch fixes inconsistent use of `static` in AsyncIOExample.java that
can
GitHub user nekrassov opened a pull request:
https://github.com/apache/flink/pull/6295
Add *.snapshot binary files to RAT exclusion list
## What is the purpose of the change
This patch adds binary *.snapshot files to the RAT plugin exclusion list to
avoid RAT error when
Github user nekrassov commented on the issue:
https://github.com/apache/flink/pull/6247
https://issues.apache.org/jira/browse/FLINK-9784 created
---
Alexei Nekrassov created FLINK-9784:
---
Summary: Inconsistent use of 'static' in AsyncIOExample.java
Key: FLINK-9784
URL: https://issues.apache.org/jira/browse/FLINK-9784
Project: Flink
Github user nekrassov commented on the issue:
https://github.com/apache/flink/pull/6247
lamber-ken, please let me know if you will open a separate JIRA and PR to
make `random, executorService` non-static, remove `synchronized`, and remove
`counter`. Or I can do that.
---
Github user nekrassov commented on the issue:
https://github.com/apache/flink/pull/6247
there is a "Show outdated" button to see comments on the reverted commit.
I sent email to dev list, because I'm still not clear what was the original
intent of the code, and how open() behaves.
---
Github user nekrassov commented on a diff in the pull request:
https://github.com/apache/flink/pull/6247#discussion_r200434401
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -116,8 +116,8
Github user nekrassov commented on a diff in the pull request:
https://github.com/apache/flink/pull/6247#discussion_r200423552
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -116,8 +116,8
Github user nekrassov commented on a diff in the pull request:
https://github.com/apache/flink/pull/6247#discussion_r200415625
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -116,8 +116,8
Github user nekrassov commented on a diff in the pull request:
https://github.com/apache/flink/pull/6247#discussion_r200413115
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -179,7 +179,7
Github user nekrassov commented on a diff in the pull request:
https://github.com/apache/flink/pull/6247#discussion_r200393008
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -179,7 +179,7
Github user nekrassov commented on a diff in the pull request:
https://github.com/apache/flink/pull/6247#discussion_r200369787
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -179,7 +179,7
12 matches
Mail list logo
