[GitHub] flink pull request #3366: [FLINK-3427] [webui] watermarks tab and low waterm...

2017-02-23 Thread nellboy
Github user nellboy commented on a diff in the pull request: https://github.com/apache/flink/pull/3366#discussion_r102726602 --- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.ctrl.coffee --- @@ -81,6 +78,51 @@ angular.module('flinkApp

[GitHub] flink pull request #3366: [FLINK-3427] [webui] watermarks tab and low waterm...

2017-02-23 Thread nellboy
Github user nellboy commented on a diff in the pull request: https://github.com/apache/flink/pull/3366#discussion_r102726645 --- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.ctrl.coffee --- @@ -81,6 +78,51 @@ angular.module('flinkApp

[GitHub] flink pull request #3366: [FLINK-3427] [webui] watermarks tab and low waterm...

2017-02-23 Thread nellboy
Github user nellboy commented on a diff in the pull request: https://github.com/apache/flink/pull/3366#discussion_r102726782 --- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.ctrl.coffee --- @@ -318,3 +360,7 @@ angular.module('flinkApp') loadMetrics

[GitHub] flink pull request #3366: [FLINK-3427] [webui] watermarks tab and low waterm...

2017-02-23 Thread nellboy
Github user nellboy commented on a diff in the pull request: https://github.com/apache/flink/pull/3366#discussion_r102726588 --- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.ctrl.coffee --- @@ -81,6 +78,51 @@ angular.module('flinkApp

[GitHub] flink pull request #3366: [FLINK-3427] [webui] watermarks tab and low waterm...

2017-02-23 Thread nellboy
Github user nellboy commented on a diff in the pull request: https://github.com/apache/flink/pull/3366#discussion_r102726454 --- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.ctrl.coffee --- @@ -81,6 +78,51 @@ angular.module('flinkApp

[GitHub] flink pull request #3366: [FLINK-3427] [webui] watermarks tab and low waterm...

2017-02-23 Thread nellboy
Github user nellboy commented on a diff in the pull request: https://github.com/apache/flink/pull/3366#discussion_r102726419 --- Diff: flink-runtime-web/web-dashboard/app/scripts/index.coffee --- @@ -30,7 +30,7 @@ angular.module('flinkApp', ['ui.router', 'angularMoment', 'dndLists

[GitHub] flink pull request #3366: [FLINK-3427] [webui] watermarks tab and low waterm...

2017-02-23 Thread nellboy
Github user nellboy commented on a diff in the pull request: https://github.com/apache/flink/pull/3366#discussion_r102726198 --- Diff: flink-runtime-web/web-dashboard/app/scripts/common/filters.coffee --- @@ -87,3 +87,27 @@ angular.module('flinkApp') .filter "perce

[GitHub] flink pull request #3366: [FLINK-3427] [webui] watermarks tab and low waterm...

2017-02-23 Thread nellboy
Github user nellboy commented on a diff in the pull request: https://github.com/apache/flink/pull/3366#discussion_r102725785 --- Diff: flink-runtime-web/web-dashboard/app/scripts/common/filters.coffee --- @@ -87,3 +87,27 @@ angular.module('flinkApp') .filter "perce

[GitHub] flink pull request #3366: [FLINK-3427] [webui] watermarks tab and low waterm...

2017-02-23 Thread nellboy
Github user nellboy commented on a diff in the pull request: https://github.com/apache/flink/pull/3366#discussion_r102725620 --- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.node.watermarks.jade --- @@ -0,0 +1,27 @@ +// + Licensed to the Apache

[GitHub] flink pull request #3366: [FLINK-3427] [webui] watermarks tab and low waterm...

2017-02-23 Thread nellboy
Github user nellboy commented on a diff in the pull request: https://github.com/apache/flink/pull/3366#discussion_r102725706 --- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.node.watermarks.jade --- @@ -0,0 +1,27 @@ +// + Licensed to the Apache

[GitHub] flink issue #3369: [FLINK-5831] [webui] order, search and filter metrics

2017-02-21 Thread nellboy
Github user nellboy commented on the issue: https://github.com/apache/flink/pull/3369 Ok, this has been updated now. ![screen shot 2017-02-21 at 11 02 41](https://cloud.githubusercontent.com/assets/39847/23160154/b2ea3f90-f825-11e6-8f3e-5f775b8204a8.png) --- If your project

[GitHub] flink pull request #3369: [FLINK-5831] [webui] order, search and filter metr...

2017-02-20 Thread nellboy
GitHub user nellboy opened a pull request: https://github.com/apache/flink/pull/3369 [FLINK-5831] [webui] order, search and filter metrics Metrics are now ordered, and searchable when displaying which metrics graphs to display in the web ui. ![screen shot 2017-02-20 at 16 09

[GitHub] flink pull request #3362: [FLINK-5831] [webui] order, search and filter metr...

2017-02-20 Thread nellboy
Github user nellboy closed the pull request at: https://github.com/apache/flink/pull/3362 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #3367: [FLINK-5819] [webui] implements numeric option on ...

2017-02-20 Thread nellboy
GitHub user nellboy opened a pull request: https://github.com/apache/flink/pull/3367 [FLINK-5819] [webui] implements numeric option on metrics graphs [FLINK-5819] [webui] implements numeric option on metrics graphs ![pasted image at 2017_02_17 13_56](https

[GitHub] flink pull request #3361: [FLINK-5819] [webui] implements numeric option on ...

2017-02-20 Thread nellboy
Github user nellboy closed the pull request at: https://github.com/apache/flink/pull/3361 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #3333: Webui/watermarks

2017-02-20 Thread nellboy
Github user nellboy closed the pull request at: https://github.com/apache/flink/pull/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #3366: Webui/watermarks tab

2017-02-20 Thread nellboy
GitHub user nellboy opened a pull request: https://github.com/apache/flink/pull/3366 Webui/watermarks tab implement watermarks tab and display low watermarks on graph nodes. ![screen shot 2017-02-20 at 17 54 51](https://cloud.githubusercontent.com/assets/39847/23135205/fb8419f8

[GitHub] flink issue #3362: [FLINK-5831] [webui] order, search and filter metrics

2017-02-20 Thread nellboy
Github user nellboy commented on the issue: https://github.com/apache/flink/pull/3362 Yes, here is the screenshot ... also will rebase on master ![screen shot 2017-02-20 at 16 09 58](https://cloud.githubusercontent.com/assets/39847/23130544/2f022510-f787-11e6-84d3-b423b2fec8d2.png

[GitHub] flink issue #3361: [FLINK-5819] [webui] implements numeric option on metrics...

2017-02-20 Thread nellboy
Github user nellboy commented on the issue: https://github.com/apache/flink/pull/3361 certainly, my apologies. Please find attached ![pasted image at 2017_02_17 13_56](https://cloud.githubusercontent.com/assets/39847/23130481/dc33c384-f786-11e6-85c5-21a8cf6b9f11.png

[GitHub] flink pull request #3362: [FLINK-5831] [webui] order, search and filter metr...

2017-02-20 Thread nellboy
GitHub user nellboy opened a pull request: https://github.com/apache/flink/pull/3362 [FLINK-5831] [webui] order, search and filter metrics When adding metrics, available metrics are now ordered alphabetically and filtered via a search box You can merge this pull request into a Git

[GitHub] flink pull request #3361: [FLINK-5819] [webui] implements numeric option on ...

2017-02-20 Thread nellboy
GitHub user nellboy opened a pull request: https://github.com/apache/flink/pull/3361 [FLINK-5819] [webui] implements numeric option on metrics graphs enables toggling between numeric and graph view for metrics graphs You can merge this pull request into a Git repository by running

[GitHub] flink pull request #3333: Webui/watermarks

2017-02-16 Thread nellboy
GitHub user nellboy opened a pull request: https://github.com/apache/flink/pull/ Webui/watermarks Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items