[GitHub] flink issue #2612: FLINK-4771: Compression for AvroOutputFormat

2016-10-14 Thread qingdao81
Github user qingdao81 commented on the issue: https://github.com/apache/flink/pull/2612 Thats good news :-) Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #2612: FLINK-4771: Compression for AvroOutputFormat

2016-10-14 Thread qingdao81
Github user qingdao81 commented on a diff in the pull request: https://github.com/apache/flink/pull/2612#discussion_r83372815 --- Diff: flink-batch-connectors/flink-avro/src/test/java/org/apache/flink/api/java/io/AvroOutputFormatTest.java --- @@ -0,0 +1,126 @@ +package

[GitHub] flink pull request #2612: FLINK-4771: Compression for AvroOutputFormat

2016-10-13 Thread qingdao81
Github user qingdao81 commented on a diff in the pull request: https://github.com/apache/flink/pull/2612#discussion_r83307880 --- Diff: flink-batch-connectors/flink-avro/src/test/java/org/apache/flink/api/java/io/AvroOutputFormatTest.java --- @@ -0,0 +1,126 @@ +package

[GitHub] flink issue #2612: FLINK-4771: Compression for AvroOutputFormat

2016-10-11 Thread qingdao81
Github user qingdao81 commented on the issue: https://github.com/apache/flink/pull/2612 Thanks for the review @fhueske I implemented the changes you requested. Not sure if the Codec enum in AvroOutputFormat is the best solution because its an additional wrapper around the avro

[GitHub] flink pull request #2612: FLINK-4771: Compression for AvroOutputFormat

2016-10-08 Thread qingdao81
GitHub user qingdao81 opened a pull request: https://github.com/apache/flink/pull/2612 FLINK-4771: Compression for AvroOutputFormat Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your