Github user r-pogalz commented on a diff in the pull request:
https://github.com/apache/flink/pull/1138#discussion_r41505034
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/base/OuterJoinOperatorBase.java
---
@@ -0,0 +1,314 @@
+/*
+ * Licensed
Github user r-pogalz commented on the pull request:
https://github.com/apache/flink/pull/1052#issuecomment-138221929
The warnings fix commit is ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user r-pogalz commented on the pull request:
https://github.com/apache/flink/pull/1052#issuecomment-137780075
Thanks for you comment @StephanEwen, good to know that. I tried to minimize
the occurrences of warnings where possible by fixing or suppressing it for this
issue
Github user r-pogalz commented on the pull request:
https://github.com/apache/flink/pull/1052#issuecomment-136056199
Hi @tillrohrmann, @fhueske and @chiwanpark,
thanks for your reviews and comments. I went through the classes and
changed the formatting. Moreover, I refactored
Github user r-pogalz commented on the pull request:
https://github.com/apache/flink/pull/1052#issuecomment-134898862
Hi @tillrohrmann, thanks for your review and comments. I will work through
it soon.
Regarding the ticket FLINK-2106, @fhueske suggested us to create multiple
GitHub user r-pogalz opened a pull request:
https://github.com/apache/flink/pull/1052
[FLINK-2106] Runtime part
This PR includes the implementation of 3 drivers (Left-, Right-,
FullOuterJoinDriver) and adapts the DriverStrategy for the merge based outer
joins (LEFT_, RIGHT_
Github user r-pogalz commented on the pull request:
https://github.com/apache/flink/pull/907#issuecomment-127546250
Alright, I created a ticket
([FLINK-2479](https://issues.apache.org/jira/browse/FLINK-2479)) for adjustment
of the other tests.
Is there still anything left
Github user r-pogalz commented on the pull request:
https://github.com/apache/flink/pull/907#issuecomment-127293419
Hello @fhueske,
I see you noticed that we replaced all occurrences of `Record` by
`Tuple2Integer, String` in the InnerJoin- and OuterJoinITCases. The issue
Github user r-pogalz commented on the pull request:
https://github.com/apache/flink/pull/907#issuecomment-126517321
@fhueske, I ran through the classes and tried to catch all occurrences of
`match` and replaced them by `join`. Hopefully I did not miss something :)
Moreover, I
GitHub user r-pogalz opened a pull request:
https://github.com/apache/flink/pull/907
FLINK-2105: Implement Sort-Merge Outer Join algorithm
This pull request relates to
[FLINK-2105](https://issues.apache.org/jira/browse/FLINK-2105) and includes:
* Extraction
10 matches
Mail list logo
