[GitHub] flink pull request: [FLINK-2375] Add Approximate Adamic Adar Simil...

2016-04-03 Thread shghatge
Github user shghatge closed the pull request at: https://github.com/apache/flink/pull/923 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2016-04-03 Thread shghatge
Github user shghatge closed the pull request at: https://github.com/apache/flink/pull/892 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-09-01 Thread shghatge
Github user shghatge closed the pull request at: https://github.com/apache/flink/pull/847 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-09-01 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/892#issuecomment-136667142 @vasia This is giving merge conflicts when rebasing. Since the conflicts are in commits other than mine, I am thinking of creating a new PR. I have done the similar

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-09-01 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-13651 @vasia It is fine with me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-08-07 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/892#issuecomment-128866366 I made some of the changes mentioned. But there was a problem in replacing the getTriplets() and flatMap. When I use this method private static final class ReduceN

[GitHub] flink pull request: [FLINK-2375] Add Approximate Adamic Adar Simil...

2015-07-20 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/923#issuecomment-123051521 Updated PR @vasia I removed the Vertex Centric Iteration :) Hope this method is okay. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-20 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/892#issuecomment-123051793 @andralungu @vasia PR has been updated to make the code more efficient. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-20 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-123057981 The only problem with assuming NullValue if a value is missing is that we can't return NullValue in place of VV. I mean to say GraphK, VV, EV in this VV or EV can't

[GitHub] flink pull request: [FLINK-2075] Add Approximate Adamic Adar Simil...

2015-07-19 Thread shghatge
GitHub user shghatge opened a pull request: https://github.com/apache/flink/pull/923 [FLINK-2075] Add Approximate Adamic Adar Similarity Measure Example t… …o Gelly Implementation of Adamic Adar Similarity Measure using BloomFilters You can merge this pull request

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-10 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/892#issuecomment-120366455 Hello @vasia Thanks for the clarification. I was only thinking of changing the data structure :) But this method seems much more sensible. In any case... Should I

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-09 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/892#issuecomment-120036933 Hello @vasia I would like to work on both versions of Adamic Adar. As the JIRA did not ask for an approximate version, it was suggested that I create another JIRA

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-09 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/892#issuecomment-120033517 Hello @vasia I would like to work on both versions of Adamic Adar. As the JIRA did not ask for an approximate version, it was suggested that I create another JIRA

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-08 Thread shghatge
GitHub user shghatge opened a pull request: https://github.com/apache/flink/pull/892 [FLINK-2310] Add an Adamic Adar Similarity example Added an Adamic Adar Similarity example to Gelly. Added one test accordingly for the same. You can merge this pull request into a Git

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-08 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/892#issuecomment-119705269 Updated PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-08 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/892#issuecomment-119714675 Updated PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-08 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-119705061 Updated PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-06 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-118921231 Updated PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-06 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-11815 Updated PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-06 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-11598 Updated PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-02 Thread shghatge
Github user shghatge commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33823720 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,471 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-02 Thread shghatge
Github user shghatge commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33823858 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,471 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-02 Thread shghatge
Github user shghatge commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33824099 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphCreationITCase.java --- @@ -54,16 +75,13 @@ public void

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-01 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-117730019 Updated PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-01 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-117728162 Updated PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-06-30 Thread shghatge
GitHub user shghatge opened a pull request: https://github.com/apache/flink/pull/877 [FLINK-2141] Allow GSA's Gather to perform this operation in more than one direction Added the setDirection() and getDirection() methods to GSAConfiguration.java Added functionality to gather

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-24 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-114975168 Updated PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-24 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-114983698 Updated PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-19 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-113439469 Hello @Andra There is one test for fromCsv with mapper in GraphCreationWithMapperITCase.java Should I add more tests for that? Also for the examples

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-18 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-113147138 Updated the PR by changing the removeVertices(DataSetVertexK, VV) method access from Public to Private. It is only used as a helper function for the difference method

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-18 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-113150859 Updated the docs accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-18 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-113165614 Updated PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-18 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-113107660 Hello @vasia I will follow the guidelines and add the tests that are suggested by you when making a commit. For the separate configuration methods issue, I

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread shghatge
Github user shghatge commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32674875 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread shghatge
Github user shghatge commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32674326 --- Diff: docs/libs/gelly_guide.md --- @@ -102,6 +102,15 @@ DataSetTuple3String, String, Double edgeTuples = env.readCsvFile(path/to/ed GraphString

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread shghatge
Github user shghatge commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32675117 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread shghatge
Github user shghatge commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32676617 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread shghatge
Github user shghatge commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32675480 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: Csv read graph

2015-06-17 Thread shghatge
GitHub user shghatge opened a pull request: https://github.com/apache/flink/pull/846 Csv read graph [FLINK-1520]Read edges and vertices from CSV files Changes done- 1) Added a GraphCsvReader class which has 2 CsvReaders as members EdgeReader and VertexReader

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread shghatge
GitHub user shghatge opened a pull request: https://github.com/apache/flink/pull/847 [FLINK-1520]Read edges and vertices from CSV files [FLINK-1520]Read edges and vertices from CSV files Changes done- 1) Added a GraphCsvReader class which has 2 CsvReaders

[GitHub] flink pull request: [FLINK-1520] Read edges and vertices from CSV ...

2015-06-17 Thread shghatge
Github user shghatge closed the pull request at: https://github.com/apache/flink/pull/846 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-17 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-112827357 Hello @vasia Could you please elaborate on what should be the future course of action? Should I put the content of removeVertices(DataSet) method

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-10 Thread shghatge
GitHub user shghatge opened a pull request: https://github.com/apache/flink/pull/818 [FLINK-2093][gelly] Added difference Method Tasks given on 5th June: Add a difference function to the Graph.java Modify the docs 'gelly-guide.md' Add the test case for difference

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-09 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/807#issuecomment-110380728 Hi @fhueske I am sorry for closing the pull request. Now onwards I will follow the approach you suggested. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread shghatge
Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/807#issuecomment-110078878 Then it was just removing vertices! Talk about swatting a Fly with a Sledgehammer! I will do all the changes you suggested. --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread shghatge
Github user shghatge closed the pull request at: https://github.com/apache/flink/pull/807 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference method

2015-06-08 Thread shghatge
GitHub user shghatge opened a pull request: https://github.com/apache/flink/pull/807 [FLINK-2093][gelly] Added difference method Tasks given on 5th June: Add a difference function to the Graph.java Modify the docs 'gelly-guide.md' Add the test case for difference