[jira] [Commented] (FLINK-35230) Split FlinkSqlParserImplTest to reduce the code lines.

2024-04-24 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840623#comment-17840623 ] Shuai Xu commented on FLINK-35230: -- [~lsy]  I'd like to take this, would you assign it to me? > Sp

[jira] [Commented] (FLINK-35184) Hash collision inside MiniBatchStreamingJoin operator

2024-04-22 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839947#comment-17839947 ] Shuai Xu commented on FLINK-35184: -- Absolutely, please feel free to start the implementation. > H

[jira] [Comment Edited] (FLINK-35184) Hash collision inside MiniBatchStreamingJoin operator

2024-04-22 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839947#comment-17839947 ] Shuai Xu edited comment on FLINK-35184 at 4/23/24 5:46 AM: --- [~rovboyko

[jira] [Commented] (FLINK-35184) Hash collision inside MiniBatchStreamingJoin operator

2024-04-22 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839920#comment-17839920 ] Shuai Xu commented on FLINK-35184: -- Hi [~rovboyko] , actually it can't be avoid hash collision even

[jira] [Commented] (FLINK-35184) Hash collision inside MiniBatchStreamingJoin operator

2024-04-21 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839464#comment-17839464 ] Shuai Xu commented on FLINK-35184: -- Hi [~rovboyko] , thx for reporting this bug which is caused

[jira] [Comment Edited] (FLINK-34694) Delete num of associations for streaming outer join

2024-04-10 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835668#comment-17835668 ] Shuai Xu edited comment on FLINK-34694 at 4/10/24 9:43 AM: --- Hi [~rovboyko

[jira] [Commented] (FLINK-34694) Delete num of associations for streaming outer join

2024-04-10 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835668#comment-17835668 ] Shuai Xu commented on FLINK-34694: -- Hi [~rovboyko], The method

[jira] [Commented] (FLINK-34694) Delete num of associations for streaming outer join

2024-04-10 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835648#comment-17835648 ] Shuai Xu commented on FLINK-34694: -- Hi [~rovboyko] , your idea looks interesting. Actually I found

[jira] [Commented] (FLINK-34380) Strange RowKind and records about intermediate output when using minibatch join

2024-02-29 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822433#comment-17822433 ] Shuai Xu commented on FLINK-34380: -- Let me take a look. > Strange RowKind and records ab

[jira] (FLINK-34500) Release Testing: Verify FLINK-33261 Support Setting Parallelism for Table/SQL Sources

2024-02-22 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34500 ] Shuai Xu deleted comment on FLINK-34500: -- was (Author: JIRAUSER300096): Hi, Could I take this verification? > Release Testing: Verify FLINK-33261 Support Setting Parallelism for Table/

[jira] [Commented] (FLINK-34500) Release Testing: Verify FLINK-33261 Support Setting Parallelism for Table/SQL Sources

2024-02-22 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819964#comment-17819964 ] Shuai Xu commented on FLINK-34500: -- Hi, Could I take this verification? > Release Testing: Ver

[jira] [Updated] (FLINK-34219) Introduce a new join operator to support minibatch

2024-02-20 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-34219: - Release Note: Support minibatch regular join to reduce intermediate result and resolve record

[jira] [Commented] (FLINK-34346) Release Testing: Verify FLINK-24024 Support session Window TVF

2024-02-19 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818612#comment-17818612 ] Shuai Xu commented on FLINK-34346: -- Hi, I have finished this testing. The exception I think could

[jira] [Commented] (FLINK-34355) Release Testing: Verify FLINK-34054 Support named parameters for functions and procedures

2024-02-19 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818611#comment-17818611 ] Shuai Xu commented on FLINK-34355: -- Hi, I have finished this verification. > Release Testing: Ver

[jira] [Created] (FLINK-34462) Session window with negative parameter throws unclear exception

2024-02-19 Thread Shuai Xu (Jira)
Shuai Xu created FLINK-34462: Summary: Session window with negative parameter throws unclear exception Key: FLINK-34462 URL: https://issues.apache.org/jira/browse/FLINK-34462 Project: Flink

[jira] [Commented] (FLINK-34378) Minibatch join disrupted the original order of input records

2024-02-19 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818384#comment-17818384 ] Shuai Xu commented on FLINK-34378: -- Hi [~xuyangzhong] . This is an expected behavior. To maintain order

[jira] [Comment Edited] (FLINK-34355) Release Testing: Verify FLINK-34054 Support named parameters for functions and procedures

2024-02-04 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814193#comment-17814193 ] Shuai Xu edited comment on FLINK-34355 at 2/5/24 7:19 AM: -- Hi, I'd like to take

[jira] [Commented] (FLINK-34355) Release Testing: Verify FLINK-34054 Support named parameters for functions and procedures

2024-02-04 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814193#comment-17814193 ] Shuai Xu commented on FLINK-34355: -- Hi, I'd like to take this verification. > Release Testing: Ver

[jira] [Commented] (FLINK-34304) Release Testing Instructions: Verify FLINK-34219 Introduce a new join operator to support minibatch

2024-02-04 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814192#comment-17814192 ] Shuai Xu commented on FLINK-34304: -- This test is opened in another issue FLINK-34349 and this issue

[jira] (FLINK-34304) Release Testing Instructions: Verify FLINK-34219 Introduce a new join operator to support minibatch

2024-02-03 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34304 ] Shuai Xu deleted comment on FLINK-34304: -- was (Author: JIRAUSER300096): Minibatch join is ready. Users could improve performance in regular stream join scenarios.  Someone can verify

[jira] [Updated] (FLINK-34349) Release Testing: Verify FLINK-34219 Introduce a new join operator to support minibatch

2024-02-03 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-34349: - Description: Minibatch join is ready. Users could improve performance in regular stream join scenarios

[jira] [Created] (FLINK-34349) Release Testing: Verify FLINK-34219 Introduce a new join operator to support minibatch

2024-02-03 Thread Shuai Xu (Jira)
Shuai Xu created FLINK-34349: Summary: Release Testing: Verify FLINK-34219 Introduce a new join operator to support minibatch Key: FLINK-34349 URL: https://issues.apache.org/jira/browse/FLINK-34349

[jira] [Commented] (FLINK-34300) Release Testing Instructions: Verify FLINK-24024 Support session Window TVF

2024-02-03 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814016#comment-17814016 ] Shuai Xu commented on FLINK-34300: -- Hi, [~xuyangzhong]. I'd like to take this verification.  > Rele

[jira] [Commented] (FLINK-34304) Release Testing Instructions: Verify FLINK-34219 Introduce a new join operator to support minibatch

2024-02-03 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814015#comment-17814015 ] Shuai Xu commented on FLINK-34304: -- Minibatch join is ready. Users could improve performance in regular

[jira] [Updated] (FLINK-34222) Supports mini-batch for streaming regular join

2024-01-28 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-34222: - Summary: Supports mini-batch for streaming regular join (was: End to end implementation of minibatch

[jira] [Updated] (FLINK-34222) End to end implementation of minibatch join

2024-01-28 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-34222: - Description: Implement minibatch join in E2E which includes both plan and runtime parts. (was: Get

[jira] [Created] (FLINK-34256) Add a documentation section for minibatch join

2024-01-28 Thread Shuai Xu (Jira)
Shuai Xu created FLINK-34256: Summary: Add a documentation section for minibatch join Key: FLINK-34256 URL: https://issues.apache.org/jira/browse/FLINK-34256 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-34222) Get minibatch join operator involved

2024-01-25 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-34222: - Description: Get minibatch join operator involved in which includes both plan and operator. Implement

[jira] [Created] (FLINK-34222) Get minibatch join operator involved

2024-01-23 Thread Shuai Xu (Jira)
Shuai Xu created FLINK-34222: Summary: Get minibatch join operator involved Key: FLINK-34222 URL: https://issues.apache.org/jira/browse/FLINK-34222 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-34221) Introduce operator for minibatch join

2024-01-23 Thread Shuai Xu (Jira)
Shuai Xu created FLINK-34221: Summary: Introduce operator for minibatch join Key: FLINK-34221 URL: https://issues.apache.org/jira/browse/FLINK-34221 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-34220) introduce buffer bundle for minibatch join

2024-01-23 Thread Shuai Xu (Jira)
Shuai Xu created FLINK-34220: Summary: introduce buffer bundle for minibatch join Key: FLINK-34220 URL: https://issues.apache.org/jira/browse/FLINK-34220 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-34219) Introduce a new join operator to support minibatch

2024-01-23 Thread Shuai Xu (Jira)
Shuai Xu created FLINK-34219: Summary: Introduce a new join operator to support minibatch Key: FLINK-34219 URL: https://issues.apache.org/jira/browse/FLINK-34219 Project: Flink Issue Type: New

[jira] [Updated] (FLINK-33689) JsonObjectAggFunction can't retract previous data which is invalid when enabling local global agg

2023-11-28 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-33689: - Summary: JsonObjectAggFunction can't retract previous data which is invalid when enabling local global

[jira] [Updated] (FLINK-33689) JsonObjectAggFunction can't retract previous data which is invalid when enable local global agg

2023-11-28 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-33689: - Summary: JsonObjectAggFunction can't retract previous data which is invalid when enable local global

[jira] [Updated] (FLINK-33689) jsonObjectAggFunction can't retract previous data which is invalid when enable local global agg

2023-11-28 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-33689: - Description: Run the test as following and enable LocalGlobal and minibatch  in sql/AggregateITCase

[jira] [Updated] (FLINK-33689) jsonObjectAggFunction can't retract previous data which is invalid when enable local global agg

2023-11-28 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-33689: - Description: Run the test as following and enable LocalGlobal in sql/AggregateITCase .  {code:java} def

[jira] [Created] (FLINK-33689) jsonObjectAggFunction can't retract previous data which is invalid when enable local global agg

2023-11-28 Thread Shuai Xu (Jira)
Shuai Xu created FLINK-33689: Summary: jsonObjectAggFunction can't retract previous data which is invalid when enable local global agg Key: FLINK-33689 URL: https://issues.apache.org/jira/browse/FLINK-33689

[jira] [Comment Edited] (FLINK-33549) Exception "Factory does not implement interface YieldingOperatorFactory" thrown in batch mode

2023-11-22 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788967#comment-17788967 ] Shuai Xu edited comment on FLINK-33549 at 11/23/23 3:39 AM: Hi [~luoyuxia

[jira] [Commented] (FLINK-33549) Exception "Factory does not implement interface YieldingOperatorFactory" thrown in batch mode

2023-11-22 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788967#comment-17788967 ] Shuai Xu commented on FLINK-33549: -- I'd like to fix this. Could you assign it to me? [~luoyuxia

[jira] [Commented] (FLINK-28650) Flink SQL Parsing bug for METADATA

2023-10-16 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775580#comment-17775580 ] Shuai Xu commented on FLINK-28650: -- The bug in partial insert with writable metadata is fixed in FLINK

[jira] [Comment Edited] (FLINK-28650) Flink SQL Parsing bug for METADATA

2023-10-16 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775580#comment-17775580 ] Shuai Xu edited comment on FLINK-28650 at 10/16/23 7:58 AM: This bug

[jira] [Commented] (FLINK-28866) Use DDL instead of legacy method to register the test source in JoinITCase

2023-08-21 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757169#comment-17757169 ] Shuai Xu commented on FLINK-28866: -- Hi, I would like to fix this issue. Could it be assigned to me

[jira] [Comment Edited] (FLINK-27741) Fix NPE when use dense_rank() and rank() in over aggregation

2023-08-21 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756785#comment-17756785 ] Shuai Xu edited comment on FLINK-27741 at 8/21/23 9:58 AM: --- Hi [~chenzihao

[jira] [Commented] (FLINK-27741) Fix NPE when use dense_rank() and rank() in over aggregation

2023-08-21 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756785#comment-17756785 ] Shuai Xu commented on FLINK-27741: -- Hi, I would like to fix this issue. Could it be assigned to me

[jira] [Commented] (FLINK-25054) Improve exception message for unsupported hashLength for SHA2 function

2023-08-21 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756784#comment-17756784 ] Shuai Xu commented on FLINK-25054: -- Hi, I would like to fix this issue. Could it be assigned to me

[jira] [Commented] (FLINK-32824) Port Calcite's fix for the sql like operator

2023-08-09 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752618#comment-17752618 ] Shuai Xu commented on FLINK-32824: -- Hi, lincoln. I‘d like to fix this issue, could you assign it to me

[jira] [Updated] (FLINK-32219) SQL client hangs when executing EXECUTE PLAN

2023-05-30 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-32219: - Description: I compiled a plan for an INSERT statement and executed the plan, but the SQL client

[jira] [Updated] (FLINK-32219) SQL client hangs when executing EXECUTE PLAN

2023-05-30 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-32219: - Description: I compiled a plan for an insert statement and then executed the plan. However, the SQL

[jira] [Updated] (FLINK-32219) sql client would be pending after executing plan of inserting

2023-05-30 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-32219: - Affects Version/s: 1.17.1 > sql client would be pending after executing plan of insert

[jira] [Created] (FLINK-32219) sql client would be pending after executing plan of inserting

2023-05-30 Thread Shuai Xu (Jira)
Shuai Xu created FLINK-32219: Summary: sql client would be pending after executing plan of inserting Key: FLINK-32219 URL: https://issues.apache.org/jira/browse/FLINK-32219 Project: Flink Issue

[jira] [Commented] (FLINK-31956) Extend the CompiledPlan to read from/write to Flink's FileSystem

2023-04-27 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717082#comment-17717082 ] Shuai Xu commented on FLINK-31956: -- Hi Jane, I have taken the FLINK-31952 which is similar to the task

[jira] [Comment Edited] (FLINK-31952) Support 'EXPLAIN' statement for CompiledPlan

2023-04-27 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717031#comment-17717031 ] Shuai Xu edited comment on FLINK-31952 at 4/27/23 7:31 AM: --- Hi Jane, I have

[jira] [Commented] (FLINK-31952) Support 'EXPLAIN' statement for CompiledPlan

2023-04-27 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717031#comment-17717031 ] Shuai Xu commented on FLINK-31952: -- Hi Jane, I have some ideas for the task and this is how I consider

[GitHub] flink pull request #6360: [FLINK-9884] [runtime] fix slot request may not be...

2018-07-18 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/6360 [FLINK-9884] [runtime] fix slot request may not be removed when it has already be assigned in slot manager ## What is the purpose of the change *(The pull request fix the bug

[GitHub] flink issue #5931: [FLINK-9190][flip6,yarn] Request new container if contain...

2018-05-08 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/5931 @StephanEwen, Good idea, I prefer the first one. As for the second one, the pending request may have been fulfilled when task executor is killed. so job master can not cancel the pending request

[GitHub] flink issue #5931: [FLINK-9190][flip6,yarn] Request new container if contain...

2018-05-03 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/5931 @GJL In blink, we solve this problem like this. When a container complete, we will first whether the container has registered yet, if it has registered before, RM will not request a new

[GitHub] flink pull request #5951: [FLINK-9293] [runtime] SlotPool should check slot ...

2018-05-03 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/5951 [FLINK-9293] [runtime] SlotPool should check slot id when accepting a slot offer with existing allocation id ## What is the purpose of the change *This pull request fix that job

[GitHub] flink pull request #5693: [FLINK-8938] [runtime] not remove job graph during...

2018-03-13 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/5693 [FLINK-8938] [runtime] not remove job graph during job master failover ## What is the purpose of the change *This pull request fix a bug that when job master failover, it may delete

[GitHub] flink pull request #5190: [FLINK-8289] [runtime] set the rest.address to the...

2018-01-15 Thread shuai-xu
Github user shuai-xu closed the pull request at: https://github.com/apache/flink/pull/5190 ---

[GitHub] flink issue #5190: [FLINK-8289] [runtime] set the rest.address to the host o...

2018-01-15 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/5190 @tillrohrmann , In fact, the original problem I'm concerned with has been fix by your commit "[FLINK-8119] [flip6] Wire correct Flip6 components in Flip6YarnClusterDescriptor",

[GitHub] flink pull request #5297: [FLINK-8434] Take over the running task manager af...

2018-01-15 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/5297 [FLINK-8434] Take over the running task manager after yarn app master failvoer ## What is the purpose of the change *This pull request makes the yarn resource manager could take over

[GitHub] flink pull request #2675: [FLINK-4504][dataset api]Support user to decide wh...

2018-01-15 Thread shuai-xu
Github user shuai-xu closed the pull request at: https://github.com/apache/flink/pull/2675 ---

[GitHub] flink pull request #2674: [FLINK-4444][runtime]Add a InputChannel and Result...

2018-01-15 Thread shuai-xu
Github user shuai-xu closed the pull request at: https://github.com/apache/flink/pull/2674 ---

[GitHub] flink issue #5271: [FLINK-8399] [runtime] use independent configurations for...

2018-01-14 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/5271 @tillrohrmann thank you for reviewing, I have modified it. ---

[GitHub] flink issue #5190: [FLINK-8289] [runtime] set the rest.address to the host o...

2018-01-14 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/5190 @tillrohrmann @EronWright , this make it more clear, but seems not solve the problem completely. Since we need to set RestOptions#ADDRESS to the address of a rest server so the client can access

[GitHub] flink issue #5170: [FLINK-8266] [runtime] add network memory to ResourceProf...

2018-01-14 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/5170 @tillrohrmann sorry, the conflict is resolved now ---

[GitHub] flink issue #5186: [FLINK-8288] [runtime] register job master rest endpoint ...

2018-01-10 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/5186 @NicoK , thank you for reviewing, I have adjusted the indent. ---

[GitHub] flink pull request #5271: [FLINK-8399] [runtime] use independent configurati...

2018-01-09 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/5271 [FLINK-8399] [runtime] use independent configurations for the different timeouts in slot manager ## What is the purpose of the change *This pull request separate the timeouts

[GitHub] flink pull request #5190: [FLINK-8289] [runtime] set the rest.address to the...

2017-12-24 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/5190#discussion_r158627004 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java --- @@ -155,6 +156,7 @@ protected void runCluster

[GitHub] flink pull request #5190: [FLINK-8289] [runtime] set the rest.address to the...

2017-12-20 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/5190 [FLINK-8289] [runtime] set the rest.address to the host of the rest server machine ## What is the purpose of the change This pull request set the rest.address to the host

[GitHub] flink pull request #5186: [FLINK-8288] [runtime] register job master rest en...

2017-12-19 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/5186 [FLINK-8288] [runtime] register job master rest endpoint url to yarn ## What is the purpose of the change This pull request pass the endpoint url of job master rest server

[GitHub] flink pull request #5170: [FLINK-8266] [runtime] add network memory to Resou...

2017-12-15 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/5170 [FLINK-8266] [runtime] add network memory to ResourceProfile for the input and output memory of a task ## What is the purpose of the change This pull request adds a network memory

[GitHub] flink pull request #4991: [FLINK-7928] [runtime] extend the resources in Res...

2017-12-13 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/4991#discussion_r156848154 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java --- @@ -52,6 +63,15 @@ /** How many

[GitHub] flink pull request #5139: [FLINK-8224] [runtime] shutdown application when j...

2017-12-08 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/5139 [FLINK-8224] [runtime] shutdown application when job terminated in job mode ## What is the purpose of the change This current job cluster entrypoint doesn't call resource manage

[GitHub] flink pull request #4991: [FLINK-7928] [runtime] extend the resources in Res...

2017-12-07 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/4991#discussion_r155708446 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java --- @@ -61,16 +80,26 @@ * @param

[GitHub] flink issue #4911: [FLINK-7878] [api] make resource type extendible in Resou...

2017-12-07 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/4911 @tillrohrmann , I agree with you that adding a build looks better, I changed it according to your comments. Do you think it works now? ---

[GitHub] flink issue #4988: [FLINK-8030] Instantiate JobMasterRestEndpoint in JobClus...

2017-11-30 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/4988 This pr is very helpful for us. Thank you. I have tried it on our cluster with yarn job mode,and it works well. My only suggestion is to change the default value of rest.address to 0.0.0.0

[GitHub] flink pull request #4985: [FLINK-8027] Generalize existing rest handlers to ...

2017-11-28 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/4985#discussion_r153708910 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TestingTaskExecutorGateway.java --- @@ -0,0 +1,124 @@ +/* + * Licensed

[GitHub] flink pull request #4991: [FLINK-7928] [runtime] extend the resources in Res...

2017-11-09 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/4991 [FLINK-7928] [runtime] extend the resources in ResourceProfile for precisely calculating the resource of task manager Notes: this pull request contains the #4911 since it depends

[GitHub] flink issue #4911: [FLINK-7878] [api] make resource type extendible in Resou...

2017-11-08 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/4911 @tillrohrmann, I make the Resource abstract and add GPUResource and FPGAResource, so user can only add such defined resources, how about it? ---

[GitHub] flink pull request #4911: [FLINK-7878] [api] make resource type extendible i...

2017-11-08 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/4911#discussion_r149610252 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java --- @@ -61,18 +79,17 @@ /** How many state size in mb

[GitHub] flink issue #4911: [FLINK-7878] [api] make resource type extendible in Resou...

2017-11-07 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/4911 @tillrohrmann, There is not a generic way for both Yarn and Mesos, as their resource allocation interface are different. I think the YARN/MESOS resource manager should handle it in their own way

[GitHub] flink issue #4911: [FLINK-7878] [api] make resource type extendible in Resou...

2017-11-06 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/4911 @tillrohrmann, Yes, the Resource is a little too generic and prone to typos. However, the resource are various and closely related to the platform(YARN/MESOS), only a GPUResource and FPGAResource

[GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...

2017-11-03 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/4937#discussion_r148718854 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java --- @@ -262,23 +263,36 @@ public void disconnectResourceManager

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-11-03 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/4887#discussion_r148716173 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java --- @@ -874,6 +894,13 @@ public void handleError(final

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-11-03 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/4887#discussion_r148715689 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceActions.java --- @@ -52,4 +52,6 @@ * @param

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-11-03 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/4887#discussion_r148715651 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -302,7 +302,12 @@ public boolean

[GitHub] flink pull request #4937: [FLINK-6434] [runtime] cancel slot allocation if r...

2017-11-01 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/4937 [FLINK-6434] [runtime] cancel slot allocation if request timed out in ProviderAndOwner ## What is the purpose of the change This pr adds a cancel slot allocation protocol between

[GitHub] flink pull request #3398: [FLINK-5856] [FLIP-6] return redundant containers ...

2017-11-01 Thread shuai-xu
Github user shuai-xu closed the pull request at: https://github.com/apache/flink/pull/3398 ---

[GitHub] flink issue #4911: [FLINK-7878] [api] make resource type extendible in Resou...

2017-10-27 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/4911 I run the failed test on my machine and it pass, and it seems my changes will not influence it. ---

[GitHub] flink pull request #4911: [FLINK-7878] [api] make resource type extendible i...

2017-10-27 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/4911 [FLINK-7878] [api] make resource type extendible in ResourceSpec Summary: Now, flink only support user define CPU and MEM, but some user need to specify the GPU, FPGA and so on resources

[GitHub] flink issue #4887: [FLINK-7870] [runtime] Cancel slot allocation to RM when ...

2017-10-24 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/4887 @tillrohrmann could you help to review this pr? Thank you. ---

[GitHub] flink pull request #4887: [FLINK-7870] [runtime] Cancel slot allocation to R...

2017-10-23 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/4887 [FLINK-7870] [runtime] Cancel slot allocation to RM when requestSlot timed out in SlotPool ## What is the purpose of the change This pull request add a cancelSlotRequest rpc protocol

[GitHub] flink issue #3580: [FLINK-5791] Support an optimal matching based slot manag...

2017-08-08 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/3580 @tillrohrmann Could you please help to review this pr? And there is a question, the pending requests in slot managers are not in order. So requests arrived later may be fulfilled earlier, does

[GitHub] flink issue #3398: [FLINK-5856] [FLIP-6] return redundant containers to yarn...

2017-07-06 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/3398 @tillrohrmann , sorry to reply late. I will modify it according to your comments in one week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request #3539: Flip1: fine gained recovery

2017-07-03 Thread shuai-xu
Github user shuai-xu closed the pull request at: https://github.com/apache/flink/pull/3539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #3755: [FLINK-6351] [YARN] Refactoring YarnFlinkApplicationMaste...

2017-05-11 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/3755 There will soon be a YarnFlinkAppMaster extends AbstractYarnFlinkApplicationMasterRunner for flink yarn cluster mode, so need not combine them to one class. --- If your project is set up

[GitHub] flink pull request #3773: [FLINK-5867] [FLINK-5866] [flip-1] Implement Failo...

2017-04-25 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/3773#discussion_r113361061 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/FailoverRegion.java --- @@ -0,0 +1,251 @@ +/* + * Licensed

[GitHub] flink pull request #3580: [FLINK-5791] Support an optimal matching based slo...

2017-03-20 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/3580 [FLINK-5791] Support an optimal matching based slot manager for flip6 yarn mode This pr is for jira-#[5791](https://issues.apache.org/jira/browse/FLINK-5791) Main changes: 1. Add

[GitHub] flink pull request #3304: [FLINK-5791] [runtime] [FLIP-6] Slots should be st...

2017-03-15 Thread shuai-xu
Github user shuai-xu closed the pull request at: https://github.com/apache/flink/pull/3304 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

  1   2   >