Github user skonto commented on the issue:
https://github.com/apache/flink/pull/3659
@p4nna although there is certainly interoperability between scala and java
could you try first add the Imputer in the scala API.
I will add some comments to the current implementation in java
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/3313
WIP I will add the unit scaler here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/3313
Ok sorry for that I did squash the commits, also I am used to it from other
projects where the comments are invalidated.
---
If your project is set up for it, you can reply to this email and have
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/3313
@tillrohrmann the tests never finished :( Is there a way to re-trigger it
besides a commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/3313
@thvasilo @tillrohrmann pls review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user skonto opened a pull request:
https://github.com/apache/flink/pull/3313
[FLINK-5588][ml] add a data normalizer to ml library
- Adds a Normalizer.
- Still need to add the Unit Scaler for the features.
You can merge this pull request into a Git repository by running
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/3192
@sachingoel0101 np as soon as you are ready let me know. Also @tillrohrmann
made some comments to take into consideration.
---
If your project is set up for it, you can reply to this email and have
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/3192
@sachingoel0101 could you update the PR so I can do a final review and
request a merge?
@tillrohrmann could assist with the forwardedfields question?
---
If your project is set up for it, you
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/3192
I have run the tests and verified the code, seems to work fine. I need to
check the centers generated.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/3192#discussion_r98650525
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala
---
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/3192#discussion_r98570744
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala
---
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/3192#discussion_r98557895
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/clustering/ClusteringData.scala
---
@@ -0,0 +1,277 @@
+/*
+ * Licensed
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/3192
Correct, just saying we will need to create a set of examples for the ml
library.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/3192#discussion_r98511916
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala
---
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/3192
Ok ... there is one
[example](https://github.com/apache/flink/blob/master/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/ml/LinearRegression.scala).
---
If your
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/3192
@sachingoel0101 please add an example at least under flink examples.
Is the code documentation enough? @thvasilo ?
---
If your project is set up for it, you can reply to this email and have your
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/3192
@sachingoel0101 I am having a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/3192#discussion_r98454850
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala
---
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/3192#discussion_r98456054
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala
---
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/3192#discussion_r98454397
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/package.scala ---
@@ -18,13 +18,16 @@
package org.apache.flink
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/3192#discussion_r98453679
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/clustering/ClusteringData.scala
---
@@ -0,0 +1,277 @@
+/*
+ * Licensed
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/1849
Hi guys, my intention was to review #2838 but my feeling is that it
overlaps with this one. @thvasilo we can push this one first as you said so I
will have a look at it and comment on it. The benefit
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/1849
@thvasilo thnx I will have a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/1849#discussion_r96403197
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/evaluation/Score.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/1849
Hey @thvasilo is this under development? From what I see many other tasks
depend on it right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/757
@sachingoel0101 no problem been there ;) That would be good thnx!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/757
@sachingoel0101 @tillrohrmann ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/757
@sachingoel0101 @tillrohrmann any plans for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/757#discussion_r81433030
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala
---
@@ -0,0 +1,614 @@
+/*
+ * Licensed to the Apache
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/757#discussion_r81432816
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala
---
@@ -0,0 +1,614 @@
+/*
+ * Licensed to the Apache
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/757#discussion_r81430771
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/clustering/KMeansITSuite.scala
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/757#discussion_r81430683
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/clustering/KMeansITSuite.scala
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/757#discussion_r81430196
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala
---
@@ -0,0 +1,614 @@
+/*
+ * Licensed to the Apache
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/757#discussion_r81430070
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala
---
@@ -0,0 +1,614 @@
+/*
+ * Licensed to the Apache
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/757#discussion_r81429867
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala
---
@@ -0,0 +1,614 @@
+/*
+ * Licensed to the Apache
Github user skonto commented on the issue:
https://github.com/apache/flink/pull/757
any progress with this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/757#discussion_r81429258
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala
---
@@ -0,0 +1,614 @@
+/*
+ * Licensed to the Apache
Github user skonto commented on a diff in the pull request:
https://github.com/apache/flink/pull/757#discussion_r81429036
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala
---
@@ -0,0 +1,614 @@
+/*
+ * Licensed to the Apache
38 matches
Mail list logo
