[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

2017-04-25 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3760 @ramkrish86 Hi, Thank you for the PR. Could you repush commit? ``` git commit --amend gut push origin FLINK-5752 -f ``` --- If your project is set up for it, you can reply

[GitHub] flink issue #3127: [FLINK-5481] Simplify Row creation

2017-03-23 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 @StephanEwen I fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3269: [FLINK-5698] Add NestedFieldsProjectableTableSource trait

2017-03-23 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3269 @fhueske What dou you think about this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #3127: [FLINK-5481] Simplify Row creation

2017-03-20 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3127#discussion_r106862331 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/Types.scala --- @@ -17,29 +17,51 @@ */ package

[GitHub] flink pull request #3127: [FLINK-5481] Simplify Row creation

2017-03-17 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3127#discussion_r106668425 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/Types.scala --- @@ -17,29 +17,51 @@ */ package

[GitHub] flink pull request #3127: [FLINK-5481] Simplify Row creation

2017-03-17 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3127#discussion_r106647040 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/Types.scala --- @@ -17,29 +17,51 @@ */ package

[GitHub] flink pull request #3166: [FLINK-3849] Add FilterableTableSource interface a...

2017-03-17 Thread tonycox
Github user tonycox closed the pull request at: https://github.com/apache/flink/pull/3166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #3127: [FLINK-5481] Simplify Row creation

2017-03-15 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 Hi @StephanEwen I added javadoc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3269: [FLINK-5698] Add NestedFieldsProjectableTableSource trait

2017-03-15 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3269 Hi @fhueske I've addressed all comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #3269: [FLINK-5698] Add NestedFieldsProjectableTableSourc...

2017-03-15 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3269#discussion_r106208275 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/util/RexProgramProjectExtractor.scala --- @@ -84,6 +108,49 @@ object

[GitHub] flink pull request #3297: [FLINK-5431] Add configurable timePattern for clie...

2017-03-15 Thread tonycox
Github user tonycox closed the pull request at: https://github.com/apache/flink/pull/3297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #3127: [FLINK-5481] Simplify Row creation

2017-03-14 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3127#discussion_r105972293 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/Types.java --- @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #3127: [FLINK-5481] Simplify Row creation

2017-03-14 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3127#discussion_r105972317 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/Types.scala --- @@ -17,29 +17,34 @@ */ package

[GitHub] flink issue #3040: [FLINK-3850] Add forward field annotations to DataSet

2017-03-13 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3040 @fhueske I fixed commented points. Could you explain the join keys forwarding? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-13 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r105600606 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/forwarding/FieldForwardingUtils.scala --- @@ -0,0 +1,143

[GitHub] flink issue #3166: [FLINK-3849] Add FilterableTableSource interface and Rule...

2017-03-09 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3166 Hi @fhueske I cant continue on this PR, have not enough time for now. If you need implementation of it immediately I will unassign --- If your project is set up for it, you can reply to this email

[GitHub] flink issue #3297: [FLINK-5431] Add configurable timePattern for client akka...

2017-03-06 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3297 @zentol What do you think about this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3040: [FLINK-3850] Add forward field annotations to DataSet

2017-03-06 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3040 @fhueske @KurtYoung @twalthr What do you think about this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #3127: [FLINK-5481] Simplify Row creation

2017-03-06 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 @StephanEwen @twalthr What do you think about this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3166: [FLINK-3849] Add FilterableTableSource interface and Rule...

2017-02-21 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3166 @fhueske could you look at this approach of transfering `RexNode` to `Expression`, it's stil in wip state, but I need your adjustment --- If your project is set up for it, you can reply

[GitHub] flink issue #3040: [FLINK-3850] Add forward field annotations to DataSet

2017-02-15 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3040 Hi, Do we need field forwarding in `DataSetMinus`, `DataSetIntersect` and `DataSetSort`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink issue #3166: [FLINK-3849] Add FilterableTableSource interface and Rule...

2017-02-14 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3166 Hi @fhueske, what do you think about this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-02-13 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @ramkrish86 java8 has different memory model, https://dzone.com/articles/java-8-permgen-metaspace --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader and sc...

2017-02-13 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3012 @ex00 default value of any empty field is null --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-02-13 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @ramkrish86 You can use jhat to read hprof dump file. If set `-XX:MaxPermSize=128m` ```xml org.apache.maven.plugins maven-surefire-plugin 2.19.1

[GitHub] flink pull request #3297: [FLINK-5431] Add configurable timePattern for clie...

2017-02-12 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3297 [FLINK-5431] Add configurable timePattern for client akka status Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink issue #3271: FLINK-5710

2017-02-10 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3271 Hi @huawei-flink, please name your PR with "[FLINK-XXX] Jira title text" pattern --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-02-10 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 I think I should rename this issuea to "Simplify Row creation". What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-02-10 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @ramkrish86 Try to add ``` -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath="/tmp" ``` as parameter of JVM --- If your project is set up for it, you can reply to

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-02-09 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @ramkrish86 what is your environment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader and sc...

2017-02-09 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3012 @ex00 Thank you for review, If typeMap does not match with fields type in file it will fall with `ParseException`. But if `Double parser` try to parse an integer it will be okay. Do

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2017-02-09 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3012#discussion_r10033 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/ExecutionEnvironment.scala --- @@ -348,6 +349,47 @@ class ExecutionEnvironment(javaEnv

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2017-02-09 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3012#discussion_r100337562 --- Diff: flink-tests/src/test/java/org/apache/flink/test/io/CsvReaderITCase.java --- @@ -122,6 +127,80 @@ public void testValueTypes() throws Exception

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-02-09 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 Try to run in flink folder (I ran it onto ubuntu 16.04) ```bash export JAVA_HOME=/path/to/java-7-oracle/jre mvn -B -Dhadoop.version=2.3.0 \ test -Dtest

[GitHub] flink issue #3269: [FLINK-5698] Add NestedFieldsProjectableTableSource trait

2017-02-09 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3269 Hi @wuchong Thank you for excellent advice --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #3205: [FLINK-5635] Improve Docker tooling to make it eas...

2017-02-08 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3205#discussion_r100159827 --- Diff: flink-contrib/docker-flink/docker-compose.yml --- @@ -16,21 +16,22 @@ # limitations under the License

[GitHub] flink pull request #3205: [FLINK-5635] Improve Docker tooling to make it eas...

2017-02-08 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3205#discussion_r100156082 --- Diff: flink-contrib/docker-flink/Dockerfile --- @@ -36,22 +31,25 @@ ENV PATH $PATH:$FLINK_HOME/bin EXPOSE 8081 EXPOSE 6123 +# flink

[GitHub] flink pull request #3205: [FLINK-5635] Improve Docker tooling to make it eas...

2017-02-08 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3205#discussion_r100148697 --- Diff: flink-contrib/docker-flink/Dockerfile --- @@ -36,22 +31,25 @@ ENV PATH $PATH:$FLINK_HOME/bin EXPOSE 8081 EXPOSE 6123 +# flink

[GitHub] flink pull request #3269: [FLINK-5698] Add NestedFieldsProjectableTableSourc...

2017-02-06 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3269 [FLINK-5698] Add NestedFieldsProjectableTableSource trait - add extraction of RexFieldAccess method - complete PushProjectIntoBatchTableSourceScanRule with new interface Thanks

[GitHub] flink issue #308: [FLINK-1398] Introduce extractSingleField() in DataSet

2017-02-06 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/308 Okay, I'll add it to clean up jira list --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #308: [FLINK-1398] Introduce extractSingleField() in DataSet

2017-02-06 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/308 Hi @FelixNeutatz Can you finish this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3166: [FLINK-3849] Add FilterableTableSource interface and Rule...

2017-02-03 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3166 However I think we need a tool for converting RexNodes to Table API Expressions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-02-02 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 ```scala import Types._ ROW(Array("person", "additional"), ROW(Array("name", "age"), STRING, STRING), ROW(Array(&

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-02-01 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @ramkrish86 ProjectableTableSource works in scan process. Without it TableScan is scanning all collumns and applying flatMap function on the whole data to project and filter. It's inefficient

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-02-01 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @fhueske I preffer a better API with nesting. We can extend `ProjectableTableSource` with a method like this ```scala def projectNestedFields(fields: Array[String]): ProjectableTableSource[T

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-31 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 @twalthr I think it's good way. Should I move `TimeIntervalTypeInfo` to core as well or not? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-30 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r98455947 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java --- @@ -0,0 +1,140 @@ +/* + * Licensed

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-30 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r98435113 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java --- @@ -0,0 +1,140 @@ +/* + * Licensed

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-30 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r98434792 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java --- @@ -0,0 +1,140 @@ +/* + * Licensed

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-30 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @ramkrish86 sorry for confusing, don't pay attention to new generating maps. I think `PushProjectIntoBatchTableSourceScanRule` is not good enough for nested data types. but we can project

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-30 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 I suggest add a little bit more sugar ```java TypeInformation infoNew = RowTypeInfo.from( new String[]{"1c", "2c"}, RowTypeInfo.from( new S

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-28 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 `HBaseTableSchema` is initial information of table columns, so we can add more maps that generate after familyMap has set ```java Map<String, List<Pair<String, TypeInformation>

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-27 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 I think all it's just a syntax sugar ```scala val data = List( Row.of(Row.of("data_1", "dob"), Row.of("info_4", "dub")),

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-26 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @ramkrish86 I think you need implement projectable interface in HBase source --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-26 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 @StephanEwen I agree with types conflicting and that it's not common type for collection. So how should generating a row type info look like? --- If your project is set up for it, you can reply

[GitHub] flink issue #3040: [FLINK-3850] Add forward field annotations to DataSet

2017-01-26 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3040 Hi, Nickolay cannot continue work on this PR, so I'm going to try finish it for him. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-25 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r97898531 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java --- @@ -0,0 +1,137 @@ +/* + * Licensed

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-25 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r97903962 --- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseTableSourceITCase.java --- @@ -0,0 +1,248

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-25 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r97897602 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java --- @@ -0,0 +1,137 @@ +/* + * Licensed

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-25 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r97903708 --- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseTableSourceITCase.java --- @@ -0,0 +1,248

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-25 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r97901774 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSource.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-25 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r97904966 --- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseTableSourceITCase.java --- @@ -0,0 +1,248

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-25 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r97900030 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java --- @@ -0,0 +1,137 @@ +/* + * Licensed

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-20 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r97074517 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSource.java --- @@ -0,0 +1,75 @@ +/* + * Licensed

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-20 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r97067569 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSource.java --- @@ -0,0 +1,75 @@ +/* + * Licensed

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 As Jark Wu said in [jira](https://issues.apache.org/jira/browse/FLINK-5554) > I think the HBaseTableSource should return a composite type (with column family and qualifier), and we can

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r96802576 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSourceInputFormat.java --- @@ -0,0 +1,322

[GitHub] flink pull request #3166: [FLINK-3849] [WIP] Add FilterableTableSource inter...

2017-01-18 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3166 [FLINK-3849] [WIP] Add FilterableTableSource interface and Rules for pushing it Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r9157 --- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseTableSourceITCase.java --- @@ -0,0 +1,117

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 We need discuss that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r96668950 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSourceInputFormat.java --- @@ -0,0 +1,322

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r96665731 --- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseTableSourceITCase.java --- @@ -0,0 +1,117

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r96665689 --- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseTableSourceITCase.java --- @@ -0,0 +1,117

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3149#discussion_r96665755 --- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseTableSourceITCase.java --- @@ -0,0 +1,117

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 And could you extend with `StreamTableSource` also ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 I think it can be solved in different issue to provide a new api in `table.api` for selecting from HBase --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @ramkrish86 @fhueske what do you think about to throw `Tuple` (`T extends Tuple`) out of `org.apache.flink.addons.hbase.TableInputFormat` and implement this abstract class in your

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 You need to recompile `TableSource` trait manually and implement `DefinedFieldNames` in `HBaseTableSource` --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-17 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 @zentol I rewrite as you pointed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #243: [FLINK-1293] Add support for out-of-place aggregations

2017-01-16 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/243 Ok, cool. I can go through abandoned PRs and add them to https://issues.apache.org/jira/browse/FLINK-5384. Wouldn't you mind @fhueske ? --- If your project is set up for it, you can reply

[GitHub] flink issue #243: [FLINK-1293] Add support for out-of-place aggregations

2017-01-16 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/243 Is this PR still alive? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #3127: [FLINK-5481] Add type extraction from collection

2017-01-16 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3127 [FLINK-5481] Add type extraction from collection Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink pull request #3018: [FLINK-5336] Remove IOReadableWritable interface f...

2017-01-08 Thread tonycox
Github user tonycox closed the pull request at: https://github.com/apache/flink/pull/3018 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #3044: [FLINK-5388] Change private Graph.() to prot...

2016-12-26 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3044 [FLINK-5388] Change private Graph.() to protected Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink pull request #3027: [FLINK-5358] add RowTypeInfo exctraction in TypeEx...

2016-12-25 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3027#discussion_r93848593 --- Diff: flink-core/src/test/java/org/apache/flink/api/java/typeutils/TypeExtractorTest.java --- @@ -345,8 +346,25 @@ public CustomType cross(CustomType

[GitHub] flink issue #3027: [FLINK-5358] add RowTypeInfo exctraction in TypeExtractor

2016-12-22 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3027 Hi @fhueske could you look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader and sc...

2016-12-20 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3012 Hi @StephanEwen could you look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #3027: [FLINK-5358] add RowTypeInfo exctraction in TypeEx...

2016-12-19 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3027 [FLINK-5358] add RowTypeInfo exctraction in TypeExtractor Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink issue #3020: [FLINK-5348] [core] Support custom field names for RowTyp...

2016-12-16 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3020 @wuchong sorry, my fault, didn't spot duplicate field names checkers. What about cases, Is flink-table case-sensitive? --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #3020: [FLINK-5348] [core] Support custom field names for RowTyp...

2016-12-16 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3020 Hi @wuchong , in this case I think you should adapt `getFieldIndex` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #3018: [FLINK-5336] Remove IOReadableWritable interface f...

2016-12-16 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3018 [FLINK-5336] Remove IOReadableWritable interface from Path Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-12-15 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 @fhueske I update this PR according to last changes in master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2016-12-15 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3012 [FLINK-2186] Add readCsvAsRow methods to CsvReader and scala ExecutionEnv Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink issue #2926: [FLINK-5226] [table] Use correct DataSetCostFactory and i...

2016-12-14 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2926 @fhueske is there any sense to createcost optimization for Stream? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #3003: [FLINK-5188] Create analog of RowCsvInputFormat in java a...

2016-12-14 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3003 Hi @fhueske okay, as you wish --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #3004: [Flink-5189] Delete Row and its related classes fr...

2016-12-14 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3004 [Flink-5189] Delete Row and its related classes from table api Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink pull request #3003: [Flink-5188] Create analog of RowCsvInputFormat in...

2016-12-13 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3003 [Flink-5188] Create analog of RowCsvInputFormat in java and adjust all the imports of Row and RowTypeInfo Thanks for contributing to Apache Flink. Before you open your pull request, please take

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-12-13 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 Hi @fhueske , what should I finish first, this PR or FLINK-5188 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #2968: [FLINK-5187] [core] Create analog of Row and RowTypeInfo ...

2016-12-12 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2968 @fhueske Yes. I already started https://github.com/tonycox/flink/tree/FLINK-5188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-12 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91941722 --- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF

  1   2   >