[GitHub] flink issue #6031: [FLINK-9386] Embed netty router

2018-05-23 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/6031 > I planned to upgrade netty and drop netty-router in one step of upgrading flink-shaded-netty. Do you think it should be split somehow? No, if the ticket for upgrading covers that, we are all g

[GitHub] flink pull request #6031: [FLINK-9386] Embed netty router

2018-05-23 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/6031#discussion_r190274800 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/MethodlessRouter.java --- @@ -0,0 +1,121 @@ +/* + * Licensed

[GitHub] flink pull request #6031: [FLINK-9386] Embed netty router

2018-05-23 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/6031#discussion_r190274982 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/RouterHandler.java --- @@ -0,0 +1,109 @@ +/* + * Licensed

[GitHub] flink pull request #6031: [FLINK-9386] Embed netty router

2018-05-23 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/6031#discussion_r190214988 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/RouterHandler.java --- @@ -0,0 +1,109 @@ +/* + * Licensed

[GitHub] flink pull request #6031: [FLINK-9386] Embed netty router

2018-05-23 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/6031#discussion_r190248429 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/RouteResult.java --- @@ -0,0 +1,136 @@ +/* + * Licensed

[GitHub] flink pull request #6031: [FLINK-9386] Embed netty router

2018-05-23 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/6031#discussion_r190244366 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/MethodlessRouter.java --- @@ -0,0 +1,121 @@ +/* + * Licensed

[GitHub] flink pull request #6031: [FLINK-9386] Embed netty router

2018-05-23 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/6031#discussion_r190191066 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/RouterHandler.java --- @@ -0,0 +1,109 @@ +/* + * Licensed

[GitHub] flink pull request #6031: [FLINK-9386] Embed netty router

2018-05-23 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/6031#discussion_r190246117 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java --- @@ -89,19 +91,20 @@ public RuntimeMonitorHandler

[GitHub] flink pull request #6031: [FLINK-9386] Embed netty router

2018-05-23 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/6031#discussion_r190248637 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/Router.java --- @@ -0,0 +1,398 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6031: [FLINK-9386] Embed netty router

2018-05-23 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/6031#discussion_r190213387 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/MethodlessRouter.java --- @@ -0,0 +1,121 @@ +/* + * Licensed

[GitHub] flink pull request #6031: [FLINK-9386] Embed netty router

2018-05-23 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/6031#discussion_r190248244 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/PathPattern.java --- @@ -0,0 +1,179 @@ +/* + * Licensed

[GitHub] flink pull request #6031: [FLINK-9386] Embed netty router

2018-05-23 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/6031#discussion_r190186599 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/RouterHandler.java --- @@ -0,0 +1,109 @@ +/* + * Licensed

[GitHub] flink pull request #6031: [FLINK-9386] Embed netty router

2018-05-23 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/6031#discussion_r190197601 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/MethodlessRouter.java --- @@ -0,0 +1,121 @@ +/* + * Licensed

[GitHub] flink pull request #:

2018-03-27 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/commit/3a61ea47922280e15f462ca3cdc0c367047bde24#commitcomment-28293221 @twalthr I think this broke the build. At least locally, I get a RAT license failure. ``` 1 Unknown Licenses

[GitHub] flink issue #5395: [FLINK-8308] Remove explicit yajl-ruby dependency, update...

2018-02-09 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/5395 Didn't merge yet, because there is an issue with the buildbot environment. ---

[GitHub] flink issue #5395: [FLINK-8308] Remove explicit yajl-ruby dependency, update...

2018-02-06 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/5395 I've built this locally and everything looks good to me (linebreaks and code highlighting). I will merge this to `master`, but keep this PR open for a while. If everything works

[GitHub] flink pull request #4809: [FLINK-7803][Documentation] Add missing savepoint ...

2018-02-05 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/4809#discussion_r166008336 --- Diff: docs/ops/state/savepoints.md --- @@ -120,6 +120,10 @@ This will atomically trigger a savepoint for the job with ID `:jobid` and cancel

[GitHub] flink issue #5395: [FLINK-8308] Remove explicit yajl-ruby dependency, update...

2018-02-02 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/5395 https://issues.apache.org/jira/browse/INFRA-15959 `ruby2.3.1` has been installed on the buildbot. I will check whether the build works as expected and report back here (probably only by next

[GitHub] flink pull request #5395: [FLINK-8308] Remove explicit yajl-ruby dependency,...

2018-02-01 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/5395#discussion_r165295535 --- Diff: docs/_config.yml --- @@ -77,12 +77,7 @@ defaults: layout: plain nav-pos: 9 # Move to end if no pos specified

[GitHub] flink issue #5395: [FLINK-8308] Remove explicit yajl-ruby dependency, update...

2018-01-31 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/5395 https://ci.apache.org/builders/flink-docs-master/builds/977/steps/Flink%20docs/logs/stdio says ``` Ruby version: ruby 2.0.0p384 (2014-01-12) [x86_64-linux-gnu] ``` I can ask

[GitHub] flink issue #5331: [FLINK-8473][webUI] Improve error behavior of JarListHand...

2018-01-23 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/5331 I just tried it, re-uploading after deleting the directory **does not work**. Good catch Stephan. :-) @zentol: I found `HttpRequestHandler` which handles the uploads. The handler assumes

[GitHub] flink issue #5331: [FLINK-8473][webUI] Improve error behavior of JarListHand...

2018-01-22 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/5331 👍 to merge. ---

[GitHub] flink pull request #5331: [FLINK-8473][webUI] Improve error behavior of JarL...

2018-01-22 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/5331#discussion_r162935682 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarListHandler.java --- @@ -77,6 +82,11 @@ public boolean accept(File

[GitHub] flink pull request #5331: [FLINK-8473][webUI] Improve error behavior of JarL...

2018-01-22 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/5331#discussion_r162932050 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarListHandler.java --- @@ -145,6 +155,7 @@ public boolean accept(File

[GitHub] flink issue #5264: [FLINK-8352][web-dashboard] Flink UI Reports No Error on ...

2018-01-09 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/5264 Build failure is unrelated (YARN test). Merging this. Thanks! ---

[GitHub] flink issue #5264: [FLINK-8352][web-dashboard] Flink UI Reports No Error on ...

2018-01-08 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/5264 Looks good to me. I've tried this out locally for both a working and not working (see screenshot) JAR. ![screen shot 2018-01-08 at 18 05 58](https://user-images.githubusercontent.com/1756620

[GitHub] flink issue #5263: [FLINK-7991][docs] Fix baseUrl for master branch

2018-01-08 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/5263 Looks good to me. Good catch! +1 to merge 👍 ---

[GitHub] flink pull request #:

2017-12-10 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/commit/8086e3bee8be4614359041c14786140edff19666#commitcomment-26179876 I know that the project historically did not consider the REST API as a public API, but I would vote to note down all

[GitHub] flink issue #5102: [FLINK-7762, FLINK-8167] Clean up and harden WikipediaEdi...

2017-11-29 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/5102 I would be in favour of removing this or moving it to Bahir, but it is currently used in a [doc example](https://ci.apache.org/projects/flink/flink-docs-release-1.4/quickstart

[GitHub] flink pull request #5102: [FLINK-7762, FLINK-8167] Clean up and harden Wikip...

2017-11-29 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/5102 [FLINK-7762, FLINK-8167] Clean up and harden WikipediaEditsSource ## What is the purpose of the change This pull requests addresses two related issues with the WikipediaEditsSource. It makes

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r151946320 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -0,0 +1,364 @@ +/* + * Licensed

[GitHub] flink issue #3442: [FLINK-5778] [savepoints] Add savepoint serializer with r...

2017-10-24 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3442 I had a quick chat with Stephan about this. @StefanRRichter has an idea how to properly implement this. Closing this PR and unassigning the issue. ---

[GitHub] flink pull request #3442: [FLINK-5778] [savepoints] Add savepoint serializer...

2017-10-24 Thread uce
Github user uce closed the pull request at: https://github.com/apache/flink/pull/3442 ---

[GitHub] flink issue #4888: [backport] [FLINK-7067] Resume checkpointing after failed...

2017-10-24 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4888 Merged in e8e2913. ---

[GitHub] flink pull request #4888: [backport] [FLINK-7067] Resume checkpointing after...

2017-10-24 Thread uce
Github user uce closed the pull request at: https://github.com/apache/flink/pull/4888 ---

[GitHub] flink issue #4888: [backport] [FLINK-7067] Resume checkpointing after failed...

2017-10-24 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4888 All failed tests are due to a similar issue that seems not to be related to the tests. Merging... ---

[GitHub] flink issue #4888: [backport] [FLINK-7067] Resume checkpointing after failed...

2017-10-23 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4888 @aljoscha Getting the following message in two of the builds in https://travis-ci.org/apache/flink/builds/291523047

[GitHub] flink pull request #4888: [backport] [FLINK-7067] Resume checkpointing after...

2017-10-23 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/4888 [backport] [FLINK-7067] Resume checkpointing after failed cancel-job-with-savepoint This is a backport of #4254. I will merge this as soon as Travis gives the green light. You can merge this pull

[GitHub] flink issue #4254: [FLINK-7067] [jobmanager] Fix side effects after failed c...

2017-10-23 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4254 Travis gave the green light, merging this now. ---

[GitHub] flink issue #4254: [FLINK-7067] [jobmanager] Fix side effects after failed c...

2017-10-20 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4254 Cool! I'll rebase this and merge after Travis gives the green light. ---

[GitHub] flink issue #4254: [FLINK-7067] [jobmanager] Fix side effects after failed c...

2017-10-20 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4254 @tillrohrmann Thanks for looking over this. The `TestingCluster` is definitely preferable. I don't recall how I ended up with the custom setup instead of the `TestingCluster`. I changed

[GitHub] flink pull request #4254: [FLINK-7067] [jobmanager] Fix side effects after f...

2017-10-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/4254#discussion_r145923787 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java --- @@ -940,6 +955,177 @@ public void testCancelWithSavepoint

[GitHub] flink issue #4693: [FLINK-7645][docs] Modify system-metrics part show in the...

2017-09-25 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4693 Hey @yew1eb, I like this 👍 I think it really makes sense to make this browsable from the table of contents. @zentol What do you think? I would be in favour of merging this if you don't have any

[GitHub] flink pull request #4645: [FLINK-7582] [REST] Netty thread immediately parse...

2017-09-06 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/4645#discussion_r137269070 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java --- @@ -159,24 +155,17 @@ public void shutdown(Time timeout

[GitHub] flink issue #4647: [FLINK-7575] [WEB-DASHBOARD] Display "Fetching..." instea...

2017-09-06 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4647 Thanks @zentol for the review. @jameslafa - Regarding the first point with checkstyle: It's confusing that our checkstyle settings don't catch this, but Chesnay is right here. Seems

[GitHub] flink pull request #4645: [FLINK-7582] [REST] Netty thread immediately parse...

2017-09-05 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/4645#discussion_r137038459 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java --- @@ -159,24 +155,17 @@ public void shutdown(Time timeout

[GitHub] flink issue #4553: [FLINK-7642] [docs] Add very obvious warning about outdat...

2017-08-17 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4553 @twalthr Thanks for doing the work of merging this to the other branches as well. I've triggered a build for all branches. While 1.2 worked and the warning is now available online (https

[GitHub] flink pull request #4553: [FLINK-7642] [docs] Add very obvious warning about...

2017-08-16 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/4553 [FLINK-7642] [docs] Add very obvious warning about outdated docs ## What is the purpose of the change This pull requests make the warning about outdated docs more obvious. ![screen

[GitHub] flink issue #4360: [FLINK-7220] [checkpoints] Update RocksDB dependency to 5...

2017-07-28 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4360 Thanks for the pointer Greg. I didn't look at the JIRA issue. I like the idea of automating this but I would go with a pre-push hook instead of a pre-commit hook. It could be annoying during local dev

[GitHub] flink issue #4360: [FLINK-7220] [checkpoints] Update RocksDB dependency to 5...

2017-07-28 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4360 @StefanRRichter As mentioned by Greg, we should either squash follow up commits like `Stephan's comments` into their parent or tag them similar to the main commit with a more descriptive message

[GitHub] flink issue #4391: [FLINK-7258] [network] Fix watermark configuration order

2017-07-25 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4391 Thanks for the review @zhijiangW and @zentol. Merging this for `1.3` and `master`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #4391: [FLINK-7258] [network] Fix watermark configuration...

2017-07-24 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/4391 [FLINK-7258] [network] Fix watermark configuration order ## Purpose This PR changes the order in which low and high watermarks are configured for Netty server child connections (high first

[GitHub] flink pull request #4112: [FLINK-6901] Flip checkstyle configuration files

2017-07-10 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/4112#discussion_r126464199 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyBufferPool.java --- @@ -61,7 +60,9 @@ public NettyBufferPool(int

[GitHub] flink pull request #4254: [FLINK-7067] [jobmanager] Fix side effects after f...

2017-07-05 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/4254#discussion_r125606557 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java --- @@ -940,6 +955,177 @@ public void testCancelWithSavepoint

[GitHub] flink pull request #4254: [FLINK-7067] [jobmanager] Fix side effects after f...

2017-07-04 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/4254 [FLINK-7067] [jobmanager] Fix side effects after failed cancel-job-with-savepoint If a cancel-job-with-savepoint request fails, this has an unintended side effect on the respective job if it has

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-07-04 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4213 Just ran into this as well. This was so annoying. Thank you very much for the fix... I spent an hour assuming it was a problem on my side. Merging now... --- If your project is set up for it, you can

[GitHub] flink pull request #4163: [FLINK-6952] [FLINK-6985] [docs] Add Javadocs link...

2017-06-22 Thread uce
Github user uce closed the pull request at: https://github.com/apache/flink/pull/4163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #4164: [FLINK-6952] [FLINK-6985] [docs] Add Javadocs link...

2017-06-22 Thread uce
Github user uce closed the pull request at: https://github.com/apache/flink/pull/4164 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #4164: [FLINK-6952] [FLINK-6985] [docs] Add Javadocs link...

2017-06-22 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/4164 [FLINK-6952] [FLINK-6985] [docs] Add Javadocs links and remove bugfix version (1.2) Backport of #4162 for the `release-1.2` branch. You can merge this pull request into a Git repository by running

[GitHub] flink pull request #4163: [FLINK-6952] [FLINK-6985] [docs] Add Javadocs link...

2017-06-22 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/4163 [FLINK-6952] [FLINK-6985] [docs] Add Javadocs links and remove bugfix version (1.3) Backport of #4162 for the `release-1.3` branch. You can merge this pull request into a Git repository by running

[GitHub] flink pull request #4162: [FLINK-6952] [FLINK-6985] [docs] Add Javadocs link...

2017-06-22 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/4162 [FLINK-6952] [FLINK-6985] [docs] Add Javadocs links and remove bugfix version Adds a link to the Javadocs in the left side navigation: ![screen shot 2017-06-20 at 11 46 38](https://user

[GitHub] flink issue #3495: [FLINK-5781][config] Generation HTML from ConfigOption

2017-05-03 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3495 I think it's up to you guys whether you want the short description in there or not. I see that it only makes sense if you actually invest the time to have a good short description. You would probably

[GitHub] flink issue #3785: [FLINK-6337][network] Remove the buffer provider from Par...

2017-05-02 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3785 Thanks! Looks good to merge now 👍 I've rebased it and pushed it to Travis here: https://travis-ci.org/uce/flink/builds/227891373 As soon as it succeeds, I'm going to merge this PR

[GitHub] flink pull request #3785: [FLINK-6337][network] Remove the buffer provider f...

2017-04-28 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3785#discussion_r113904383 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -68,7 +68,11 @@ public static void

[GitHub] flink pull request #3785: [FLINK-6337][network] Remove the buffer provider f...

2017-04-28 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3785#discussion_r113905412 --- Diff: flink-tests/src/test/java/org/apache/flink/test/misc/SuccessAfterNetworkBuffersFailureITCase.java --- @@ -68,7 +68,6 @@ public void

[GitHub] flink issue #3796: [FLINK-6293] [tests] Harden JobManagerITCase

2017-04-28 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3796 Good fix. +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #3785: [FLINK-6337][network] Remove the buffer provider f...

2017-04-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3785#discussion_r113690389 --- Diff: flink-tests/src/test/java/org/apache/flink/test/misc/SuccessAfterNetworkBuffersFailureITCase.java --- @@ -68,7 +68,6 @@ public void

[GitHub] flink pull request #3785: [FLINK-6337][network] Remove the buffer provider f...

2017-04-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3785#discussion_r113690239 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java --- @@ -351,15 +351,15 @@ public void

[GitHub] flink pull request #3606: [FLINK-6182] Fix possible NPE in SourceStreamTask

2017-03-24 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/3606 [FLINK-6182] Fix possible NPE in SourceStreamTask A user ran into this and reported confusing NPEs in the logs. This could only happen if a source task is cancelled before it was invoked. You can

[GitHub] flink issue #3597: [FLINK-6170] [metrics] Don't rely on stats snapshot for c...

2017-03-22 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3597 Thanks, will merge after Travis gives a green light. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #3597: [FLINK-6170] [metrics] Don't rely on stats snapsho...

2017-03-22 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/3597 [FLINK-6170] [metrics] Don't rely on stats snapshot for checkpoint metrics Some checkpoint metrics use the latest stats snapshot to get the returned metric value. In practice, this means

[GitHub] flink issue #3583: [FLINK-6043] [web] Display exception timestamp

2017-03-22 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3583 Thanks for addressing the comments. I'm unsure about the `ErrorInfo` instead of adding the suggested method. Since @tillrohrmann and @StephanEwen often work on the `ExecutionGraph` I would like

[GitHub] flink issue #3577: [FLINK-6133] fix build status in README.md

2017-03-20 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3577 There is a discussion on the dev mailing list whether we want to have this or not. I would wait until that is resolved before continuing here. --- If your project is set up for it, you can reply

[GitHub] flink issue #3572: [FLINK-6127] [checkstyle] Add MissingDeprecation check

2017-03-20 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3572 Thanks for catching the unfortunate typo. I've fixed all of those. I left the confusing deprecation comment as is in the table API. I think this is good to merge then. --- If your project

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106949177 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,242

[GitHub] flink pull request #3572: [FLINK-6127] [checkstyle] Add MissingDeprecation c...

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3572#discussion_r106942215 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/calcite/rules/FlinkAggregateExpandDistinctAggregatesRule.java --- @@ -114,15 +114,21

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106948899 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/history/FsJobArchivist.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106948356 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,242

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106902557 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106900975 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,259

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106900609 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java --- @@ -0,0 +1,293 @@ +/* + * Licensed

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106900349 --- Diff: docs/monitoring/rest_api.md --- @@ -22,36 +22,69 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106900686 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java --- @@ -0,0 +1,293 @@ +/* + * Licensed

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106901748 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/history/FsJobArchivist.java --- @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r106903661 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,259

[GitHub] flink pull request #3572: [FLINK-6127] [checkstyle] Add MissingDeprecation c...

2017-03-20 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/3572 [FLINK-6127] [checkstyle] Add MissingDeprecation check Adds the MissingDeprecation check to our set of checkstyle rules. Requires every `@Deprecated` annotation to have a `@deprecated` JavaDoc

[GitHub] flink issue #3552: [FLINK-5978] Fix JM WebFrontend address ConfigOption is d...

2017-03-20 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3552 Looking into #2680 that added this change, it was meant to be followed up on and move all web configuration to a new class. Could we do this here and not only a single one? --- If your project is set

[GitHub] flink issue #3543: [FLINK-5985] [Backport for 1.2] Report no task states for...

2017-03-20 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3543 Could you merge this @StefanRRichter? I think it is one of the last blockers for 1.2.1 and it's a pretty critical issue... --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #3561: [FLINK-6058] fix read DEFAULT_PARALLELISM from ContextEnv...

2017-03-20 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3561 @aljoscha Could you have a brief look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3494: [FLINK-5635] [docker] Improve Docker tooling

2017-03-15 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3494 Thanks for this :-) It was interesting to follow your discussions @iemejia, @jgrier and @patricklucas. I've tried this out and it works as expected. I'm going to merge this later today

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105929511 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105929296 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105928423 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105906846 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobManagerOptions.java --- @@ -32,6 +32,13 @@ public static final

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105918471 --- Diff: flink-runtime-web/web-dashboard/app/index_hs.jade --- @@ -0,0 +1,60 @@ +// + Licensed to the Apache Software Foundation (ASF) under one

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105898166 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105894483 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105876698 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java --- @@ -0,0 +1,276 @@ +/* + * Licensed

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105894735 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -0,0 +1,244

[GitHub] flink pull request #3460: [FLINK-1579] Implement History Server

2017-03-14 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3460#discussion_r105877694 --- Diff: flink-runtime-web/web-dashboard/app/index_hs.jade --- @@ -0,0 +1,60 @@ +// + Licensed to the Apache Software Foundation (ASF) under one

  1   2   3   4   5   6   7   8   9   10   >