[jira] [Commented] (FLINK-5388) Remove private access of edges and vertices of Gelly Graph class
[ https://issues.apache.org/jira/browse/FLINK-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798402#comment-15798402 ] wouter ligtenberg commented on FLINK-5388: -- Alright thnx! > Remove private access of edges and vertices of Gelly Graph class > > > Key: FLINK-5388 > URL: https://issues.apache.org/jira/browse/FLINK-5388 > Project: Flink > Issue Type: Improvement > Components: Gelly >Affects Versions: 1.1.3 > Environment: Java >Reporter: wouter ligtenberg >Assignee: Anton Solovev > Original Estimate: 1h > Remaining Estimate: 1h > > If you want to make a special kind of Graph with special edge types or some > different methods on top of Gelly you want to be able to extend the Graph > class. Currently that's not possible because the constructor is private. I > don't know what effect this has on other methods or the scale of the project, > but it was just something that i ran into in my project -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-5388) Remove private access of edges and vertices of Gelly Graph class
[ https://issues.apache.org/jira/browse/FLINK-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798357#comment-15798357 ] wouter ligtenberg commented on FLINK-5388: -- What does this mean? That it will be implemented? > Remove private access of edges and vertices of Gelly Graph class > > > Key: FLINK-5388 > URL: https://issues.apache.org/jira/browse/FLINK-5388 > Project: Flink > Issue Type: Improvement > Components: Gelly >Affects Versions: 1.1.3 > Environment: Java >Reporter: wouter ligtenberg >Assignee: Anton Solovev > Original Estimate: 1h > Remaining Estimate: 1h > > If you want to make a special kind of Graph with special edge types or some > different methods on top of Gelly you want to be able to extend the Graph > class. Currently that's not possible because the constructor is private. I > don't know what effect this has on other methods or the scale of the project, > but it was just something that i ran into in my project -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-5388) Remove private access of edges and vertices of Gelly Graph class
[ https://issues.apache.org/jira/browse/FLINK-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15773242#comment-15773242 ] wouter ligtenberg commented on FLINK-5388: -- For my purpose, yes i think it is > Remove private access of edges and vertices of Gelly Graph class > > > Key: FLINK-5388 > URL: https://issues.apache.org/jira/browse/FLINK-5388 > Project: Flink > Issue Type: Improvement > Components: Gelly >Affects Versions: 1.1.3 > Environment: Java >Reporter: wouter ligtenberg > Original Estimate: 1h > Remaining Estimate: 1h > > If you want to make a special kind of Graph with special edge types or some > different methods on top of Gelly you want to be able to extend the Graph > class. Currently that's not possible because the constructor is private. I > don't know what effect this has on other methods or the scale of the project, > but it was just something that i ran into in my project -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-5388) Remove private access of edges and vertices of Gelly Graph class
[ https://issues.apache.org/jira/browse/FLINK-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15773154#comment-15773154 ] wouter ligtenberg commented on FLINK-5388: -- I have created a Temporal graph tool on top of Gelly, on top of an edge label a temporal edge also has a starting and ending time. I have made several algorithms that use temporal graphs. I wanted to make a temporalGraph class that extends the Graph class such that i can easily make the gelly calls like numberOfVertices for instance. Also i think it should be usefull if later on other people want to add their own abstraction layer on top of Gelly > Remove private access of edges and vertices of Gelly Graph class > > > Key: FLINK-5388 > URL: https://issues.apache.org/jira/browse/FLINK-5388 > Project: Flink > Issue Type: Improvement > Components: Gelly >Affects Versions: 1.1.3 > Environment: Java >Reporter: wouter ligtenberg > Original Estimate: 1h > Remaining Estimate: 1h > > If you want to make a special kind of Graph with special edge types or some > different methods on top of Gelly you want to be able to extend the Graph > class. Currently that's not possible because the constructor is private. I > don't know what effect this has on other methods or the scale of the project, > but it was just something that i ran into in my project -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FLINK-5388) Remove private access of edges and vertices of Gelly Graph class
wouter ligtenberg created FLINK-5388: Summary: Remove private access of edges and vertices of Gelly Graph class Key: FLINK-5388 URL: https://issues.apache.org/jira/browse/FLINK-5388 Project: Flink Issue Type: Improvement Components: Gelly Affects Versions: 1.1.3 Environment: Java Reporter: wouter ligtenberg If you want to make a special kind of Graph with special edge types or some different methods on top of Gelly you want to be able to extend the Graph class. Currently that's not possible because the constructor is private. I don't know what effect this has on other methods or the scale of the project, but it was just something that i ran into in my project -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FLINK-5161) accepting NullValue for VV in Gelly examples and GSA
wouter ligtenberg created FLINK-5161: Summary: accepting NullValue for VV in Gelly examples and GSA Key: FLINK-5161 URL: https://issues.apache.org/jira/browse/FLINK-5161 Project: Flink Issue Type: Improvement Components: Gelly Affects Versions: 1.1.3 Reporter: wouter ligtenberg I made this topic a few days ago about EV, i meant VV back then, i don't know why i suddenly thought about EV and it confused myself. In this gelly example [1] and this GSA algorithm [2] a Vertex Value of Double is required but never used, wouldn't it be better to change this into a NullValue? I create a lot of data without Vertex Values and it seems to me that it's more efficient I'd like to hear your thoughts on this [1] https://github.com/apache/flink/blob/master/flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/SingleSourceShortestPaths.java [2] https://github.com/apache/flink/blob/master/flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/GSASingleSourceShortestPaths.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-5152) accepting NullValue for EV in Gelly examples
[ https://issues.apache.org/jira/browse/FLINK-5152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15692739#comment-15692739 ] wouter ligtenberg commented on FLINK-5152: -- Ah right, sorry i missed that, this ticket can be closed then > accepting NullValue for EV in Gelly examples > > > Key: FLINK-5152 > URL: https://issues.apache.org/jira/browse/FLINK-5152 > Project: Flink > Issue Type: Improvement > Components: Gelly >Affects Versions: 1.1.3 >Reporter: wouter ligtenberg > Fix For: 1.1.3 > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > In this gelly example [1] an EdgeValue of Double is required but never used, > wouldn't it be better to change this into a NullValue? I create a lot of data > without Edge Values and it seems to me that it's more efficient > I'd like to hear your thoughts on this > [1] > https://github.com/apache/flink/blob/master/flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/SingleSourceShortestPaths.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FLINK-5152) accepting NullValue for EV in Gelly examples
wouter ligtenberg created FLINK-5152: Summary: accepting NullValue for EV in Gelly examples Key: FLINK-5152 URL: https://issues.apache.org/jira/browse/FLINK-5152 Project: Flink Issue Type: Improvement Components: Gelly Affects Versions: 1.1.3 Reporter: wouter ligtenberg Fix For: 1.1.3 In this gelly example [1] an EdgeValue of Double is required but never used, wouldn't it be better to change this into a NullValue? I create a lot of data without Edge Values and it seems to me that it's more efficient I'd like to hear your thoughts on this [1] https://github.com/apache/flink/blob/master/flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/SingleSourceShortestPaths.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
