[jira] [Comment Edited] (FLINK-25538) [JUnit5 Migration] Module: flink-connector-kafka

2023-11-08 Thread xiang1 yu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-25538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783891#comment-17783891
 ] 

xiang1 yu edited comment on FLINK-25538 at 11/9/23 2:09 AM:


Hi [~mapohl],  I would be interested to work on this one. Could you please 
assign it to me?  I just submit a PR of this issue.  
[https://github.com/apache/flink-connector-kafka/pull/66]


was (Author: JIRAUSER302279):
Hi [~mapohl],  I would be interested to work on this one. Could you please 
assign it to me? 

> [JUnit5 Migration] Module: flink-connector-kafka
> 
>
> Key: FLINK-25538
> URL: https://issues.apache.org/jira/browse/FLINK-25538
> Project: Flink
>  Issue Type: Sub-task
>  Components: Connectors / Kafka
>Reporter: Qingsheng Ren
>Assignee: Ashmeet Kandhari
>Priority: Minor
>  Labels: pull-request-available, stale-assigned, starter
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (FLINK-25538) [JUnit5 Migration] Module: flink-connector-kafka

2023-11-08 Thread xiang1 yu (Jira)


[ https://issues.apache.org/jira/browse/FLINK-25538 ]


xiang1 yu deleted comment on FLINK-25538:
---

was (Author: JIRAUSER302279):
 I just submit a PR of this issue.If you have time, could you please help 
review it?  https://github.com/apache/flink-connector-kafka/pull/66

> [JUnit5 Migration] Module: flink-connector-kafka
> 
>
> Key: FLINK-25538
> URL: https://issues.apache.org/jira/browse/FLINK-25538
> Project: Flink
>  Issue Type: Sub-task
>  Components: Connectors / Kafka
>Reporter: Qingsheng Ren
>Assignee: Ashmeet Kandhari
>Priority: Minor
>  Labels: pull-request-available, stale-assigned, starter
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-25538) [JUnit5 Migration] Module: flink-connector-kafka

2023-11-08 Thread xiang1 yu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-25538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784245#comment-17784245
 ] 

xiang1 yu commented on FLINK-25538:
---

 I just submit a PR of this issue.If you have time, could you please help 
review it?  https://github.com/apache/flink-connector-kafka/pull/66

> [JUnit5 Migration] Module: flink-connector-kafka
> 
>
> Key: FLINK-25538
> URL: https://issues.apache.org/jira/browse/FLINK-25538
> Project: Flink
>  Issue Type: Sub-task
>  Components: Connectors / Kafka
>Reporter: Qingsheng Ren
>Assignee: Ashmeet Kandhari
>Priority: Minor
>  Labels: pull-request-available, stale-assigned, starter
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-25538) [JUnit5 Migration] Module: flink-connector-kafka

2023-11-07 Thread xiang1 yu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-25538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783891#comment-17783891
 ] 

xiang1 yu commented on FLINK-25538:
---

Hi [~mapohl],  I would be interested to work on this one. Could you please 
assign it to me? 

> [JUnit5 Migration] Module: flink-connector-kafka
> 
>
> Key: FLINK-25538
> URL: https://issues.apache.org/jira/browse/FLINK-25538
> Project: Flink
>  Issue Type: Sub-task
>  Components: Connectors / Kafka
>Reporter: Qingsheng Ren
>Assignee: Ashmeet Kandhari
>Priority: Minor
>  Labels: pull-request-available, stale-assigned, starter
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (FLINK-32108) KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-10-30 Thread xiang1 yu (Jira)


[ https://issues.apache.org/jira/browse/FLINK-32108 ]


xiang1 yu deleted comment on FLINK-32108:
---

was (Author: JIRAUSER302279):
Hi, @Matthias Pohl; I tested locally and there was a print message, and exit 
-1,  so I'm not sure if {{assumeThat}} doesn't work properly in the 
{{@BeforeAll}} context.

!image-2023-10-30-14-05-27-154.png!

> KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't 
> print the actual failure message
> --
>
> Key: FLINK-32108
> URL: https://issues.apache.org/jira/browse/FLINK-32108
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Test Infrastructure
>Affects Versions: 1.18.0
>Reporter: Matthias Pohl
>Priority: Minor
>  Labels: pull-request-available, starter
> Attachments: image-2023-10-30-14-05-27-154.png
>
>
> {{KubernetesExtension}} implements {{BeforeAllCallback}} which calls the 
> {{assumeThat}} in the {{@BeforeAll}} context. {{assumeThat}} doesn't work 
> properly in the {{@BeforeAll}} context, though: The error message is not 
> printed and the test fails with exit code -1.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-32108) KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-10-30 Thread xiang1 yu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-32108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780853#comment-17780853
 ] 

xiang1 yu commented on FLINK-32108:
---

Hi, @Matthias Pohl; I tested locally and there was a print message, and exit 
-1,  so I'm not sure if {{assumeThat}} doesn't work properly in the 
{{@BeforeAll}} context.

!image-2023-10-30-14-05-27-154.png!

> KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't 
> print the actual failure message
> --
>
> Key: FLINK-32108
> URL: https://issues.apache.org/jira/browse/FLINK-32108
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Test Infrastructure
>Affects Versions: 1.18.0
>Reporter: Matthias Pohl
>Priority: Minor
>  Labels: pull-request-available, starter
> Attachments: image-2023-10-30-14-05-27-154.png
>
>
> {{KubernetesExtension}} implements {{BeforeAllCallback}} which calls the 
> {{assumeThat}} in the {{@BeforeAll}} context. {{assumeThat}} doesn't work 
> properly in the {{@BeforeAll}} context, though: The error message is not 
> printed and the test fails with exit code -1.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (FLINK-32108) KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-10-30 Thread xiang1 yu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-32108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

xiang1 yu updated FLINK-32108:
--
Attachment: image-2023-10-30-14-05-27-154.png

> KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't 
> print the actual failure message
> --
>
> Key: FLINK-32108
> URL: https://issues.apache.org/jira/browse/FLINK-32108
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Test Infrastructure
>Affects Versions: 1.18.0
>Reporter: Matthias Pohl
>Priority: Minor
>  Labels: pull-request-available, starter
> Attachments: image-2023-10-30-14-05-27-154.png
>
>
> {{KubernetesExtension}} implements {{BeforeAllCallback}} which calls the 
> {{assumeThat}} in the {{@BeforeAll}} context. {{assumeThat}} doesn't work 
> properly in the {{@BeforeAll}} context, though: The error message is not 
> printed and the test fails with exit code -1.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-32107) Kubernetes test failed because ofunable to establish ssl connection to github on AZP

2023-10-17 Thread xiang1 yu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-32107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776441#comment-17776441
 ] 

xiang1 yu commented on FLINK-32107:
---

Hi,@[~mapohl] , Does this bug only fail early? Can you assign it to me?

> Kubernetes test failed because ofunable to establish ssl connection to github 
> on AZP
> 
>
> Key: FLINK-32107
> URL: https://issues.apache.org/jira/browse/FLINK-32107
> Project: Flink
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.18.0, 1.17.1
>Reporter: Sergey Nuyanzin
>Priority: Major
>  Labels: pull-request-available, starter, test-stability
>
> on AZP kubernetes test fails 
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=49022=logs=bea52777-eaf8-5663-8482-18fbc3630e81=43ba8ce7-ebbf-57cd-9163-444305d74117=4884
> as
> {noformat}
> 2023-05-16T03:54:54.4652330Z May 16 03:54:54 
> 2023-05-16T03:54:54.4652942Z May 16 03:54:54 [FAIL] 'Run Kubernetes test' 
> failed after 5 minutes and 37 seconds! Test exited with exit code 1
> 2023-05-16T03:54:54.4653363Z May 16 03:54:54 
> {noformat}
> in logs
> {noformat}
> 023-05-16T03:49:29.2350048Z --2023-05-16 03:49:29--  
> https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.24.2/crictl-v1.24.2-linux-amd64.tar.gz
> 2023-05-16T03:49:29.2401348Z Resolving github.com (github.com)... 140.82.121.3
> 2023-05-16T03:49:29.2519421Z Connecting to github.com 
> (github.com)|140.82.121.3|:443... connected.
> 2023-05-16T03:49:29.2636971Z Unable to establish SSL connection.
> 2023-05-16T03:49:29.2717345Z tar (child): crictl-v1.24.2-linux-amd64.tar.gz: 
> Cannot open: No such file or directory
> 2023-05-16T03:49:29.2718128Z tar (child): Error is not recoverable: exiting 
> now
> 2023-05-16T03:49:29.2720740Z tar: Child returned status 2
> 2023-05-16T03:49:29.2721169Z tar: Error is not recoverable: exiting now
> {noformat}
> and then 
> {noformat}
> 2023-05-16T03:51:19.7583853Z May 16 03:51:19 Starting minikube ...
> 2023-05-16T03:51:19.8445449Z May 16 03:51:19 * minikube v1.28.0 on Ubuntu 
> 20.04
> 2023-05-16T03:51:19.8459453Z May 16 03:51:19 * Using the none driver based on 
> user configuration
> 2023-05-16T03:51:19.8479317Z May 16 03:51:19 * Starting control plane node 
> minikube in cluster minikube
> 2023-05-16T03:51:19.8500624Z May 16 03:51:19 * Running on localhost (CPUs=2, 
> Memory=6943MB, Disk=85160MB) ...
> 2023-05-16T03:51:19.8773352Z May 16 03:51:19 * minikube 1.30.1 is available! 
> Download it: https://github.com/kubernetes/minikube/releases/tag/v1.30.1
> 2023-05-16T03:51:19.8784220Z May 16 03:51:19 * To disable this notice, run: 
> 'minikube config set WantUpdateNotification false'
> 2023-05-16T03:51:19.8784716Z May 16 03:51:19 
> 2023-05-16T03:51:20.3656967Z May 16 03:51:20 * OS release is Ubuntu 20.04.6 
> LTS
> 2023-05-16T03:52:21.7634993Z May 16 03:52:21 
> 2023-05-16T03:52:21.7654050Z X Exiting due to RUNTIME_ENABLE: Temporary 
> Error: sudo crictl version: exit status 1
> 2023-05-16T03:52:21.7654511Z stdout:
> 2023-05-16T03:52:21.7654700Z 
> 2023-05-16T03:52:21.7654925Z stderr:
> 2023-05-16T03:52:21.7655194Z sudo: crictl: command not found
> 2023-05-16T03:52:21.7655377Z 
> 2023-05-16T03:52:21.7655589Z * 
> 2023-05-16T03:52:21.7676462Z 
> ╭─╮
> 2023-05-16T03:52:21.7677189Z │
>  │
> 2023-05-16T03:52:21.7677684Z │* If the above advice does not help, please 
> let us know: │
> 2023-05-16T03:52:21.7678141Z │  
> https://github.com/kubernetes/minikube/issues/new/choose  
>  │
> 2023-05-16T03:52:21.7678549Z │
>  │
> 2023-05-16T03:52:21.7679208Z │* Please run `minikube logs 
> --file=logs.txt` and attach logs.txt to the GitHub issue.│
> 2023-05-16T03:52:21.7679781Z │
>  │
> 2023-05-16T03:52:21.7680268Z 
> ╰─╯
> 2023-05-16T03:52:21.7680606Z May 16 03:52:21 
> 2023-05-16T03:52:21.8422493Z E0516 03:52:21.841334  243032 root.go:80] failed 
> to log command start to audit: failed to open the audit log: open 
> /home/vsts/.minikube/logs/audit.json: permission denied
> 2023-05-16T03:52:21.8434631Z May 16 03:52:21 
> 2023-05-16T03:52:21.8447806Z X Exiting due to HOST_HOME_PERMISSION: open 
> /home/vsts/.minikube/profiles/minikube/config.json: permission denied
> 2023-05-16T03:52:21.8448801Z * Suggestion: Your user 

[jira] [Commented] (FLINK-30893) Replace not specifying a driver in Minikube by something else

2023-10-08 Thread xiang1 yu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-30893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772947#comment-17772947
 ] 

xiang1 yu commented on FLINK-30893:
---

  Hi [Matthias 
Pohl|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mapohl], I 
just submit a PR of this issue.If you have time, could you please help review 
it? 

> Replace not specifying a driver in Minikube by something else
> -
>
> Key: FLINK-30893
> URL: https://issues.apache.org/jira/browse/FLINK-30893
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Test Infrastructure
>Affects Versions: 1.17.0, 1.15.3, 1.16.1
>Reporter: Matthias Pohl
>Priority: Minor
>  Labels: auto-deprioritized-major, pull-request-available, starter
>
> Quoting [~wangyang0918] here from a [Github PR 
> comment|https://github.com/apache/flink/pull/21837#pullrequestreview-1282199706]:
> {quote}
> We need to find a more elegant way to avoid none driver of minikube in the 
> future. And then we could rely on the latest minikube version and find some 
> potential incompatible problems with new K8s versions.
> {quote}
> Starting point for this issue might be {{setup_kubernetes_for_linux}} 
> function in 
> [flink-end-to-end-tests/test-scripts/common_kubernetes.sh:32ff|https://github.com/apache/flink/blob/b1c3c7579e18cf11c809bf09c05b0774e972f1fc/flink-end-to-end-tests/test-scripts/common_kubernetes.sh#L32]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (FLINK-32108) KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-09-24 Thread xiang1 yu (Jira)


[ https://issues.apache.org/jira/browse/FLINK-32108 ]


xiang1 yu deleted comment on FLINK-32108:
---

was (Author: JIRAUSER302279):
 Hi [Matthias 
Pohl|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mapohl], I 
just submit a PR of this issue.If you have time, could you please help review 
it?  [https://github.com/apache/flink/pull/23451] 

> KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't 
> print the actual failure message
> --
>
> Key: FLINK-32108
> URL: https://issues.apache.org/jira/browse/FLINK-32108
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Test Infrastructure
>Affects Versions: 1.18.0
>Reporter: Matthias Pohl
>Priority: Minor
>  Labels: pull-request-available, starter
>
> {{KubernetesExtension}} implements {{BeforeAllCallback}} which calls the 
> {{assumeThat}} in the {{@BeforeAll}} context. {{assumeThat}} doesn't work 
> properly in the {{@BeforeAll}} context, though: The error message is not 
> printed and the test fails with exit code -1.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-32108) KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-09-22 Thread xiang1 yu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-32108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767885#comment-17767885
 ] 

xiang1 yu commented on FLINK-32108:
---

 Hi [Matthias 
Pohl|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mapohl], I 
just submit a PR of this issue.If you have time, could you please help review 
it?  [https://github.com/apache/flink/pull/23451] 

> KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't 
> print the actual failure message
> --
>
> Key: FLINK-32108
> URL: https://issues.apache.org/jira/browse/FLINK-32108
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Test Infrastructure
>Affects Versions: 1.18.0
>Reporter: Matthias Pohl
>Priority: Minor
>  Labels: pull-request-available, starter
>
> {{KubernetesExtension}} implements {{BeforeAllCallback}} which calls the 
> {{assumeThat}} in the {{@BeforeAll}} context. {{assumeThat}} doesn't work 
> properly in the {{@BeforeAll}} context, though: The error message is not 
> printed and the test fails with exit code -1.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-13680) Translate "Code Style - Common Rules" page into Chinese

2023-09-20 Thread xiang1 yu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-13680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767006#comment-17767006
 ] 

xiang1 yu commented on FLINK-13680:
---

Hi, [~jark],  I find 
[https://flink.apache.org/zh/contributing/code-style-and-quality-common.html] 
Not yet translated into Chinese, I am interesting in this issue. Could you 
assign this to me ?

> Translate "Code Style - Common Rules" page into Chinese
> ---
>
> Key: FLINK-13680
> URL: https://issues.apache.org/jira/browse/FLINK-13680
> Project: Flink
>  Issue Type: Sub-task
>  Components: chinese-translation, Project Website
>Reporter: Jark Wu
>Priority: Major
>  Labels: auto-unassigned, pull-request-available
>
> Translate page 
> https://flink.apache.org/zh/contributing/code-style-and-quality-common.html 
> into Chinese. The page is located in 
> https://github.com/apache/flink-web/blob/asf-site/contributing/code-style-and-quality-common.zh.md.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)