[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957
 ] 

xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:26 AM:
-

I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in 
[pr-22555|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]

can you spare some precious time to review and make some comments? thanks a lot.

[~wanglijie] 


was (Author: zxcoccer):
I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in

[pr-22555|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]

can you spare some precious time to review and make some comments? thanks a lot.

[~wanglijie] 

> The default source parallelism should be the same as execution's default 
> parallelism under adaptive batch scheduler
> ---
>
> Key: FLINK-31706
> URL: https://issues.apache.org/jira/browse/FLINK-31706
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Reporter: Yun Tang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.18.0
>
>
> Currently, the sources need to set 
> {{execution.batch.adaptive.auto-parallelism.default-source-parallelism }} in 
> the adaptive batch scheduler mode, otherwise, the source parallelism is only 
> 1 by default. A better solution might be set as the default execution 
> parallelism if no user configured. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957
 ] 

xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:26 AM:
-

I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in

[pr-22555|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]

can you spare some precious time to review and make some comments? thanks a lot.

[~wanglijie] 


was (Author: zxcoccer):
I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in

[pr|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]

[link 
title|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]

can you spare some precious time to review and make some comments.

> The default source parallelism should be the same as execution's default 
> parallelism under adaptive batch scheduler
> ---
>
> Key: FLINK-31706
> URL: https://issues.apache.org/jira/browse/FLINK-31706
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Reporter: Yun Tang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.18.0
>
>
> Currently, the sources need to set 
> {{execution.batch.adaptive.auto-parallelism.default-source-parallelism }} in 
> the adaptive batch scheduler mode, otherwise, the source parallelism is only 
> 1 by default. A better solution might be set as the default execution 
> parallelism if no user configured. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957
 ] 

xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:24 AM:
-

I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in

[pr|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]

[link 
title|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]

can you spare some precious time to review and make some comments.


was (Author: zxcoccer):
I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in

[pr|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]

can you spare some precious time to review and make some comments.

> The default source parallelism should be the same as execution's default 
> parallelism under adaptive batch scheduler
> ---
>
> Key: FLINK-31706
> URL: https://issues.apache.org/jira/browse/FLINK-31706
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Reporter: Yun Tang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.18.0
>
>
> Currently, the sources need to set 
> {{execution.batch.adaptive.auto-parallelism.default-source-parallelism }} in 
> the adaptive batch scheduler mode, otherwise, the source parallelism is only 
> 1 by default. A better solution might be set as the default execution 
> parallelism if no user configured. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957
 ] 

xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:24 AM:
-

I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in

[pr|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]

can you spare some precious time to review and make some comments.


was (Author: zxcoccer):
I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in

[PR-22555|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]

can you spare some precious time to review and make some comments.

> The default source parallelism should be the same as execution's default 
> parallelism under adaptive batch scheduler
> ---
>
> Key: FLINK-31706
> URL: https://issues.apache.org/jira/browse/FLINK-31706
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Reporter: Yun Tang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.18.0
>
>
> Currently, the sources need to set 
> {{execution.batch.adaptive.auto-parallelism.default-source-parallelism }} in 
> the adaptive batch scheduler mode, otherwise, the source parallelism is only 
> 1 by default. A better solution might be set as the default execution 
> parallelism if no user configured. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957
 ] 

xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:24 AM:
-

I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in

[PR-22555|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]

can you spare some precious time to review and make some comments.


was (Author: zxcoccer):
I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in

[PR-22555|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]

[link title|http://example.com]

can you spare some precious time to review and make some comments.

> The default source parallelism should be the same as execution's default 
> parallelism under adaptive batch scheduler
> ---
>
> Key: FLINK-31706
> URL: https://issues.apache.org/jira/browse/FLINK-31706
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Reporter: Yun Tang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.18.0
>
>
> Currently, the sources need to set 
> {{execution.batch.adaptive.auto-parallelism.default-source-parallelism }} in 
> the adaptive batch scheduler mode, otherwise, the source parallelism is only 
> 1 by default. A better solution might be set as the default execution 
> parallelism if no user configured. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957
 ] 

xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:23 AM:
-

I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in

[PR-22555|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]

[link title|http://example.com]

can you spare some precious time to review and make some comments.


was (Author: zxcoccer):
I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in 
[PR-22555|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]can
 you spare some precious time to review and make some comments.

> The default source parallelism should be the same as execution's default 
> parallelism under adaptive batch scheduler
> ---
>
> Key: FLINK-31706
> URL: https://issues.apache.org/jira/browse/FLINK-31706
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Reporter: Yun Tang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.18.0
>
>
> Currently, the sources need to set 
> {{execution.batch.adaptive.auto-parallelism.default-source-parallelism }} in 
> the adaptive batch scheduler mode, otherwise, the source parallelism is only 
> 1 by default. A better solution might be set as the default execution 
> parallelism if no user configured. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957
 ] 

xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:22 AM:
-

I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in 
[PR-22555|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]can
 you spare some precious time to review and make some comments.


was (Author: zxcoccer):
I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in [PR 
22555|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]can
 you spare some precious time to review and make some comments.

> The default source parallelism should be the same as execution's default 
> parallelism under adaptive batch scheduler
> ---
>
> Key: FLINK-31706
> URL: https://issues.apache.org/jira/browse/FLINK-31706
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Reporter: Yun Tang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.18.0
>
>
> Currently, the sources need to set 
> {{execution.batch.adaptive.auto-parallelism.default-source-parallelism }} in 
> the adaptive batch scheduler mode, otherwise, the source parallelism is only 
> 1 by default. A better solution might be set as the default execution 
> parallelism if no user configured. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957
 ] 

xiaochen zhou edited comment on FLINK-31706 at 5/12/23 12:22 AM:
-

I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in [PR 
22555|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]can
 you spare some precious time to review and make some comments.


was (Author: zxcoccer):
I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in [[PR 
22555]|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]
 can you spare some precious time to review and make some comments.

> The default source parallelism should be the same as execution's default 
> parallelism under adaptive batch scheduler
> ---
>
> Key: FLINK-31706
> URL: https://issues.apache.org/jira/browse/FLINK-31706
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Reporter: Yun Tang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.18.0
>
>
> Currently, the sources need to set 
> {{execution.batch.adaptive.auto-parallelism.default-source-parallelism }} in 
> the adaptive batch scheduler mode, otherwise, the source parallelism is only 
> 1 by default. A better solution might be set as the default execution 
> parallelism if no user configured. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721957#comment-17721957
 ] 

xiaochen zhou commented on FLINK-31706:
---

I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in [[PR 
22555]|[https://github.com/apache/flink/pull/22555|https://github.com/apache/flink/pull/22555)]]
 can you spare some precious time to review and make some comments.

> The default source parallelism should be the same as execution's default 
> parallelism under adaptive batch scheduler
> ---
>
> Key: FLINK-31706
> URL: https://issues.apache.org/jira/browse/FLINK-31706
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Reporter: Yun Tang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.18.0
>
>
> Currently, the sources need to set 
> {{execution.batch.adaptive.auto-parallelism.default-source-parallelism }} in 
> the adaptive batch scheduler mode, otherwise, the source parallelism is only 
> 1 by default. A better solution might be set as the default execution 
> parallelism if no user configured. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)


[ https://issues.apache.org/jira/browse/FLINK-31706 ]


xiaochen zhou deleted comment on FLINK-31706:
---

was (Author: zxcoccer):
I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in [pr 
22555]([https://github.com/apache/flink/pull/22555)] can you spare some 
precious time to review and make some comments.

> The default source parallelism should be the same as execution's default 
> parallelism under adaptive batch scheduler
> ---
>
> Key: FLINK-31706
> URL: https://issues.apache.org/jira/browse/FLINK-31706
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Reporter: Yun Tang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.18.0
>
>
> Currently, the sources need to set 
> {{execution.batch.adaptive.auto-parallelism.default-source-parallelism }} in 
> the adaptive batch scheduler mode, otherwise, the source parallelism is only 
> 1 by default. A better solution might be set as the default execution 
> parallelism if no user configured. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31706) The default source parallelism should be the same as execution's default parallelism under adaptive batch scheduler

2023-05-11 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721956#comment-17721956
 ] 

xiaochen zhou commented on FLINK-31706:
---

I am currently implementing the use `paralleism.default` instread of the 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism.` in [pr 
22555]([https://github.com/apache/flink/pull/22555)] can you spare some 
precious time to review and make some comments.

> The default source parallelism should be the same as execution's default 
> parallelism under adaptive batch scheduler
> ---
>
> Key: FLINK-31706
> URL: https://issues.apache.org/jira/browse/FLINK-31706
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Reporter: Yun Tang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.18.0
>
>
> Currently, the sources need to set 
> {{execution.batch.adaptive.auto-parallelism.default-source-parallelism }} in 
> the adaptive batch scheduler mode, otherwise, the source parallelism is only 
> 1 by default. A better solution might be set as the default execution 
> parallelism if no user configured. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31734) Align behaviour of REST API / WEB UI feature flags

2023-05-09 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720987#comment-17720987
 ] 

xiaochen zhou commented on FLINK-31734:
---

hi, I would like to give a try on this, can  I take this ticket?I will try my 
best to complete it
 

> Align behaviour of REST API / WEB UI feature flags
> --
>
> Key: FLINK-31734
> URL: https://issues.apache.org/jira/browse/FLINK-31734
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Configuration, Runtime / REST, Runtime / Web 
> Frontend
>Reporter: David Morávek
>Priority: Major
>
> Currently we have following three feature flags for the web UI and REST API:
> 1) web.submit.enabled
> 2) web.cancel.enabled
> 3) web.rescale.enabled
>  
> 2) and 3) only hide the web UI elements, while 1) also removes the REST API 
> endpoint; We should introduce equivalent options for the REST API 
> (rest.xxx.enabled), which would give the user flexibility to choose whether 
> both REST API and WEB UI should be disabled for a given feature.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-29847) Store/cache JarUploadResponseBody

2023-05-07 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-29847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720328#comment-17720328
 ] 

xiaochen zhou commented on FLINK-29847:
---

hi, I would like to give a try on this, can  I take this ticket?I will try my 
best to complete it
 

> Store/cache JarUploadResponseBody
> -
>
> Key: FLINK-29847
> URL: https://issues.apache.org/jira/browse/FLINK-29847
> Project: Flink
>  Issue Type: Improvement
>  Components: Kubernetes Operator
>Reporter: Daren Wong
>Priority: Major
>
> Kubernetes operator currently uploadJar always even when the same JAR has 
> been uploaded to JM previously. For example, this occurs during rollback and 
> suspend-run operation.
> To improve the performance, we want to cache the JarUploadResponseBody so 
> that in the next runJar operation, kubernetes operator will check the cache 
> and reuse the jar if it's the same JAR. This "cache" can be as simple as 
> storing the uploaded JarFilePath in the CR Status field.
> Ref: 
> [https://github.com/apache/flink-kubernetes-operator/blob/main/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java#L188-L199]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (FLINK-29368) Modify DESCRIBE statement docs for new syntax

2023-04-16 Thread xiaochen zhou (Jira)


[ https://issues.apache.org/jira/browse/FLINK-29368 ]


xiaochen zhou deleted comment on FLINK-29368:
---

was (Author: zxcoccer):
hi,I would like to deal with it. Can you assign this ticket to me ?:)
 

> Modify DESCRIBE statement docs for new syntax
> -
>
> Key: FLINK-29368
> URL: https://issues.apache.org/jira/browse/FLINK-29368
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Planner
>Affects Versions: 1.17.0
>Reporter: Yunhong Zheng
>Priority: Major
> Fix For: 1.18.0
>
>
> In Flink 1.17.0, DESCRIBE statement syntax will be changed to DESCRIBE/DESC 
> [EXTENDED] [catalog_name.][database_name.]table_name 
> [PARTITION(partition_spec)] [col_name]. So, it need to modify the docs for 
> this statement.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-30614) Improve resolving schema compatibility -- Milestone two

2023-04-16 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-30614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712752#comment-17712752
 ] 

xiaochen zhou commented on FLINK-30614:
---

hi, I would like to give a try on this, can  I take this ticket?I will try my 
best to complete it
 

> Improve resolving schema compatibility -- Milestone two
> ---
>
> Key: FLINK-30614
> URL: https://issues.apache.org/jira/browse/FLINK-30614
> Project: Flink
>  Issue Type: Sub-task
>  Components: API / Type Serialization System
>Reporter: Hangxiang Yu
>Priority: Major
>
> In the milestone two, we should:
>  # Remove TypeSerializerSnapshot#resolveSchemaCompatibility(TypeSerializer 
> newSerializer) and related implementation.
>  # Make all places where use 
> TypeSerializerSnapshot#resolveSchemaCompatibility(TypeSerializer 
> newSerializer) to check the compatibility call 
> Typeserializer#resolveSchemaCompatibility(TypeSerializerSnapshot 
> oldSerializerSnapshot). 
>  # Remove the default implementation of the new method.
> It will be done after several stable version.
> See FLIP-263 for more details.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-29124) Redundant checkNotNull in cli Package

2022-09-28 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-29124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610570#comment-17610570
 ] 

xiaochen zhou commented on FLINK-29124:
---

hi,I would like to deal with it. Can you assign this ticket to me ?
 

> Redundant checkNotNull in cli Package
> -
>
> Key: FLINK-29124
> URL: https://issues.apache.org/jira/browse/FLINK-29124
> Project: Flink
>  Issue Type: Improvement
>  Components: Command Line Client
>Reporter: ivan Qing
>Priority: Minor
>
> Redundant NotNull checks in function cli/CliFrontend.
> {*}getEffectiveConfiguration{*}():
> {code:java}
> final ExecutionConfigAccessor executionParameters =                
> ExecutionConfigAccessor.fromProgramOptions(
> checkNotNull(programOptions), checkNotNull(jobJars));
>  {code}
> while *ExecutionConfigAccessor.fromProgramOptions* indeed does the notNull 
> check
> {code:java}
> public static  ExecutionConfigAccessor fromProgramOptions(
>             final ProgramOptions options, 
>   final List jobJars) {        
> checkNotNull(options);       
> checkNotNull(jobJars);
> ...
> } 
> {code}
> I have searched other *ExecutionConfigAccessor.fromProgramOptions()* usages, 
> and all of them do not use checkNotNull in invokion



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-29176) Add python support for ChiSqTest

2022-09-28 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-29176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610567#comment-17610567
 ] 

xiaochen zhou commented on FLINK-29176:
---

hi,I would like to deal with it. Can you assign this ticket to me ?
 

> Add python support for ChiSqTest
> 
>
> Key: FLINK-29176
> URL: https://issues.apache.org/jira/browse/FLINK-29176
> Project: Flink
>  Issue Type: Improvement
>  Components: Library / Machine Learning
>Reporter: Zhipeng Zhang
>Priority: Major
> Fix For: ml-2.2.0
>
>
> We already implemented ChiSqTest in java. In this pr, we aim to add python 
> source/test/example for ChiSqTest



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (FLINK-29432) Replace GenericUDFNvl with GenericUDFCoalesce

2022-09-28 Thread xiaochen zhou (Jira)


[ https://issues.apache.org/jira/browse/FLINK-29432 ]


xiaochen zhou deleted comment on FLINK-29432:
---

was (Author: zxcoccer):
hi,I would like to deal with it. Can you assign this ticket to me ?:)

> Replace GenericUDFNvl with GenericUDFCoalesce
> -
>
> Key: FLINK-29432
> URL: https://issues.apache.org/jira/browse/FLINK-29432
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / Hive
>Affects Versions: 1.15.2
>Reporter: Prabhu Joseph
>Priority: Major
>  Labels: pull-request-available
>
> Hive NVL() function has many issues like 
> [HIVE-25193|https://issues.apache.org/jira/browse/HIVE-25193] and it is 
> retired [HIVE-20961|https://issues.apache.org/jira/browse/HIVE-20961]. Our 
> internal hive distribution has the fix for HIVE-20961. With this fix, Flink 
> Build is failing with below as there is no more GenericUDFNvl in Hive. This 
> needs to be replaced with GenericUDFCoalesce.
> {code}
> [INFO] 
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserDefaultGraphWalker.java:
>  Recompile with -Xlint:unchecked for details.
> [INFO] -
> [ERROR] COMPILATION ERROR : 
> [INFO] -
> [ERROR] 
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserTypeCheckProcFactory.java:[75,45]
>  cannot find symbol
>   symbol:   class GenericUDFNvl
>   location: package org.apache.hadoop.hive.ql.udf.generic
> [ERROR] 
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserTypeCheckProcFactory.java:[1216,41]
>  cannot find symbol
>   symbol:   class GenericUDFNvl
>   location: class 
> org.apache.flink.table.planner.delegation.hive.HiveParserTypeCheckProcFactory.DefaultExprProcessor
> [ERROR] 
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserSemanticAnalyzer.java:[231,26]
>  constructor GlobalLimitCtx in class 
> org.apache.hadoop.hive.ql.parse.GlobalLimitCtx cannot be applied to given 
> types;
>   required: org.apache.hadoop.hive.conf.HiveConf
>   found: no arguments
>   reason: actual and formal argument lists differ in length
> [INFO] 3 errors
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-29300) Upgrade python version to 3.10.3

2022-09-28 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-29300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610565#comment-17610565
 ] 

xiaochen zhou commented on FLINK-29300:
---

hi,I would like to deal with it. Can you assign this ticket to me ?:)
 

> Upgrade python version to 3.10.3
> 
>
> Key: FLINK-29300
> URL: https://issues.apache.org/jira/browse/FLINK-29300
> Project: Flink
>  Issue Type: Improvement
>Reporter: Bilna
>Priority: Major
>
> Security scans listed lot of CVEs from Python 3.8. So please upgrade python 
> version to 3.10.3
> |Component Name|Component Version Name|Vulnerability Name(s)|Base Score - 
> cvss3|Severity - cvss3|Fix version|
> |Python programming language|3.7.3|CVE-2015-20107 (BDSA-2015-0814) 
> |9.8|CRITICAL |3.10.3|
> |Python programming language|3.7.3|CVE-2022-26488 (BDSA-2022-0627) |7|HIGH 
> |3.10.3|
> |Python programming language|3.7.3|CVE-2021-3737 (BDSA-2021-3183) 
> |7.5|HIGH|3.10.3|
> |Python programming language|3.7.3|CVE-2022-0391 (BDSA-2021-4119) 
> |7.5|HIGH|3.10.3|
> |Python programming language|3.7.3|CVE-2021-3177 (BDSA-2021-0085) 
> |9.8|CRITICAL|3.10.3|
> |Python programming language|3.7.3|CVE-2020-27619 (BDSA-2020-2928) 
> |9.8|CRITICAL |3.10.3|
> |Python programming language|3.7.3|CVE-2020-26116 (BDSA-2020-2544) |7.2|HIGH 
> |3.10.3|
> |Python programming language|3.7.3|CVE-2019-20907 (BDSA-2019-4493) 
> |7.5|HIGH|3.10.3|
> |Python programming language|3.7.3|CVE-2020-15523 (BDSA-2020-1616) 
> |7.8|HIGH|3.10.3|
> |Python programming language|3.7.3|CVE-2019-16056 (BDSA-2019-2926) |7.5|HIGH 
> |3.10.3|
> |Python programming language|3.7.3|CVE-2019-10160 (BDSA-2019-1748) 
> |9.8|CRITICAL|3.10.3|
> |Python programming language|3.7.3|CVE-2019-9948 (BDSA-2019-0819) 
> |9.1|CRITICAL|3.10.3|



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-29368) Modify DESCRIBE statement docs for new syntax

2022-09-28 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-29368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610561#comment-17610561
 ] 

xiaochen zhou commented on FLINK-29368:
---

hi,I would like to deal with it. Can you assign this ticket to me ?:)
 

> Modify DESCRIBE statement docs for new syntax
> -
>
> Key: FLINK-29368
> URL: https://issues.apache.org/jira/browse/FLINK-29368
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Planner
>Affects Versions: 1.17.0
>Reporter: Yunhong Zheng
>Priority: Major
> Fix For: 1.17.0
>
>
> In Flink 1.17.0, DESCRIBE statement syntax will be changed to DESCRIBE/DESC 
> [EXTENDED] [catalog_name.][database_name.]table_name 
> [PARTITION(partition_spec)] [col_name]. So, it need to modify the docs for 
> this statement.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-29432) Replace GenericUDFNvl with GenericUDFCoalesce

2022-09-28 Thread xiaochen zhou (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-29432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610560#comment-17610560
 ] 

xiaochen zhou commented on FLINK-29432:
---

hi,I would like to deal with it. Can you assign this ticket to me ?:)

> Replace GenericUDFNvl with GenericUDFCoalesce
> -
>
> Key: FLINK-29432
> URL: https://issues.apache.org/jira/browse/FLINK-29432
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / Hive
>Affects Versions: 1.15.2
>Reporter: Prabhu Joseph
>Priority: Major
>  Labels: pull-request-available
>
> Hive NVL() function has many issues like 
> [HIVE-25193|https://issues.apache.org/jira/browse/HIVE-25193] and it is 
> retired [HIVE-20961|https://issues.apache.org/jira/browse/HIVE-20961]. Our 
> internal hive distribution has the fix for HIVE-20961. With this fix, Flink 
> Build is failing with below as there is no more GenericUDFNvl in Hive. This 
> needs to be replaced with GenericUDFCoalesce.
> {code}
> [INFO] 
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserDefaultGraphWalker.java:
>  Recompile with -Xlint:unchecked for details.
> [INFO] -
> [ERROR] COMPILATION ERROR : 
> [INFO] -
> [ERROR] 
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserTypeCheckProcFactory.java:[75,45]
>  cannot find symbol
>   symbol:   class GenericUDFNvl
>   location: package org.apache.hadoop.hive.ql.udf.generic
> [ERROR] 
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserTypeCheckProcFactory.java:[1216,41]
>  cannot find symbol
>   symbol:   class GenericUDFNvl
>   location: class 
> org.apache.flink.table.planner.delegation.hive.HiveParserTypeCheckProcFactory.DefaultExprProcessor
> [ERROR] 
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserSemanticAnalyzer.java:[231,26]
>  constructor GlobalLimitCtx in class 
> org.apache.hadoop.hive.ql.parse.GlobalLimitCtx cannot be applied to given 
> types;
>   required: org.apache.hadoop.hive.conf.HiveConf
>   found: no arguments
>   reason: actual and formal argument lists differ in length
> [INFO] 3 errors
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)