[GitHub] flink pull request #6282: [FLINK-6847][FLINK-6813][Table Api & Sql] Timestam...

Github user xueyumusic commented on a diff in the pull request: https://github.com/apache/flink/pull/6282#discussion_r204719967 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -338,3 +341,66 @@ case class DateFormat

[GitHub] flink pull request #6382: [FLINK-9907][Table API & SQL] add CRC32 support

GitHub user xueyumusic opened a pull request: https://github.com/apache/flink/pull/6382 [FLINK-9907][Table API & SQL] add CRC32 support ## What is the purpose of the change This PR adds CRC32 checksum compute in table api and sql.It returns the cyclic redundancy check v

[GitHub] flink pull request #6364: [hotfix] typo for SqlExecutionException msg

GitHub user xueyumusic opened a pull request: https://github.com/apache/flink/pull/6364 [hotfix] typo for SqlExecutionException msg fix typo in SqlExecutionException msg in ExecutionContext.java You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink pull request #6337: [FLINK-9853][Tabel API & SQL] add HEX support

Github user xueyumusic commented on a diff in the pull request: https://github.com/apache/flink/pull/6337#discussion_r202581145 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala --- @@ -182,4 +184,6 @@ object

[GitHub] flink pull request #6337: [FLINK-9853][Tabel API & SQL] add HEX support

GitHub user xueyumusic opened a pull request: https://github.com/apache/flink/pull/6337 [FLINK-9853][Tabel API & SQL] add HEX support ## What is the purpose of the change This PR propose to add HEX in table api and sql, the syntax like mysql, which could take int or st

[GitHub] flink pull request #6282: [FLINK-6847][FLINK-6813][Table Api & Sql] Timestam...

GitHub user xueyumusic opened a pull request: https://github.com/apache/flink/pull/6282 [FLINK-6847][FLINK-6813][Table Api & Sql] TimestampDiff table api and sql support ## What is the purpose of the change This PR propose to add TimestampDiff sql and table Api.

[GitHub] flink issue #6188: [FLINK-6846][Table API] add timestampAdd tableApi

Github user xueyumusic commented on the issue: https://github.com/apache/flink/pull/6188 @twalthr I looked around and realized that current `+` expression could support TimeInterval (TimePoint) addition, thus the timestampAdd api is duplicated and seems have no necessary

[GitHub] flink issue #6204: [FLINK-4301][docs] add version for quickstart script

Github user xueyumusic commented on the issue: https://github.com/apache/flink/pull/6204 Thank you for review, @tillrohrmann , it may also need to modify the `quickstart.sh` script which is in another flink-web git project, so I opened another PR at https://github.com/apache/flink

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

Github user xueyumusic commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r199040249 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala --- @@ -1029,6 +1029,29 @@ object

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

Github user xueyumusic commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197674277 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -349,6 +349,17 @@ case class TimestampAdd

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

Github user xueyumusic commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197642129 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,71 @@ case class TemporalOverlaps

[GitHub] flink issue #6188: [FLINK-6846][Table API] add timestampAdd tableApi

Github user xueyumusic commented on the issue: https://github.com/apache/flink/pull/6188 Thanks very much for your reivew and guidance, @walterddr @hequn8128 , I have made some modification, please have a review when you are free, thanks! ---

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

Github user xueyumusic commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r197616443 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -328,6 +330,42 @@ case class TemporalOverlaps

[GitHub] flink issue #6188: [FLINK-6846][Table API] add timestampAdd tableApi

Github user xueyumusic commented on the issue: https://github.com/apache/flink/pull/6188 The first time to submit pr and could someone review it and give some advice, thanks :) ---

[GitHub] flink pull request #6204: [FLINK-4301][docs] add version for quickstart scri...

GitHub user xueyumusic opened a pull request: https://github.com/apache/flink/pull/6204 [FLINK-4301][docs] add version for quickstart script ## What is the purpose of the change This PR add version for quickstart script in the doc ## Brief change log one-line

[GitHub] flink issue #6188: [FLINK-6846][Table API] add timestampAdd tableApi

Github user xueyumusic commented on the issue: https://github.com/apache/flink/pull/6188 Travis error is "The job exceeded the maximum time limit for jobs, and has been terminated". It seems connector module test and not related to this PR. ---

[GitHub] flink pull request #6188: [FLINK-6846] add timestampAdd tableApi

GitHub user xueyumusic opened a pull request: https://github.com/apache/flink/pull/6188 [FLINK-6846] add timestampAdd tableApi ## What is the purpose of the change This PR add timestampAdd TableApi ## Brief change log add timestampAdd expression parser