Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6231
PR #6392 fixed this issue.
---
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/6231
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6392
+1, I will close my PR #6231 about this issue
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6396
hi @patricklucas thanks for your contribution, this PR contains two
commits, is the "hotfix" commit related to FLINK-9806? if not, I suggest split
the commit into a single PR.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6401
hi @rileyli Thanks for your contribution, but I think just refactor the
naming style is not very necessary and it is not "typo". cc @zentol
@tillrohrmann
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6367
cc @dawidwys and @pnowojski
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6397
cc @twalthr and @fhueske
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6404
[FLINK-9928] Add LOG2 function for table/sql API
## What is the purpose of the change
*This pull request adds LOG2 function for table/sql API*
## Brief change log
- *Add
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6231
@pnowojski thanks for giving a solution, I will try to verify it in our
inner Flink version.
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6397
[FLINK-9916] Add FROM_BASE64 function for table/sql API
## What is the purpose of the change
*This pull request adds FROM_BASE64 function for table/sql API*
## Brief change log
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6390
cc @twalthr @hequn8128 @fhueske
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6381
+1
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6382#discussion_r204369826
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
---
@@ -2063,6 +2063,22 @@ class
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6231
@pnowojski I have said it is because of the constructor :
```
CompositeTypeSerializerConfigSnapshot(TypeSerializer...
nestedSerializers)
```
used [`varargs ` in JIRA
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6390
[FLINK-9915] Add TO_BASE64 function for table/sql API
## What is the purpose of the change
*This pull request add TO_BASE64 function for table/sql API*
## Brief change log
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6353
agree @StephanEwen , parallelize the core problem, this way we would not
introduce potential concurrent problem of EG, EJV related logic.
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6375#discussion_r203996832
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -722,9
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6362
+1
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6374
+1
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6370
@tison1 I think PR #6353 and #6370 has causal relationship, the current
codebase may not trigger this race condition, right?
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6372#discussion_r203692186
--- Diff: flink-end-to-end-tests/README.md ---
@@ -31,6 +31,12 @@ You can also run tests individually via
$ FLINK_DIR= flink-end-to-end-tests/run-single
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6373
+1
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6231
hi @pnowojski I did not call the
`CompositeTypeSerializerConfigSnapshot(TypeSerializer... nestedSerializers)`
constructor explicitly, the caller is Flink itself, see
[here](https://github.com
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6365
seems `org.glassfish:javax.el:jar 3.0.1` has a non-SNAPSHOT version in
maven repository, see here :
https://mvnrepository.com/artifact/org.glassfish/javax.el/3.0.1-b10, Do you use
a inner maven
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6353
@tison1 there are too many commits, you can use `git rebase -i [commit-id]`
to squash them, then use `git push -f xxx xxx` to force update the PR.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6367
@hequn8128 thanks, I have added some test case~
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6365#discussion_r203439890
--- Diff:
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java
---
@@ -87,22 +90,22 @@ public void
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6365#discussion_r203440989
--- Diff:
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java
---
@@ -87,22 +90,22 @@ public void
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6365#discussion_r203438579
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -81,7 +85,9 @@ private HTable createTable
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6365#discussion_r203439523
--- Diff:
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java
---
@@ -87,22 +90,22 @@ public void
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6365#discussion_r203439859
--- Diff:
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java
---
@@ -87,22 +90,22 @@ public void
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6367
@tillrohrmann and @zentol I see the Python DataStream API methods do not
match DataStream Java API methods (missed some API methods), Shall we add those
missed API into `PythonDataStream`? If yes
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6367
[FLINK-9850] Add a string to the print method to identify output for
DataStream
## What is the purpose of the change
*This pull request adds a string to the print method to identify output
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6329
@zentol this PR match your requirement? I hope it can be merged into 1.6,
so that users can see the full taskmanager log.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6334
@tillrohrmann and @zentol opinion?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6358
+1,
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6359#discussion_r203265891
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/StrToDateCallGen.scala
---
@@ -0,0 +1,45
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6353
you are right, this PR used to improve the performance when creating ejv, I
did not make sure the exist test cases for `attachJobGraph ` covered the
exception test. if not, I suggest add some
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6297
@dawidwys added test case, please review~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6347
+1 from myside, it depends on @zentol or @tillrohrmann 's opinion.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6347
it seems Flink also uses "vertices", I agree your opinion.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6347
my English is poor, but it seems "vertexes" is one of the vertex
pluralities? cc @zentol @tison1
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6344#discussion_r202895544
--- Diff: flink-container/kubernetes/README.md ---
@@ -17,6 +17,7 @@ The files contain the following variables:
- `${FLINK_IMAGE_NAME}`: Name
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6266
@zentol can you review this PR? so that I can start the part 2 of the task
as soon as possible. thanks.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6337
+1, from my side
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6336
@ubyyj you can use this command to trigger Travis rebuild :
```
git commit --allow-empty -m ""
```
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6337#discussion_r202573057
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -182,4 +184,6 @@ object
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6337#discussion_r202572746
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -400,6 +400,12 @@ trait
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6329
@dawidwys can you review this PR?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6334
hi @tillrohrmann I tried to fix this issue based on your suggestion in the
jira. But there seems a little question, I want to consult you.
The question is about the ActorSystem, you
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6334
[FLINK-5232] Add a Thread default uncaught exception handler on the
JobManager
## What is the purpose of the change
*This pull request Add a Thread default uncaught exception handler
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6328#discussion_r202506769
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ---
@@ -163,80 +163,157 @@ public static void
setSSLVerifyHostname
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6328#discussion_r202506820
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ---
@@ -163,80 +163,157 @@ public static void
setSSLVerifyHostname
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6328#discussion_r202505334
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ---
@@ -249,14 +326,40 @@ public static SSLContext
createSSLServerContext
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6328#discussion_r202506868
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ---
@@ -163,80 +163,157 @@ public static void
setSSLVerifyHostname
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6328#discussion_r202506811
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ---
@@ -163,80 +163,157 @@ public static void
setSSLVerifyHostname
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6328#discussion_r202506709
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ---
@@ -163,80 +163,157 @@ public static void
setSSLVerifyHostname
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6328#discussion_r202506694
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ---
@@ -249,14 +326,40 @@ public static SSLContext
createSSLServerContext
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6328#discussion_r202505321
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyClientServerSslTest.java
---
@@ -160,6 +160,7 @@ private Configuration
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202381490
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -500,11 +501,11 @@ protected Configuration
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6329
@zentol yes, you are right, sorry about my expression. here we should not
use try-with-resource, because the listener will close the file. And it seems
try-with-resource close operation more faster
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6329
[FLINK-9841] Web UI only show partial taskmanager log
## What is the purpose of the change
*This pull request fixed a bug triggered web UI only show partial
taskmanager log
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/5954
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5954
OK, closing this PR...
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202075216
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202071052
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6307
+1
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6322#discussion_r202013852
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1759,11 +1759,22 @@ class JobManager(
case
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6266
hi @tillrohrmann I have split the original issue into two issues, this PR
for the first backend issue, the second issue will depend on this PR, please
review~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5954
@tillrohrmann That's all right. I know you are very busy. Just a little
question, I have reviewed PR(#6202). I saw it used `Exception`, and there is a
suggestion from Stephan in May 7
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r201997596
--- Diff: docs/ops/deployment/yarn_setup.md ---
@@ -101,12 +101,12 @@ Usage:
Optional
-D Dynamic properties
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r201997464
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6129
@tillrohrmann this PR could be merged
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6305#discussion_r201907959
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java
---
@@ -871,19 +892,40 @@ public IntType
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6305#discussion_r201908022
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java
---
@@ -871,19 +892,40 @@ public IntType
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6305#discussion_r201908226
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/LocalRecoveryITCase.java
---
@@ -25,35 +25,46 @@
import org.junit.Rule
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6305#discussion_r201908082
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java
---
@@ -871,19 +892,40 @@ public IntType
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6301
@sihuazhou is right and reviewed, +1 from my side
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6231
@zentol we really caused this exception, in our inner Flink version, we
customized flink-table and implemented stream and dim table join. I think the
default constructor is needed by deserialization
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6297
@zentol can you review this?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6298
+1, from my side
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6301#discussion_r201558827
--- Diff:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -41,6 +43,8 @@
public class
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6296
@linjun007 please rename the PR title
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6301#discussion_r201552317
--- Diff:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -41,6 +43,8 @@
public class
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6301#discussion_r201551945
--- Diff:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -54,6 +58,10 @@
private
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6301#discussion_r201551369
--- Diff:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCAppendTableSinkBuilder.java
---
@@ -115,6 +119,16 @@ public
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6301#discussion_r201551339
--- Diff:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCAppendTableSinkBuilder.java
---
@@ -115,6 +119,16 @@ public
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6297
@GJL please review~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6296
@linjun007 thanks for your contribution, please rename the PR's title based
on this description :
```
Name the pull request in the form "[FLINK-] [component] Title of the
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6297
[FLINK-9777] YARN: JM and TM Memory must be specified with Units
## What is the purpose of the change
*This pull request specify unit for JM and TM memory on YARN mode
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6292#discussion_r201313023
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/util/InterceptingTaskMetricGroup.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6284
find related test error, please recheck~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6285
+1
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6286
+1
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6231
@pnowojski can you review this?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6290
+1, from my side~
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6291#discussion_r201303678
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
---
@@ -167,7 +167,8
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6291#discussion_r201304267
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandler.java
---
@@ -164,7 +164,9 @@ public void
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6277#discussion_r201264096
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfiguration.java
---
@@ -93,4 +97,82 @@ public Time getTtl
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6277#discussion_r201229057
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfiguration.java
---
@@ -93,4 +97,82 @@ public Time getTtl
1 - 100 of 473 matches
Mail list logo
