[GitHub] flink issue #6180: [FLINK-9524][Table API & SQL] check whether a clean-up ti...

2018-06-25 Thread yzandrew
Github user yzandrew commented on the issue:

https://github.com/apache/flink/pull/6180
  
Hi,
I have updated the pull request based on your comments. In order to have 
fewer lines of changes, I squashed the commits.  


---


[GitHub] flink pull request #6180: [FLINK-9524][Table API & SQL] check whether a clea...

2018-06-18 Thread yzandrew
GitHub user yzandrew opened a pull request:

https://github.com/apache/flink/pull/6180

[FLINK-9524][Table API & SQL] check whether a clean-up timer is expeired in 
ProcTimeBoundedRangeOver…

… to prevent NPE

## What is the purpose of the change
This pull request solve the bug that causes NPE in 
ProcTimeBoundedRangeOver. Now the onTimer method will check whether the timer 
is a expired clean-up timer.

## Brief change log
- ProcTimeBoundedRangeOver check whether the timer is a expired clean-up 
timer. It's done by a null check against the elements within rowMapState. If 
it's null, it means the timer is an expired clean-up timer and bypass the 
remained logic. 


## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:
  - Dependencies (does it add or upgrade a dependency): no
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
  - The serializers: no
  - The runtime per-record code paths (performance sensitive): no
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  - The S3 file system connector: no

## Documentation
  - Does this pull request introduce a new feature? no
  - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yzandrew/flink master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/6180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6180


commit 719bdebf6bdb0e3e3f9aa0acd0bb98040a259a59
Author: yan.zhou 
Date:   2018-06-18T18:42:29Z

[FLINK-9524] check whether a clean-up timer is expeired in 
ProcTimeBoundedRangeOver to prevent NPE




---