[GitHub] [flink] walterddr commented on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate

2019-10-09 Thread GitBox
walterddr commented on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8468#issuecomment-540030581 Hi @KurtYoung any additional comments on this? please kindly let me know if there's

[GitHub] [flink] walterddr commented on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate

2019-09-30 Thread GitBox
walterddr commented on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8468#issuecomment-536859787 @KurtYoung sorry for the delay. I just implemented a way to safe check to prevent

[GitHub] [flink] walterddr commented on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate

2019-09-18 Thread GitBox
walterddr commented on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8468#issuecomment-532740413 Thanks for the explanation @KurtYoung. NOW I think I understood what you meant. yeah

[GitHub] [flink] walterddr commented on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate

2019-09-16 Thread GitBox
walterddr commented on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8468#issuecomment-531871165 @KurtYoung can you help take another look on the approach? thanks