[GitHub] [flink] zjuwangg commented on issue #9337: [FLINK-13475][hive]Reduce dependency on third-party maven repositories

2019-08-05 Thread GitBox
zjuwangg commented on issue #9337: [FLINK-13475][hive]Reduce dependency on 
third-party maven repositories
URL: https://github.com/apache/flink/pull/9337#issuecomment-518115991
 
 
   @bowenli86 @wuchong @xuefuz 
   Could you have a review when you have time?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] zjuwangg commented on issue #9337: [FLINK-13475][hive]Reduce dependency on third-party maven repositories

2019-08-02 Thread GitBox
zjuwangg commented on issue #9337: [FLINK-13475][hive]Reduce dependency on 
third-party maven repositories
URL: https://github.com/apache/flink/pull/9337#issuecomment-517874350
 
 
   > @zjuwangg Thanks for working on this. PR LGTM, but please make sure it 
doesn't break any test for Hive-1.2.1 as well.
   > BTW, how about the jms dependencies? Is it possible to avoid that too?
   
   Yep, I tested with profile hive-1.2.1 in my box and remove the jms 
dependency in the lastest commit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] zjuwangg commented on issue #9337: [FLINK-13475][hive]Reduce dependency on third-party maven repositories

2019-08-02 Thread GitBox
zjuwangg commented on issue #9337: [FLINK-13475][hive]Reduce dependency on 
third-party maven repositories
URL: https://github.com/apache/flink/pull/9337#issuecomment-517624426
 
 
   cc @lirui-apache @xuefuz to review.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services