[GitHub] flink issue #1849: [FLINK-2157] [ml] Create evaluation framework for ML libr...
Github user gaborhermann commented on the issue: https://github.com/apache/flink/pull/1849 Great. I agree this PR should be merged before #2838. @skonto thanks for taking up the review :) This is indeed a bit blocking. Hopefully I can improve upon #2838 next week, so by the time you get there, the PR could be ready (i.e. not in a WIP state). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #1849: [FLINK-2157] [ml] Create evaluation framework for ML libr...
Github user skonto commented on the issue: https://github.com/apache/flink/pull/1849 Hi guys, my intention was to review #2838 but my feeling is that it overlaps with this one. @thvasilo we can push this one first as you said so I will have a look at it and comment on it. The benefit is unblocking other tasks in this area. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #1849: [FLINK-2157] [ml] Create evaluation framework for ML libr...
Github user thvasilo commented on the issue: https://github.com/apache/flink/pull/1849 Hello @gaborhermann. Personally I prefer to have PRs be as specific as possible, so I would recommend we try to get this merged before #2838, and then rebase that on master. Given the committer load however this could take a while. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #1849: [FLINK-2157] [ml] Create evaluation framework for ML libr...
Github user gaborhermann commented on the issue: https://github.com/apache/flink/pull/1849 Hi @skonto, I did not have time lately to finish up #2838, but I could clean it up next week. Although I believe this PR could be merged separately from mine. (Evaluating ranking recommendations is a bit more complicated.) As @thvasilo mentioned, the documentation is missing in his PR, but most of the work is already in place here. I could easily rebase my PR on top of this, if you don't modify much in the structure of classes. @thvasilo what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #1849: [FLINK-2157] [ml] Create evaluation framework for ML libr...
Github user skonto commented on the issue: https://github.com/apache/flink/pull/1849 @thvasilo thnx I will have a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #1849: [FLINK-2157] [ml] Create evaluation framework for ML libr...
Github user thvasilo commented on the issue: https://github.com/apache/flink/pull/1849 Hello @skonto this PR will probably be subsumed by #2838, you can check out the latest development there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #1849: [FLINK-2157] [ml] Create evaluation framework for ML libr...
Github user skonto commented on the issue: https://github.com/apache/flink/pull/1849 Hey @thvasilo is this under development? From what I see many other tasks depend on it right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #1849: [FLINK-2157] [ml] Create evaluation framework for ML libr...
Github user thvasilo commented on the issue: https://github.com/apache/flink/pull/1849 @gaborhermann In terms of missing features, documentation is definitely missing, as @rawkintrevo mentioned. For the issues mentioned in the JIRA issue you linked I've replied on the dev list thread you started, all valid points re. adjusting this to handle recommendations. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #1849: [FLINK-2157] [ml] Create evaluation framework for ML libr...
Github user gaborhermann commented on the issue: https://github.com/apache/flink/pull/1849 Hi all, What is the status of this PR? It would be relevant for us, because we might like to use the evaluation framework proposed here. See [FLINK-4713](https://issues.apache.org/jira/browse/FLINK-4713) for details. Can I do anything to help resolving the issues you've been discussing here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
