[GitHub] flink issue #2541: [FLINK-4669] scala api createLocalEnvironment() function ...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2541 Thanks, picking this pull request up and merging it... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2541: [FLINK-4669] scala api createLocalEnvironment() function ...
Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2541 @StephanEwen review it again please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2541: [FLINK-4669] scala api createLocalEnvironment() function ...
Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2541 > In general, I think it is good to not have too many method options, but only those that add significant functionality. For the method that starts the WebUI, that is the case, for the method with the additional parallelism, probably not. Function having least parameters is the best style. If have no enough parameter for user, the function's ability is limited. That's why I prefer Scala, as it has default parameter value, keep the both. > The other Java code uses the primitive int everywhere, rather than the boxed integer. Let's follow that style. Good idea. In the latest two years, I only wirte scala and give up Java entirely so that not sensitive to Java. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2541: [FLINK-4669] scala api createLocalEnvironment() function ...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2541 Sorry for asking for another iteration, but here are some comments: - The other Java code uses the primitive `int` everywhere, rather than the boxed integer. Let's follow that style. - I would omit the `public static ExecutionEnvironment createCustomLocalEnv(Integer parallelism, Configuration config)` variant. The benefit is very small compared to the `public static ExecutionEnvironment createLocalEnvironment(Configuration config)` method, but it blows up the API into too many variants. - Similarly, I would only have the `public static ExecutionEnvironment createLocalEnvWithWebUI (int port, Configuration config)` and drop the variant with the additional `parallelism` parameter. In general, I think it is good to not have too many method options, but only those that add significant functionality. For the method that starts the WebUI, that is the case, for the method with the additional parallelism, probably not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2541: [FLINK-4669] scala api createLocalEnvironment() function ...
Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2541 @StephanEwen have any improvement needed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2541: [FLINK-4669] scala api createLocalEnvironment() function ...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2541 Okay, this has binary compatibility now. Few things I would still suggest to do: - There is still a bug that the `parallelism` and `port` parameter are mixed up. - It still does not use the DEFAULT_LOCAL_PARALLELISM. - The same methods should exist in all environments (batch / streaming / Java / Scala) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2541: [FLINK-4669] scala api createLocalEnvironment() function ...
Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2541 @StephanEwen Iâve a new function name `createCustomLocalEnv`. Sorry for late ack. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2541: [FLINK-4669] scala api createLocalEnvironment() function ...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2541 Code looks good, but the build detected a break in binary compatibility. Have a look at the Travis logs. Changing the `createLocalEnvironment` to use an additional parameter with default value broke the compatibility. The fix would be to have an extra method (and no default parameter value), not change the existing method. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
