[GitHub] flink issue #5214: [FLINK-8324] [kafka] Expose another offsets metrics by us...

2018-01-10 Thread tzulitai 
Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/5214
  
Thanks for the PR @tony810430. The changes LGTM, will merge this a bit 
later.


---

[GitHub] flink issue #5214: [FLINK-8324] [kafka] Expose another offsets metrics by us...

2018-01-10 Thread tony810430 
Github user tony810430 commented on the issue:

https://github.com/apache/flink/pull/5214
  
@tzulitai Have updated the metrics doc.


---

[GitHub] flink issue #5214: [FLINK-8324] [kafka] Expose another offsets metrics by us...

2018-01-09 Thread tzulitai 
Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/5214
  
Good idea. I think we should also update the metrics doc to educate this 
addition.


---