Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/6040
Using `CheckedThread` is more preferable, as it simplifies some of the test
code.
But yes, the utility was introduced at a later point in time in Flink, so
some parts of the test code might
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6040
@tzulitai thank you for your review and comments
based on your comments I have a question. Could you please clarify it?
You mentioned Flink's `OneShotLatch ` and `CheckedThread ` at the
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/6040
@snuyanzin the failing `YARNSessionCapacitySchedulerITCase` is known to be
bit flaky, so you can safely ignore that for now. I'll take another look at
your changes soon. Thanks!
---
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6040
@tzulitai, @tedyu thnk you for your review, comments and contribution tips
I did updates which includes moving test into AbstractFetcherTest and
making it kafka connector version independent
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/6040
Thanks for the PR @snuyanzin!
I had some comments, please let me know what you think.
Also, some general contribution tips:
1. I would suggest the title of the PR to be something
