Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/305
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/305#issuecomment-70424921
Maybe we should offer users both options: register and default serializer.
In some cases, you don't know the exact types and you want to go for a
default serializer.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/305#issuecomment-70424146
The registration at Kryo seems to be a bit incomplete. Adding a default
serializer does not to type/tag registration, which is very much desirable.
Also, it registers
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/305#issuecomment-70422236
I do not see how this can possibly work on a cluster... Everything is in
static variables (in the client) that do not get transferred via serialization
when moving the
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/305#issuecomment-70416371
This would do it for now. However, the use of static variables to
communicate between components is an antipattern and one that has caused
problems before. I would lik
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/305#issuecomment-70065763
I added register methods at the ExecutionEnvironment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/305#issuecomment-69902764
I think its more important to have a smooth user experience.
The ExecutionEnvironment is not used anywhere else, kryo is already a
dependency of "flink-java", so I don
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/305#issuecomment-69897430
But I also see that option 2 is more discoverable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/305#issuecomment-69897397
The reason I don't like option 2 is that it introduces knowledge about Kryo
at the ExecutionEnvironment while it is right now agnostic of types and
serialisers.
---
If
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/305#issuecomment-69896334
I agree with @rmetzger, but I can see why @aljoscha likes the first
suggestion more ;)
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/305#issuecomment-69896090
The second option (env) is probably better because people will see the
method when their IDE suggests method names.
---
If your project is set up for it, you can reply t
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/305#issuecomment-69759167
Right now, what a user does is:
```
KryoSerializer.addDefaultSerializer(..., ...)
```
I like this better, and would also change my Pojo Subclass Serial
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/305
[FLINK-1399] Add support for registering Serializers with Kryo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink kryo-register-seri
13 matches
Mail list logo
