[GitHub] flink pull request: [FLINK-1654] Wrong scala example of POJO type ...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/478 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1654] Wrong scala example of POJO type ...
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/478#issuecomment-78308404 Thanks for the fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1654] Wrong scala example of POJO type ...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/478#issuecomment-78226428 Curious why this works. We should merge this pull request anyways, because it shows the recommended way to do things. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1654] Wrong scala example of POJO type ...
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/478#issuecomment-78228121 As I wrote in JIRA, Fields of Scala class (not case class) are private. ([Reference](http://stackoverflow.com/questions/1589603/scala-set-a-field-value-reflectively-from-field-name)) Because fields declared by `val` keyword don't have setter, Flink TypeExtractor fails to extract information of POJO example in documentation. I attached a result of sample type extraction in [JIRA](https://issues.apache.org/jira/browse/FLINK-1654?focusedCommentId=14348124page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14348124). Flink TypeExtractor deals with Scala case class differently. Case classes are dealt like Scala tuple. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1654] Wrong scala example of POJO type ...
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/478#issuecomment-78229903 Then I guess that the Scala API does not identify the ```WordWithCount``` as a POJO but as something different. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1654] Wrong scala example of POJO type ...
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/478#issuecomment-78230090 Maybe it is treated as a ```GenericType``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1654] Wrong scala example of POJO type ...
GitHub user chiwanpark opened a pull request: https://github.com/apache/flink/pull/478 [FLINK-1654] Wrong scala example of POJO type in documentation More detail description and discussion in [JIRA](https://issues.apache.org/jira/browse/FLINK-1654). You can merge this pull request into a Git repository by running: $ git pull https://github.com/chiwanpark/flink FLINK-1654 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/478.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #478 commit 398f77facd5aeb357a3e5e7825da60eca65e9435 Author: Chiwan Park chiwanp...@icloud.com Date: 2015-03-11T01:40:17Z [FLINK-1654] [docs] Fix scala example in programming guide --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
