[GitHub] flink pull request: [FLINK-2175] Allow multiple jobs in single jar...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/707#issuecomment-117550563 I'm going to rebase, test and merge this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2175] Allow multiple jobs in single jar...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2175] Allow multiple jobs in single jar...
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/707#issuecomment-114409476 Travis failed in flink-tachyon (what happens regularly). My travis passed https://travis-ci.org/mjsax/flink/builds/67863816 Should be ready to get merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2175] Allow multiple jobs in single jar...
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/707#issuecomment-114165604 +1 for adding this, looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2175] Allow multiple jobs in single jar...
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/707#issuecomment-113846141 I would like to merge the change. It doesn't break anything existing and could be helpful for our users. Since you probably have to update the PR for the examples anyways, could you also quickly mention the feature in the documentation somewhere? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2175] Allow multiple jobs in single jar...
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/707#discussion_r32889524 --- Diff: flink-examples/flink-java-examples/pom.xml --- @@ -319,7 +319,32 @@ under the License. /includes /configuration /execution - + --- End diff -- This will produce another jar file in the `examples/` directory, right? If so, I'm against this because its very hard for beginners to understand the purpose of this example. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2175] Allow multiple jobs in single jar...
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/707#issuecomment-111755732 Any news on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2175] Allow multiple jobs in single jar...
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/707#issuecomment-109447546 My Travis is green (https://travis-ci.org/mjsax/flink/builds/65609726). From my point of view, this PR can be merged. Let me know if you request any changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
