[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

[aljoscha]

Github user aljoscha closed the pull request at:

https://github.com/apache/flink/pull/1645


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

[aljoscha]

Github user aljoscha commented on the pull request:

https://github.com/apache/flink/pull/1645#issuecomment-185132226
  
Manually merged 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

[aljoscha]

Github user aljoscha commented on the pull request:

https://github.com/apache/flink/pull/1645#issuecomment-185126063
  
@uce Yes, they could also be moved to separate pages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

[uce]

Github user uce commented on a diff in the pull request:

https://github.com/apache/flink/pull/1645#discussion_r53139307
  
--- Diff: docs/apis/common/index.md ---
@@ -0,0 +1,1356 @@
+---
+title: "Basic Concepts"
+
+# Top-level navigation
+top-nav-group: apis
+top-nav-pos: 1
+top-nav-title: Basic Concepts
+
+# Sub-level navigation
+sub-nav-group: common
--- End diff --

Maybe we can comment these lines out, because this is currently just a 
single page. It shows a navigation at the left side with only one element. Or 
do you think that we will add sub pages soon?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

[aljoscha]

Github user aljoscha commented on a diff in the pull request:

https://github.com/apache/flink/pull/1645#discussion_r53139897
  
--- Diff: docs/apis/common/index.md ---
@@ -0,0 +1,1356 @@
+---
+title: "Basic Concepts"
+
+# Top-level navigation
+top-nav-group: apis
+top-nav-pos: 1
+top-nav-title: Basic Concepts
+
+# Sub-level navigation
+sub-nav-group: common
--- End diff --

Yes, I didn't know this was possible. :dancer: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

[uce]

Github user uce commented on the pull request:

https://github.com/apache/flink/pull/1645#issuecomment-185116660
  
Looks great! +1 to merge asap.

As follow ups we should consider making windowing and working with state 
also separate pages. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

[StephanEwen]

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1645#issuecomment-184876499
  
+1

I like this to get the redundancy out of the batch and streaming guides.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

[aljoscha]

GitHub user aljoscha opened a pull request:

https://github.com/apache/flink/pull/1645

Refactor Common Parts of Stream/Batch Documentation

The main bit is the refactoring, I also added a basic RocksDB documentation 
and created a new "Working with Time" section for the streaming guide.

I put this on top of my TimeCharacteristic pull request because I already 
had some doc changes there with regards to time and time characteristic.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aljoscha/flink doc-refactor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1645.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1645


commit dba30ffec81b42b5fb962ad15f95f13341373c5c
Author: Aljoscha Krettek 
Date:   2016-01-15T16:05:12Z

[FLINK-3243] Fix Interplay of TimeCharacteristic and Time Windows

This adds dedicated WindowAssigners for processing time and event time.
timeWindow() and timeWindowAll() respect the TimeCharacteristic set
on the StreamExecutionEnvironment.

This will make the easy stuff easy, i.e. using time windows and quickly
switching the time characteristic. Users will then have the flexibility
to mix different kinds of window assigners in their job.

This also expands the translation tests to verify that the correct
window operators are instantiated.

commit cdf976c6125b3370386b13aa751eabb80d9c4ff4
Author: Aljoscha Krettek 
Date:   2016-02-15T18:30:55Z

[FLINK-3403] Create Section "Working with Time" in Streaming Guide

commit bf837e815252c49869d0a10c80bbfaf7dc866914
Author: Aljoscha Krettek 
Date:   2016-02-16T13:19:51Z

[FLINK-3402] Refactor Common Parts of Stream/Batch Documentation

commit ba782733869b82a62bdc5b3404ad51878b468048
Author: Aljoscha Krettek 
Date:   2016-02-16T16:39:57Z

Add (basic) RocksDB State Backend Documentation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---