[GitHub] flink pull request #6073: [FLINK-9091] [table] Fix dependency convergence fo...

[twalthr]

Github user twalthr closed the pull request at:

https://github.com/apache/flink/pull/6073


---

[GitHub] flink pull request #6073: [FLINK-9091] [table] Fix dependency convergence fo...

[zentol]

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/6073#discussion_r191207284
  
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -146,6 +147,12 @@ under the License.

flink-test-utils_${scala.binary.version}
${project.version}
test
+   
--- End diff --

flink-test-utils depends on curator-test which depends on guava.


---

[GitHub] flink pull request #6073: [FLINK-9091] [table] Fix dependency convergence fo...

[StephanEwen]

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/6073#discussion_r190855869
  
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -146,6 +147,12 @@ under the License.

flink-test-utils_${scala.binary.version}
${project.version}
test
+   
--- End diff --

Why does `flink-test-utils` even have a Guava dependency? Can we fix that?


---

[GitHub] flink pull request #6073: [FLINK-9091] [table] Fix dependency convergence fo...

[twalthr]

GitHub user twalthr opened a pull request:

https://github.com/apache/flink/pull/6073

[FLINK-9091] [table] Fix dependency convergence for flink-table

## What is the purpose of the change

Since FLINK-8511 solved most of the dependency convergence issues that were 
described in FLINK-9091. This PR solves the remaining ones by replacing the 
`dependencyManagement` section by exclusions.


## Brief change log

`flink-table/pom.xml` modified


## Verifying this change

Manually verified by e2e tests and SQL Client query execution.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): yes
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
  - The serializers: no
  - The runtime per-record code paths (performance sensitive): no
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  - The S3 file system connector: no

## Documentation

  - Does this pull request introduce a new feature? no
  - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twalthr/flink FLINK-9091

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/6073.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6073


commit 639df7cd3e690c2dcfaf35fb43d6b02ec48451f4
Author: Timo Walther 
Date:   2018-05-18T10:10:14Z

[FLINK-9091] [table] Fix dependency convergence for flink-table




---