[GitHub] flink pull request #6298: [FLINK-9784] Fix inconsistent use of 'static' in A...

2018-07-12 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/6298


---


[GitHub] flink pull request #6298: [FLINK-9784] Fix inconsistent use of 'static' in A...

2018-07-10 Thread nekrassov
GitHub user nekrassov opened a pull request:

https://github.com/apache/flink/pull/6298

[FLINK-9784] Fix inconsistent use of 'static' in AsyncIOExample.java

## What is the purpose of the change

This patch fixes inconsistent use of `static` in AsyncIOExample.java that 
can lead to incorrect code execution.

## Brief change log

Changed `executorService` and `random` from static to instance-specific, 
removed no longer needed `counter`, and removed synchronization on class that's 
no longer needed either.

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  - The S3 file system connector: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nekrassov/flink FLINK-9784

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/6298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6298


commit 3b316e3046c3f6377b92541b30d70748afa4e0bc
Author: an4828 
Date:   2018-07-10T14:59:35Z

[FLINK-9784] Fix inconsistent use of 'static' in AsyncIOExample.java




---