[jira] [Commented] (FLINK-13610) Refactor HiveTableSource Test use sql query and remove HiveInputFormatTest

2019-08-07 Thread Kurt Young (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902078#comment-16902078
 ] 

Kurt Young commented on FLINK-13610:


Thanks for working on this [~Terry1897], I will assign this issue to you.

> Refactor HiveTableSource Test use sql query and remove HiveInputFormatTest
> --
>
> Key: FLINK-13610
> URL: https://issues.apache.org/jira/browse/FLINK-13610
> Project: Flink
>  Issue Type: Test
>  Components: Connectors / Hive
>Affects Versions: 1.10.0
>Reporter: Terry Wang
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Since HiveTableSource is mainly used in sql query and now blink planner 
> support run sql query, it's time that we change HiveTableSourceTest using sql 
> way instead of table api.
> HiveTableInputFormt is tested in HiveTableSourceTest and there exists 
> redundancy in code,  this ticket also aims to move some test code from 
> HiveInputFormatTest and remove this file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (FLINK-13610) Refactor HiveTableSource Test use sql query and remove HiveInputFormatTest

2019-08-07 Thread Terry Wang (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901930#comment-16901930
 ] 

Terry Wang commented on FLINK-13610:


I am working on refactoring this test and are preparing pull requests.

It's very grateful if you can  assign this tickets to me :) [~yangkuntime] or 
[~jark]

> Refactor HiveTableSource Test use sql query and remove HiveInputFormatTest
> --
>
> Key: FLINK-13610
> URL: https://issues.apache.org/jira/browse/FLINK-13610
> Project: Flink
>  Issue Type: Test
>  Components: Connectors / Hive
>Affects Versions: 1.10.0
>Reporter: Terry Wang
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Since HiveTableSource is mainly used in sql query and now blink planner 
> support run sql query, it's time that we change HiveTableSourceTest using sql 
> way instead of table api.
> HiveTableInputFormt is tested in HiveTableSourceTest and there exists 
> redundancy in code,  this ticket also aims to move some test code from 
> HiveInputFormatTest and remove this file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)