[jira] [Commented] (FLINK-13995) Fix shading of the licence information of netty

2019-11-25 Thread Chesnay Schepler (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-13995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981412#comment-16981412
 ] 

Chesnay Schepler commented on FLINK-13995:
--

I wouldn't say that it is a blocker; a missing license would be. Shipping a 
license which doesn't apply, provided that they are no negative consequences, 
is fine.

That said, a PR is already open and pretty trivial to review, so there isn't 
really a reason to not include it in the release.

> Fix shading of the licence information of netty
> ---
>
> Key: FLINK-13995
> URL: https://issues.apache.org/jira/browse/FLINK-13995
> Project: Flink
>  Issue Type: Bug
>  Components: BuildSystem / Shaded
>Affects Versions: 1.8.0
>Reporter: Arvid Heise
>Assignee: Chesnay Schepler
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.10.0, 1.8.3, 1.9.2
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The license filter isn't actually filtering anything. It should be 
> META-INF/license/**.
> The first filter seems to be outdated btw.
> Multiple modules affected.
> {code:xml}
> 
>   io.netty:netty
>   
>   META-INF/maven/io.netty/**
>   
>   META-INF/license
>   
>   META-INF/NOTICE.txt
>   
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-13995) Fix shading of the licence information of netty

2019-11-24 Thread Hequn Cheng (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-13995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981282#comment-16981282
 ] 

Hequn Cheng commented on FLINK-13995:
-

[~chesnay] Hi, as legal problems are always important, so I think this is also 
a blocker for 1.8.3? 

> Fix shading of the licence information of netty
> ---
>
> Key: FLINK-13995
> URL: https://issues.apache.org/jira/browse/FLINK-13995
> Project: Flink
>  Issue Type: Bug
>  Components: BuildSystem / Shaded
>Affects Versions: 1.8.0
>Reporter: Arvid Heise
>Assignee: Chesnay Schepler
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.10.0, 1.8.3, 1.9.2
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The license filter isn't actually filtering anything. It should be 
> META-INF/license/**.
> The first filter seems to be outdated btw.
> Multiple modules affected.
> {code:xml}
> 
>   io.netty:netty
>   
>   META-INF/maven/io.netty/**
>   
>   META-INF/license
>   
>   META-INF/NOTICE.txt
>   
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)