[jira] [Commented] (FLINK-1407) Enable log output (error level) for test cases
[ https://issues.apache.org/jira/browse/FLINK-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280295#comment-14280295 ] Stephan Ewen commented on FLINK-1407: - Does it make sense to: - disable logging for classes that only log exceptions (without reacting), like the ExecutionEnvironment? - enable logging for critical classes that react to exceptions (like runtime.executiongraph.*) ? > Enable log output (error level) for test cases > -- > > Key: FLINK-1407 > URL: https://issues.apache.org/jira/browse/FLINK-1407 > Project: Flink > Issue Type: Improvement >Reporter: Till Rohrmann > > In case of errors (especially flakey test cases) which most often appear on > Travis, it would be helpful to log the error messages in order to detect the > actual problem. Since we also have test exceptions which would be logged the > same way and we don't want to clutter the logs, we would have to set up the > logging for the individual classes selectively. > What do you think? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1407) Enable log output (error level) for test cases
[ https://issues.apache.org/jira/browse/FLINK-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280296#comment-14280296 ] Till Rohrmann commented on FLINK-1407: -- 4 MB it must not exceed > Enable log output (error level) for test cases > -- > > Key: FLINK-1407 > URL: https://issues.apache.org/jira/browse/FLINK-1407 > Project: Flink > Issue Type: Improvement >Reporter: Till Rohrmann > > In case of errors (especially flakey test cases) which most often appear on > Travis, it would be helpful to log the error messages in order to detect the > actual problem. Since we also have test exceptions which would be logged the > same way and we don't want to clutter the logs, we would have to set up the > logging for the individual classes selectively. > What do you think? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1407) Enable log output (error level) for test cases
[ https://issues.apache.org/jira/browse/FLINK-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280251#comment-14280251 ] Till Rohrmann commented on FLINK-1407: -- How long can the log file be? > Enable log output (error level) for test cases > -- > > Key: FLINK-1407 > URL: https://issues.apache.org/jira/browse/FLINK-1407 > Project: Flink > Issue Type: Improvement >Reporter: Till Rohrmann > > In case of errors (especially flakey test cases) which most often appear on > Travis, it would be helpful to log the error messages in order to detect the > actual problem. Since we also have test exceptions which would be logged the > same way and we don't want to clutter the logs, we would have to set up the > logging for the individual classes selectively. > What do you think? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1407) Enable log output (error level) for test cases
[ https://issues.apache.org/jira/browse/FLINK-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279240#comment-14279240 ] Fabian Hueske commented on FLINK-1407: -- disabling error level logging for tests with expected exceptions sounds good to me. > Enable log output (error level) for test cases > -- > > Key: FLINK-1407 > URL: https://issues.apache.org/jira/browse/FLINK-1407 > Project: Flink > Issue Type: Improvement >Reporter: Till Rohrmann > > In case of errors (especially flakey test cases) which most often appear on > Travis, it would be helpful to log the error messages in order to detect the > actual problem. Since we also have test exceptions which would be logged the > same way and we don't want to clutter the logs, we would have to set up the > logging for the individual classes selectively. > What do you think? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1407) Enable log output (error level) for test cases
[ https://issues.apache.org/jira/browse/FLINK-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278792#comment-14278792 ] Ufuk Celebi commented on FLINK-1407: +1 We can either configure tests individually or disable the loggers of the tests with expected exceptions. > Enable log output (error level) for test cases > -- > > Key: FLINK-1407 > URL: https://issues.apache.org/jira/browse/FLINK-1407 > Project: Flink > Issue Type: Improvement >Reporter: Till Rohrmann > > In case of errors (especially flakey test cases) which most often appear on > Travis, it would be helpful to log the error messages in order to detect the > actual problem. Since we also have test exceptions which would be logged the > same way and we don't want to clutter the logs, we would have to set up the > logging for the individual classes selectively. > What do you think? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1407) Enable log output (error level) for test cases
[ https://issues.apache.org/jira/browse/FLINK-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278690#comment-14278690 ] Robert Metzger commented on FLINK-1407: --- I'm generally a big fan of logging a bit .. so I'm in. BUT: Travis has a limit on the log file size .. so we have to be careful. > Enable log output (error level) for test cases > -- > > Key: FLINK-1407 > URL: https://issues.apache.org/jira/browse/FLINK-1407 > Project: Flink > Issue Type: Improvement >Reporter: Till Rohrmann > > In case of errors (especially flakey test cases) which most often appear on > Travis, it would be helpful to log the error messages in order to detect the > actual problem. Since we also have test exceptions which would be logged the > same way and we don't want to clutter the logs, we would have to set up the > logging for the individual classes selectively. > What do you think? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
