[jira] [Commented] (FLINK-1436) Command-line interface verbose option (-v)

2015-01-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289426#comment-14289426
 ] 

ASF GitHub Bot commented on FLINK-1436:
---

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/331#issuecomment-71212582
  
Testing JIRA integration FLINK-1436

Lets see


> Command-line interface verbose option (-v)
> --
>
> Key: FLINK-1436
> URL: https://issues.apache.org/jira/browse/FLINK-1436
> Project: Flink
>  Issue Type: Improvement
>  Components: Start-Stop Scripts
>Reporter: Max Michels
>Assignee: Max Michels
>Priority: Trivial
>  Labels: starter, usability
>
> Let me run just a basic Flink job and add the verbose flag. It's a general 
> option, so let me add it as a first parameter:
> > ./flink -v run ../examples/flink-java-examples-0.8.0-WordCount.jar 
> > hdfs:///input hdfs:///output9
> Invalid action!
> ./flink  [GENERAL_OPTIONS] [ARGUMENTS]
>   general options:
>  -h,--help  Show the help for the CLI Frontend.
>  -v,--verbose   Print more detailed error messages.
> Action "run" compiles and runs a program.
>   Syntax: run [OPTIONS]  
>   "run" action arguments:
>  -c,--classClass with the program entry point 
> ("main"
>   method or "getPlan()" method. Only 
> needed
>   if the JAR file does not specify the 
> class
>   in its manifest.
>  -m,--jobmanager   Address of the JobManager (master) to
>   which to connect. Use this flag to 
> connect
>   to a different JobManager than the one
>   specified in the configuration.
>  -p,--parallelismThe parallelism with which to run the
>   program. Optional flag to override the
>   default value specified in the
>   configuration.
> Action "info" displays information about a program.
>   "info" action arguments:
>  -c,--classClass with the program entry point 
> ("main"
>   method or "getPlan()" method. Only 
> needed
>   if the JAR file does not specify the 
> class
>   in its manifest.
>  -e,--executionplan   Show optimized execution plan of the
>   program (JSON)
>  -m,--jobmanager   Address of the JobManager (master) to
>   which to connect. Use this flag to 
> connect
>   to a different JobManager than the one
>   specified in the configuration.
>  -p,--parallelismThe parallelism with which to run the
>   program. Optional flag to override the
>   default value specified in the
>   configuration.
> Action "list" lists running and finished programs.
>   "list" action arguments:
>  -m,--jobmanagerAddress of the JobManager (master) to which
>to connect. Use this flag to connect to a
>different JobManager than the one specified
>in the configuration.
>  -r,--running  Show running programs and their JobIDs
>  -s,--scheduledShow scheduled prorgrams and their JobIDs
> Action "cancel" cancels a running program.
>   "cancel" action arguments:
>  -i,--jobid JobID of program to cancel
>  -m,--jobmanagerAddress of the JobManager (master) to which
>to connect. Use this flag to connect to a
>different JobManager than the one specified
>in the configuration.
> What just happened? This results in a lot of output which is usually 
> generated if you use the --help option on command-line tools. If your 
> terminal window is large enough, then you will see a tiny message:
> "Please specify an action". I did specify an action. Strange. If you read the 
> help messages carefully you see, that "general options" belong to the action.
> > ./flink run -v ../examples/flink-java-examples-0.8.0-WordCount.jar 
> > hdfs:///input hdfs:///output9
> For the sake of mitigating user frustration, let us also accept -v as the 
> first argument. It may seem trivial for the day-to-day Flink user but makes a 
> difference for a novice.

[jira] [Commented] (FLINK-1436) Command-line interface verbose option (-v)

2015-01-23 Thread Max Michels (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289416#comment-14289416
 ] 

Max Michels commented on FLINK-1436:


https://github.com/apache/flink/pull/331

> Command-line interface verbose option (-v)
> --
>
> Key: FLINK-1436
> URL: https://issues.apache.org/jira/browse/FLINK-1436
> Project: Flink
>  Issue Type: Improvement
>  Components: Start-Stop Scripts
>Reporter: Max Michels
>Assignee: Max Michels
>Priority: Trivial
>  Labels: starter, usability
>
> Let me run just a basic Flink job and add the verbose flag. It's a general 
> option, so let me add it as a first parameter:
> > ./flink -v run ../examples/flink-java-examples-0.8.0-WordCount.jar 
> > hdfs:///input hdfs:///output9
> Invalid action!
> ./flink  [GENERAL_OPTIONS] [ARGUMENTS]
>   general options:
>  -h,--help  Show the help for the CLI Frontend.
>  -v,--verbose   Print more detailed error messages.
> Action "run" compiles and runs a program.
>   Syntax: run [OPTIONS]  
>   "run" action arguments:
>  -c,--classClass with the program entry point 
> ("main"
>   method or "getPlan()" method. Only 
> needed
>   if the JAR file does not specify the 
> class
>   in its manifest.
>  -m,--jobmanager   Address of the JobManager (master) to
>   which to connect. Use this flag to 
> connect
>   to a different JobManager than the one
>   specified in the configuration.
>  -p,--parallelismThe parallelism with which to run the
>   program. Optional flag to override the
>   default value specified in the
>   configuration.
> Action "info" displays information about a program.
>   "info" action arguments:
>  -c,--classClass with the program entry point 
> ("main"
>   method or "getPlan()" method. Only 
> needed
>   if the JAR file does not specify the 
> class
>   in its manifest.
>  -e,--executionplan   Show optimized execution plan of the
>   program (JSON)
>  -m,--jobmanager   Address of the JobManager (master) to
>   which to connect. Use this flag to 
> connect
>   to a different JobManager than the one
>   specified in the configuration.
>  -p,--parallelismThe parallelism with which to run the
>   program. Optional flag to override the
>   default value specified in the
>   configuration.
> Action "list" lists running and finished programs.
>   "list" action arguments:
>  -m,--jobmanagerAddress of the JobManager (master) to which
>to connect. Use this flag to connect to a
>different JobManager than the one specified
>in the configuration.
>  -r,--running  Show running programs and their JobIDs
>  -s,--scheduledShow scheduled prorgrams and their JobIDs
> Action "cancel" cancels a running program.
>   "cancel" action arguments:
>  -i,--jobid JobID of program to cancel
>  -m,--jobmanagerAddress of the JobManager (master) to which
>to connect. Use this flag to connect to a
>different JobManager than the one specified
>in the configuration.
> What just happened? This results in a lot of output which is usually 
> generated if you use the --help option on command-line tools. If your 
> terminal window is large enough, then you will see a tiny message:
> "Please specify an action". I did specify an action. Strange. If you read the 
> help messages carefully you see, that "general options" belong to the action.
> > ./flink run -v ../examples/flink-java-examples-0.8.0-WordCount.jar 
> > hdfs:///input hdfs:///output9
> For the sake of mitigating user frustration, let us also accept -v as the 
> first argument. It may seem trivial for the day-to-day Flink user but makes a 
> difference for a novice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FLINK-1436) Command-line interface verbose option (-v)

2015-01-23 Thread Max Michels (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289064#comment-14289064
 ] 

Max Michels commented on FLINK-1436:


If we remove the verbose parameter, we have to ignore it (not throw an unknown 
arg error) to remain backwards compatibility.

> Command-line interface verbose option (-v)
> --
>
> Key: FLINK-1436
> URL: https://issues.apache.org/jira/browse/FLINK-1436
> Project: Flink
>  Issue Type: Improvement
>  Components: Start-Stop Scripts
>Reporter: Max Michels
>Assignee: Max Michels
>Priority: Trivial
>  Labels: starter, usability
>
> Let me run just a basic Flink job and add the verbose flag. It's a general 
> option, so let me add it as a first parameter:
> > ./flink -v run ../examples/flink-java-examples-0.8.0-WordCount.jar 
> > hdfs:///input hdfs:///output9
> Invalid action!
> ./flink  [GENERAL_OPTIONS] [ARGUMENTS]
>   general options:
>  -h,--help  Show the help for the CLI Frontend.
>  -v,--verbose   Print more detailed error messages.
> Action "run" compiles and runs a program.
>   Syntax: run [OPTIONS]  
>   "run" action arguments:
>  -c,--classClass with the program entry point 
> ("main"
>   method or "getPlan()" method. Only 
> needed
>   if the JAR file does not specify the 
> class
>   in its manifest.
>  -m,--jobmanager   Address of the JobManager (master) to
>   which to connect. Use this flag to 
> connect
>   to a different JobManager than the one
>   specified in the configuration.
>  -p,--parallelismThe parallelism with which to run the
>   program. Optional flag to override the
>   default value specified in the
>   configuration.
> Action "info" displays information about a program.
>   "info" action arguments:
>  -c,--classClass with the program entry point 
> ("main"
>   method or "getPlan()" method. Only 
> needed
>   if the JAR file does not specify the 
> class
>   in its manifest.
>  -e,--executionplan   Show optimized execution plan of the
>   program (JSON)
>  -m,--jobmanager   Address of the JobManager (master) to
>   which to connect. Use this flag to 
> connect
>   to a different JobManager than the one
>   specified in the configuration.
>  -p,--parallelismThe parallelism with which to run the
>   program. Optional flag to override the
>   default value specified in the
>   configuration.
> Action "list" lists running and finished programs.
>   "list" action arguments:
>  -m,--jobmanagerAddress of the JobManager (master) to which
>to connect. Use this flag to connect to a
>different JobManager than the one specified
>in the configuration.
>  -r,--running  Show running programs and their JobIDs
>  -s,--scheduledShow scheduled prorgrams and their JobIDs
> Action "cancel" cancels a running program.
>   "cancel" action arguments:
>  -i,--jobid JobID of program to cancel
>  -m,--jobmanagerAddress of the JobManager (master) to which
>to connect. Use this flag to connect to a
>different JobManager than the one specified
>in the configuration.
> What just happened? This results in a lot of output which is usually 
> generated if you use the --help option on command-line tools. If your 
> terminal window is large enough, then you will see a tiny message:
> "Please specify an action". I did specify an action. Strange. If you read the 
> help messages carefully you see, that "general options" belong to the action.
> > ./flink run -v ../examples/flink-java-examples-0.8.0-WordCount.jar 
> > hdfs:///input hdfs:///output9
> For the sake of mitigating user frustration, let us also accept -v as the 
> first argument. It may seem trivial for the day-to-day Flink user but makes a 
> difference for a novice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FLINK-1436) Command-line interface verbose option (-v)

2015-01-22 Thread Stephan Ewen (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288533#comment-14288533
 ] 

Stephan Ewen commented on FLINK-1436:
-

+1 for all three suggestions from robert

> Command-line interface verbose option (-v)
> --
>
> Key: FLINK-1436
> URL: https://issues.apache.org/jira/browse/FLINK-1436
> Project: Flink
>  Issue Type: Improvement
>  Components: Start-Stop Scripts
>Reporter: Max Michels
>Priority: Trivial
>  Labels: usability
>
> Let me run just a basic Flink job and add the verbose flag. It's a general 
> option, so let me add it as a first parameter:
> > ./flink -v run ../examples/flink-java-examples-0.8.0-WordCount.jar 
> > hdfs:///input hdfs:///output9
> Invalid action!
> ./flink  [GENERAL_OPTIONS] [ARGUMENTS]
>   general options:
>  -h,--help  Show the help for the CLI Frontend.
>  -v,--verbose   Print more detailed error messages.
> Action "run" compiles and runs a program.
>   Syntax: run [OPTIONS]  
>   "run" action arguments:
>  -c,--classClass with the program entry point 
> ("main"
>   method or "getPlan()" method. Only 
> needed
>   if the JAR file does not specify the 
> class
>   in its manifest.
>  -m,--jobmanager   Address of the JobManager (master) to
>   which to connect. Use this flag to 
> connect
>   to a different JobManager than the one
>   specified in the configuration.
>  -p,--parallelismThe parallelism with which to run the
>   program. Optional flag to override the
>   default value specified in the
>   configuration.
> Action "info" displays information about a program.
>   "info" action arguments:
>  -c,--classClass with the program entry point 
> ("main"
>   method or "getPlan()" method. Only 
> needed
>   if the JAR file does not specify the 
> class
>   in its manifest.
>  -e,--executionplan   Show optimized execution plan of the
>   program (JSON)
>  -m,--jobmanager   Address of the JobManager (master) to
>   which to connect. Use this flag to 
> connect
>   to a different JobManager than the one
>   specified in the configuration.
>  -p,--parallelismThe parallelism with which to run the
>   program. Optional flag to override the
>   default value specified in the
>   configuration.
> Action "list" lists running and finished programs.
>   "list" action arguments:
>  -m,--jobmanagerAddress of the JobManager (master) to which
>to connect. Use this flag to connect to a
>different JobManager than the one specified
>in the configuration.
>  -r,--running  Show running programs and their JobIDs
>  -s,--scheduledShow scheduled prorgrams and their JobIDs
> Action "cancel" cancels a running program.
>   "cancel" action arguments:
>  -i,--jobid JobID of program to cancel
>  -m,--jobmanagerAddress of the JobManager (master) to which
>to connect. Use this flag to connect to a
>different JobManager than the one specified
>in the configuration.
> What just happened? This results in a lot of output which is usually 
> generated if you use the --help option on command-line tools. If your 
> terminal window is large enough, then you will see a tiny message:
> "Please specify an action". I did specify an action. Strange. If you read the 
> help messages carefully you see, that "general options" belong to the action.
> > ./flink run -v ../examples/flink-java-examples-0.8.0-WordCount.jar 
> > hdfs:///input hdfs:///output9
> For the sake of mitigating user frustration, let us also accept -v as the 
> first argument. It may seem trivial for the day-to-day Flink user but makes a 
> difference for a novice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FLINK-1436) Command-line interface verbose option (-v)

2015-01-22 Thread Robert Metzger (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287509#comment-14287509
 ] 

Robert Metzger commented on FLINK-1436:
---

I totally agree with you.

Also, it would be nice if the cli tool would say what it got as an action. In 
your case for example "invalid action: -v"
I had a similar issue with the jar file, the only error message I've got as 
"Invalid jar file" or so. It would have been nicer if the output was 
"org.apache.flink.Wordcount is not a valid file location".

In addition to that, I don't see a reason why there is a "-v" option at all. 
I'm always using "-v" because I want to see the exceptions which happen. 
So I vote to a) improve the error messages
b) remove the verbose flag and make it always verbose
c) do not show the full help text on errors.

> Command-line interface verbose option (-v)
> --
>
> Key: FLINK-1436
> URL: https://issues.apache.org/jira/browse/FLINK-1436
> Project: Flink
>  Issue Type: Improvement
>  Components: Start-Stop Scripts
>Reporter: Max Michels
>Priority: Trivial
>  Labels: usability
>
> Let me run just a basic Flink job and add the verbose flag. It's a general 
> option, so let me add it as a first parameter:
> > ./flink -v run ../examples/flink-java-examples-0.8.0-WordCount.jar 
> > hdfs:///input hdfs:///output9
> Invalid action!
> ./flink  [GENERAL_OPTIONS] [ARGUMENTS]
>   general options:
>  -h,--help  Show the help for the CLI Frontend.
>  -v,--verbose   Print more detailed error messages.
> Action "run" compiles and runs a program.
>   Syntax: run [OPTIONS]  
>   "run" action arguments:
>  -c,--classClass with the program entry point 
> ("main"
>   method or "getPlan()" method. Only 
> needed
>   if the JAR file does not specify the 
> class
>   in its manifest.
>  -m,--jobmanager   Address of the JobManager (master) to
>   which to connect. Use this flag to 
> connect
>   to a different JobManager than the one
>   specified in the configuration.
>  -p,--parallelismThe parallelism with which to run the
>   program. Optional flag to override the
>   default value specified in the
>   configuration.
> Action "info" displays information about a program.
>   "info" action arguments:
>  -c,--classClass with the program entry point 
> ("main"
>   method or "getPlan()" method. Only 
> needed
>   if the JAR file does not specify the 
> class
>   in its manifest.
>  -e,--executionplan   Show optimized execution plan of the
>   program (JSON)
>  -m,--jobmanager   Address of the JobManager (master) to
>   which to connect. Use this flag to 
> connect
>   to a different JobManager than the one
>   specified in the configuration.
>  -p,--parallelismThe parallelism with which to run the
>   program. Optional flag to override the
>   default value specified in the
>   configuration.
> Action "list" lists running and finished programs.
>   "list" action arguments:
>  -m,--jobmanagerAddress of the JobManager (master) to which
>to connect. Use this flag to connect to a
>different JobManager than the one specified
>in the configuration.
>  -r,--running  Show running programs and their JobIDs
>  -s,--scheduledShow scheduled prorgrams and their JobIDs
> Action "cancel" cancels a running program.
>   "cancel" action arguments:
>  -i,--jobid JobID of program to cancel
>  -m,--jobmanagerAddress of the JobManager (master) to which
>to connect. Use this flag to connect to a
>different JobManager than the one specified
>in the configuration.
> What just happened? This results in a lot of output which is usually 
> generated if you use the --help option on command-line tools. If your 
> terminal window is large enough, then you will see a tiny message:
> "Please specify an action

[jira] [Commented] (FLINK-1436) Command-line interface verbose option (-v)

2015-01-22 Thread Max Michels (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287477#comment-14287477
 ] 

Max Michels commented on FLINK-1436:


This is also related to the confusion in 
https://issues.apache.org/jira/browse/FLINK-1424

> Command-line interface verbose option (-v)
> --
>
> Key: FLINK-1436
> URL: https://issues.apache.org/jira/browse/FLINK-1436
> Project: Flink
>  Issue Type: Improvement
>  Components: Start-Stop Scripts
>Reporter: Max Michels
>Priority: Trivial
>  Labels: usability
>
> Let me run just a basic Flink job and add the verbose flag. It's a general 
> option, so let me add it as a first parameter:
> > ./flink -v run ../examples/flink-java-examples-0.8.0-WordCount.jar 
> > hdfs:///input hdfs:///output9
> Invalid action!
> ./flink  [GENERAL_OPTIONS] [ARGUMENTS]
>   general options:
>  -h,--help  Show the help for the CLI Frontend.
>  -v,--verbose   Print more detailed error messages.
> Action "run" compiles and runs a program.
>   Syntax: run [OPTIONS]  
>   "run" action arguments:
>  -c,--classClass with the program entry point 
> ("main"
>   method or "getPlan()" method. Only 
> needed
>   if the JAR file does not specify the 
> class
>   in its manifest.
>  -m,--jobmanager   Address of the JobManager (master) to
>   which to connect. Use this flag to 
> connect
>   to a different JobManager than the one
>   specified in the configuration.
>  -p,--parallelismThe parallelism with which to run the
>   program. Optional flag to override the
>   default value specified in the
>   configuration.
> Action "info" displays information about a program.
>   "info" action arguments:
>  -c,--classClass with the program entry point 
> ("main"
>   method or "getPlan()" method. Only 
> needed
>   if the JAR file does not specify the 
> class
>   in its manifest.
>  -e,--executionplan   Show optimized execution plan of the
>   program (JSON)
>  -m,--jobmanager   Address of the JobManager (master) to
>   which to connect. Use this flag to 
> connect
>   to a different JobManager than the one
>   specified in the configuration.
>  -p,--parallelismThe parallelism with which to run the
>   program. Optional flag to override the
>   default value specified in the
>   configuration.
> Action "list" lists running and finished programs.
>   "list" action arguments:
>  -m,--jobmanagerAddress of the JobManager (master) to which
>to connect. Use this flag to connect to a
>different JobManager than the one specified
>in the configuration.
>  -r,--running  Show running programs and their JobIDs
>  -s,--scheduledShow scheduled prorgrams and their JobIDs
> Action "cancel" cancels a running program.
>   "cancel" action arguments:
>  -i,--jobid JobID of program to cancel
>  -m,--jobmanagerAddress of the JobManager (master) to which
>to connect. Use this flag to connect to a
>different JobManager than the one specified
>in the configuration.
> What just happened? This results in a lot of output which is usually 
> generated if you use the --help option on command-line tools. If your 
> terminal window is large enough, then you will see a tiny message:
> "Please specify an action". I did specify an action. Strange. If you read the 
> help messages carefully you see, that "general options" belong to the action.
> > ./flink run -v ../examples/flink-java-examples-0.8.0-WordCount.jar 
> > hdfs:///input hdfs:///output9
> For the sake of mitigating user frustration, let us also accept -v as the 
> first argument. It may seem trivial for the day-to-day Flink user but makes a 
> difference for a novice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)