[jira] [Commented] (FLINK-18452) Flaws in RetractableTopNFunction.ComparatorWrapper#equals method prevent state access after restoration

2020-11-16 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233224#comment-17233224 ] Jark Wu commented on FLINK-18452: - I will take this issue. > Flaws in

[jira] [Commented] (FLINK-18452) Flaws in RetractableTopNFunction.ComparatorWrapper#equals method prevent state access after restoration

2020-07-13 Thread Weike Dong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156587#comment-17156587 ] Weike Dong commented on FLINK-18452: Yes, I agree that we can fix this bug in next major release,

[jira] [Commented] (FLINK-18452) Flaws in RetractableTopNFunction.ComparatorWrapper#equals method prevent state access after restoration

2020-06-30 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149048#comment-17149048 ] Jark Wu commented on FLINK-18452: - Hi [~kyledong], currently, SQL/Table doesn't provide state compatible

[jira] [Commented] (FLINK-18452) Flaws in RetractableTopNFunction.ComparatorWrapper#equals method prevent state access after restoration

2020-06-30 Thread Weike Dong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148388#comment-17148388 ] Weike Dong commented on FLINK-18452: One important thing to note here is backward compatibility. For

[jira] [Commented] (FLINK-18452) Flaws in RetractableTopNFunction.ComparatorWrapper#equals method prevent state access after restoration

2020-06-30 Thread Weike Dong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148348#comment-17148348 ] Weike Dong commented on FLINK-18452: Thank you [~jark] for the reply, and I agree that the meta info

[jira] [Commented] (FLINK-18452) Flaws in RetractableTopNFunction.ComparatorWrapper#equals method prevent state access after restoration

2020-06-30 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148332#comment-17148332 ] Jark Wu commented on FLINK-18452: - I think this is an issue in {{ComparatorWrapper#equals}}, we

[jira] [Commented] (FLINK-18452) Flaws in RetractableTopNFunction.ComparatorWrapper#equals method prevent state access after restoration

2020-06-29 Thread Weike Dong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148289#comment-17148289 ] Weike Dong commented on FLINK-18452: Hi [~jinyu.zj], would you please be so kind to look at this