[jira] [Commented] (FLINK-2255) In the TopSpeedWindowing examples, every window contains only 1 element, because event time is in millisec, but eviction is in sec
[ https://issues.apache.org/jira/browse/FLINK-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601038#comment-14601038 ] ASF GitHub Bot commented on FLINK-2255: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/857 In the TopSpeedWindowing examples, every window contains only 1 element, because event time is in millisec, but eviction is in sec -- Key: FLINK-2255 URL: https://issues.apache.org/jira/browse/FLINK-2255 Project: Flink Issue Type: Bug Components: Examples, Streaming Reporter: Gabor Gevay Assignee: Gabor Gevay Priority: Minor The event times are generated by System.currentTimeMillis(), so evictionSec should be multiplied by 1000, when passing it to Time.of. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2255) In the TopSpeedWindowing examples, every window contains only 1 element, because event time is in millisec, but eviction is in sec
[ https://issues.apache.org/jira/browse/FLINK-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596253#comment-14596253 ] ASF GitHub Bot commented on FLINK-2255: --- Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/857#issuecomment-114184152 Thanks for spotting this, Gabor. Looks good to merge. In the TopSpeedWindowing examples, every window contains only 1 element, because event time is in millisec, but eviction is in sec -- Key: FLINK-2255 URL: https://issues.apache.org/jira/browse/FLINK-2255 Project: Flink Issue Type: Bug Components: Examples, Streaming Reporter: Gabor Gevay Assignee: Gabor Gevay Priority: Minor The event times are generated by System.currentTimeMillis(), so evictionSec should be multiplied by 1000, when passing it to Time.of. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2255) In the TopSpeedWindowing examples, every window contains only 1 element, because event time is in millisec, but eviction is in sec
[ https://issues.apache.org/jira/browse/FLINK-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596576#comment-14596576 ] ASF GitHub Bot commented on FLINK-2255: --- Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/857#issuecomment-114250566 Looks good :+1: In the TopSpeedWindowing examples, every window contains only 1 element, because event time is in millisec, but eviction is in sec -- Key: FLINK-2255 URL: https://issues.apache.org/jira/browse/FLINK-2255 Project: Flink Issue Type: Bug Components: Examples, Streaming Reporter: Gabor Gevay Assignee: Gabor Gevay Priority: Minor The event times are generated by System.currentTimeMillis(), so evictionSec should be multiplied by 1000, when passing it to Time.of. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2255) In the TopSpeedWindowing examples, every window contains only 1 element, because event time is in millisec, but eviction is in sec
[ https://issues.apache.org/jira/browse/FLINK-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595879#comment-14595879 ] ASF GitHub Bot commented on FLINK-2255: --- GitHub user ggevay opened a pull request: https://github.com/apache/flink/pull/857 [FLINK-2255] [streaming] Fixed a bug in TopSpeedWindowing examples Added the *1000, and modified the reference output of the ITCases. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ggevay/flink topSpeedBugfix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/857.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #857 commit b78ee892ac5778b1470823d745c7d1b94a067114 Author: Gabor Gevay gga...@gmail.com Date: 2015-06-22T12:56:41Z [FLINK-2255] [streaming] Fixed a bug in TopSpeedWindowing examples In the TopSpeedWindowing examples, every window contains only 1 element, because event time is in millisec, but eviction is in sec -- Key: FLINK-2255 URL: https://issues.apache.org/jira/browse/FLINK-2255 Project: Flink Issue Type: Bug Components: Examples, Streaming Reporter: Gabor Gevay Assignee: Gabor Gevay Priority: Minor The event times are generated by System.currentTimeMillis(), so evictionSec should be multiplied by 1000, when passing it to Time.of. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
