[jira] [Commented] (FLINK-24717) Push down partitions before filters

2021-11-01 Thread Kurt Young (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437101#comment-17437101
 ] 

Kurt Young commented on FLINK-24717:


assigned to you [~xuyangzhong]

> Push down partitions before filters
> ---
>
> Key: FLINK-24717
> URL: https://issues.apache.org/jira/browse/FLINK-24717
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Planner
>Reporter: Timo Walther
>Assignee: xuyang
>Priority: Major
> Fix For: 1.15.0
>
>
> Currently, we push filters before partitions. This means that a 
> {{applyFilters}} needs to have partition logic to extract the partition 
> predicate. Furthermore, if a {{applyFilters}} consumes all filters (no 
> remaining predicates), the {{applyPartitions}} is never called.
> We should execute the {{PushPartitionIntoTableSourceScanRule}} first and 
> check for side effects of this change.
> See 
> {{org.apache.flink.table.planner.plan.rules.logical.PushProjectIntoTableSourceScanRuleTest#testMetadataProjectionWithoutProjectionPushDownWhenNotSupportedAndNoneSelected}}
>  for an example of using the new test infrastructure.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-24717) Push down partitions before filters

2021-11-01 Thread xuyang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437100#comment-17437100
 ] 

xuyang commented on FLINK-24717:


I'll try to fix it.

> Push down partitions before filters
> ---
>
> Key: FLINK-24717
> URL: https://issues.apache.org/jira/browse/FLINK-24717
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Planner
>Reporter: Timo Walther
>Priority: Major
> Fix For: 1.15.0
>
>
> Currently, we push filters before partitions. This means that a 
> {{applyFilters}} needs to have partition logic to extract the partition 
> predicate. Furthermore, if a {{applyFilters}} consumes all filters (no 
> remaining predicates), the {{applyPartitions}} is never called.
> We should execute the {{PushPartitionIntoTableSourceScanRule}} first and 
> check for side effects of this change.
> See 
> {{org.apache.flink.table.planner.plan.rules.logical.PushProjectIntoTableSourceScanRuleTest#testMetadataProjectionWithoutProjectionPushDownWhenNotSupportedAndNoneSelected}}
>  for an example of using the new test infrastructure.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)