[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986969#comment-14986969
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1313


> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987013#comment-14987013
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

Github user sachingoel0101 commented on the pull request:

https://github.com/apache/flink/pull/1313#issuecomment-153303602
  
@StephanEwen , since this is already merged, I'll push another commit and 
point you to it for merging.


> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987020#comment-14987020
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/1313#issuecomment-153305865
  
@StephanEwen Sorry, didn't see your post. I filed a follow-up JIRA for 
this: https://issues.apache.org/jira/browse/FLINK-2957


> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985308#comment-14985308
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/1313#issuecomment-153037113
  
I would like to merge this soon. Cancellation jobs from the web frontend 
has been requested several times.


> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985295#comment-14985295
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/1313#issuecomment-153033461
  
>Hovering over the cross reveals the word cancel.

Could we also have a button labelled "Cancel Job"? That way people don't 
even have to hover over things to get the meaning...


> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985474#comment-14985474
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

Github user mxm commented on a diff in the pull request:

https://github.com/apache/flink/pull/1313#discussion_r43646752
  
--- Diff: 
flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.ctrl.coffee ---
@@ -70,6 +70,10 @@ angular.module('flinkApp')
 
 $interval.cancel(refresher)
 
+  $scope.cancelJob = (cancelEvent) ->
+
angular.element(cancelEvent.currentTarget).removeClass('label-danger').addClass('label-info').html('Cancelling...')
--- End diff --

Why do you have to remove the 'label-danger' class?


> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985486#comment-14985486
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

Github user mxm commented on a diff in the pull request:

https://github.com/apache/flink/pull/1313#discussion_r43647947
  
--- Diff: 
flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.ctrl.coffee ---
@@ -70,6 +70,10 @@ angular.module('flinkApp')
 
 $interval.cancel(refresher)
 
+  $scope.cancelJob = (cancelEvent) ->
+
angular.element(cancelEvent.currentTarget).removeClass('label-danger').addClass('label-info').html('Cancelling...')
--- End diff --

Ah I see.


> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985573#comment-14985573
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

Github user sachingoel0101 commented on the pull request:

https://github.com/apache/flink/pull/1313#issuecomment-153089967
  
Sure. No problem. :)


> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985459#comment-14985459
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

Github user sachingoel0101 commented on the pull request:

https://github.com/apache/flink/pull/1313#issuecomment-153068875
  
Here are the new screenshots:
Before:
![screenshot 
36](https://cloud.githubusercontent.com/assets/8874261/10886974/a07aa41e-81aa-11e5-8734-1eee48f431c1.png)
During:
![screenshot 
37](https://cloud.githubusercontent.com/assets/8874261/10886984/acf905f0-81aa-11e5-9260-af2a0b1e3cc2.png)
After:
![screenshot 
38](https://cloud.githubusercontent.com/assets/8874261/10886990/b40d3d02-81aa-11e5-80ef-2985df41b710.png)

@mxm Can you look this over again?


> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985008#comment-14985008
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

Github user sachingoel0101 commented on the pull request:

https://github.com/apache/flink/pull/1313#issuecomment-152977663
  
@StephanEwen that's a good point. I've already pushed a fix. :)


> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986276#comment-14986276
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1313#issuecomment-153192822
  
Much better. Is there a way of making this thing look more like a button? 
Right now it looks very much like a label and I would not think of trying to 
click it...


> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984387#comment-14984387
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

GitHub user sachingoel0101 opened a pull request:

https://github.com/apache/flink/pull/1313

[FLINK-2939][web-dashboard] Add support to cancel jobs from the dashboard

Cancel button placement (open for discussion and/or any changes):

![capture](https://cloud.githubusercontent.com/assets/8874261/10868879/a578e324-80c2-11e5-8383-14a8aab800b6.PNG)

After cancelling:

![capture1](https://cloud.githubusercontent.com/assets/8874261/10868881/b7cbf836-80c2-11e5-98a8-d588c10fb845.PNG)

Also includes some documentation fixes for the web frontend project to 
reflect the recent changes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sachingoel0101/flink cancel_button

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1313.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1313


commit 29a488d1e5da9bf8e431ab40c8a23f8ee3e5e9dd
Author: Sachin Goel 
Date:   2015-11-01T10:24:13Z

[FLINK-2939][web-dashboard] Add support for cancelling jobs from the
dashboard

commit 77268771f6228ba75e22366ff3dc71124e48ba9e
Author: Sachin Goel 
Date:   2015-11-01T12:23:53Z

[hotfix] Fix README for flink-runtime-web to reflect the latest changes




> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984465#comment-14984465
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/1313#issuecomment-152847408
  
Thanks! Not sure users will see the "X" in the corner and understand it's 
for cancelling jobs. 


> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984707#comment-14984707
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

Github user sachingoel0101 commented on the pull request:

https://github.com/apache/flink/pull/1313#issuecomment-152904731
  
Hovering over the cross reveals the word cancel. 


> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984845#comment-14984845
 ] 

ASF GitHub Bot commented on FLINK-2939:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1313#issuecomment-152943948
  
This goes a bit against the idea of REST. If you "GET" a certain URL, it 
should not affect the state of the system you query.

If we want to make that action part of the REST API, we should probably add 
a "DELETE" action for the URL "jobs/".


> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[Sachin Goel (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980245#comment-14980245
 ] 

Sachin Goel commented on FLINK-2939:


Is this a blocker for the 0.10 release? Because otherwise I'd like to work on 
it. 

> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[Maximilian Michels (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980257#comment-14980257
 ] 

Maximilian Michels commented on FLINK-2939:
---

Not a blocker but would be nice to have. Feel free to work on it if you like. 
Essentially, the button should just send a cancel message to the job manager 
and only be visible if the job is running.

> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[Sachin Goel (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980267#comment-14980267
 ] 

Sachin Goel commented on FLINK-2939:


If anyone else wants to take a shot, feel free to reassign before Saturday. 

> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
>Assignee: Sachin Goel
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2939) Add button to cancel jobs in new web frontend

[Sachin Goel (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980265#comment-14980265
 ] 

Sachin Goel commented on FLINK-2939:


Okay. Cool. I'm busy this weekend, thought I'd  ask first.
I'm assigning this to myself. Should be finished by Monday. 

> Add button to cancel jobs in new web frontend
> -
>
> Key: FLINK-2939
> URL: https://issues.apache.org/jira/browse/FLINK-2939
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Affects Versions: 0.10
>Reporter: Maximilian Michels
> Fix For: 0.10
>
>
> Although jobs may be cancelled through the CLI, it would be nice to have a 
> cancel button in the web frontend as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)