[jira] [Commented] (FLINK-3555) Web interface does not render job information properly
[ https://issues.apache.org/jira/browse/FLINK-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834536#comment-15834536 ] ASF GitHub Bot commented on FLINK-3555: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2941 @bitchelov do you want to follow up on this pull request? > Web interface does not render job information properly > -- > > Key: FLINK-3555 > URL: https://issues.apache.org/jira/browse/FLINK-3555 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: 1.0.0 >Reporter: Till Rohrmann >Assignee: Sergey_Sokur >Priority: Minor > Attachments: Chrome.png, Safari.png > > > In Chrome and Safari, the different tabs of the detailed job view are not > properly rendered. The text goes beyond the surrounding box. I would guess > that this is some kind of css issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3555) Web interface does not render job information properly
[ https://issues.apache.org/jira/browse/FLINK-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812183#comment-15812183 ] ASF GitHub Bot commented on FLINK-3555: --- Github user sachingoel0101 commented on the issue: https://github.com/apache/flink/pull/2941 Imo, the best way to achieve the change equivalent to the change to vendor.css file would be to add a new class, say, .panel-body-flowable in index.styl which defines the overflow rule, and add this class to the elements wherever needed. > Web interface does not render job information properly > -- > > Key: FLINK-3555 > URL: https://issues.apache.org/jira/browse/FLINK-3555 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: 1.0.0 >Reporter: Till Rohrmann >Assignee: Sergey_Sokur >Priority: Minor > Attachments: Chrome.png, Safari.png > > > In Chrome and Safari, the different tabs of the detailed job view are not > properly rendered. The text goes beyond the surrounding box. I would guess > that this is some kind of css issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3555) Web interface does not render job information properly
[ https://issues.apache.org/jira/browse/FLINK-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811940#comment-15811940 ] ASF GitHub Bot commented on FLINK-3555: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2941 Sorry, I have to take a step back here: The changes you made were directly to the resulting CSS files. These files are generated by the web build scripts, so the changes have to be made to the original files. Otherwise they will be overwritten the next time somebody re-builds the web UI. See here: https://github.com/apache/flink/blob/master/flink-runtime-web/README.md The change to `flink-runtime-web/web-dashboard/web/css/index.css` is easy t put into `index.styl` instead. However, the change in `flink-runtime-web/web-dashboard/web/css/vendor.css` overwrites a style that is pulled in as a dependency. Not sure how to handle this correctly. @uce @sachingoel0101 ot @iampeter Can probably help here. > Web interface does not render job information properly > -- > > Key: FLINK-3555 > URL: https://issues.apache.org/jira/browse/FLINK-3555 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: 1.0.0 >Reporter: Till Rohrmann >Assignee: Sergey_Sokur >Priority: Minor > Attachments: Chrome.png, Safari.png > > > In Chrome and Safari, the different tabs of the detailed job view are not > properly rendered. The text goes beyond the surrounding box. I would guess > that this is some kind of css issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3555) Web interface does not render job information properly
[ https://issues.apache.org/jira/browse/FLINK-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811788#comment-15811788 ] ASF GitHub Bot commented on FLINK-3555: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2941 Looks good, thanks for the nice animations! Will merge this for 1.2 and 1.3 ... > Web interface does not render job information properly > -- > > Key: FLINK-3555 > URL: https://issues.apache.org/jira/browse/FLINK-3555 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: 1.0.0 >Reporter: Till Rohrmann >Assignee: Sergey_Sokur >Priority: Minor > Attachments: Chrome.png, Safari.png > > > In Chrome and Safari, the different tabs of the detailed job view are not > properly rendered. The text goes beyond the surrounding box. I would guess > that this is some kind of css issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3555) Web interface does not render job information properly
[ https://issues.apache.org/jira/browse/FLINK-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811413#comment-15811413 ] ASF GitHub Bot commented on FLINK-3555: --- Github user bitchelov commented on the issue: https://github.com/apache/flink/pull/2941 @StephanEwen is it right? > Web interface does not render job information properly > -- > > Key: FLINK-3555 > URL: https://issues.apache.org/jira/browse/FLINK-3555 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: 1.0.0 >Reporter: Till Rohrmann >Assignee: Sergey_Sokur >Priority: Minor > Attachments: Chrome.png, Safari.png > > > In Chrome and Safari, the different tabs of the detailed job view are not > properly rendered. The text goes beyond the surrounding box. I would guess > that this is some kind of css issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3555) Web interface does not render job information properly
[ https://issues.apache.org/jira/browse/FLINK-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748483#comment-15748483 ] ASF GitHub Bot commented on FLINK-3555: --- Github user bitchelov commented on the issue: https://github.com/apache/flink/pull/2941 @StephanEwen Sure. > Web interface does not render job information properly > -- > > Key: FLINK-3555 > URL: https://issues.apache.org/jira/browse/FLINK-3555 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: 1.0.0 >Reporter: Till Rohrmann >Assignee: Sergey Sokur >Priority: Minor > Attachments: Chrome.png, Safari.png > > > In Chrome and Safari, the different tabs of the detailed job view are not > properly rendered. The text goes beyond the surrounding box. I would guess > that this is some kind of css issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3555) Web interface does not render job information properly
[ https://issues.apache.org/jira/browse/FLINK-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748050#comment-15748050 ] ASF GitHub Bot commented on FLINK-3555: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2941 Thank you for this patch. Could you help us validate the changed behavior, for example attach a before/after screenshot of chrome or Safari that shows the difference? > Web interface does not render job information properly > -- > > Key: FLINK-3555 > URL: https://issues.apache.org/jira/browse/FLINK-3555 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: 1.0.0 >Reporter: Till Rohrmann >Assignee: Sergey Sokur >Priority: Minor > Attachments: Chrome.png, Safari.png > > > In Chrome and Safari, the different tabs of the detailed job view are not > properly rendered. The text goes beyond the surrounding box. I would guess > that this is some kind of css issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3555) Web interface does not render job information properly
[
https://issues.apache.org/jira/browse/FLINK-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721882#comment-15721882
]
ASF GitHub Bot commented on FLINK-3555:
---
GitHub user bitchelov opened a pull request:
https://github.com/apache/flink/pull/2941
[FLINK-3555] Web interface does not render job information properly
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bitchelov/flink FLINK-3555
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2941.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2941
commit 62183185b43a84f729484108251a1ca1db27e13a
Author: sergey_sokur
Date: 2016-11-28T10:06:29Z
[FLINK-3555] Web interface does not render job information properly
> Web interface does not render job information properly
> --
>
> Key: FLINK-3555
> URL: https://issues.apache.org/jira/browse/FLINK-3555
> Project: Flink
> Issue Type: Bug
> Components: Webfrontend
>Affects Versions: 1.0.0
>Reporter: Till Rohrmann
>Assignee: Sergey Sokur
>Priority: Minor
> Attachments: Chrome.png, Safari.png
>
>
> In Chrome and Safari, the different tabs of the detailed job view are not
> properly rendered. The text goes beyond the surrounding box. I would guess
> that this is some kind of css issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3555) Web interface does not render job information properly
[ https://issues.apache.org/jira/browse/FLINK-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701457#comment-15701457 ] ASF GitHub Bot commented on FLINK-3555: --- Github user bitchelov closed the pull request at: https://github.com/apache/flink/pull/2869 > Web interface does not render job information properly > -- > > Key: FLINK-3555 > URL: https://issues.apache.org/jira/browse/FLINK-3555 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: 1.0.0 >Reporter: Till Rohrmann >Assignee: Sergey Sokur >Priority: Minor > Attachments: Chrome.png, Safari.png > > > In Chrome and Safari, the different tabs of the detailed job view are not > properly rendered. The text goes beyond the surrounding box. I would guess > that this is some kind of css issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3555) Web interface does not render job information properly
[
https://issues.apache.org/jira/browse/FLINK-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701320#comment-15701320
]
ASF GitHub Bot commented on FLINK-3555:
---
Github user bitchelov commented on a diff in the pull request:
https://github.com/apache/flink/pull/2869#discussion_r89735665
--- Diff: flink-runtime-web/web-dashboard/web/css/vendor.css ---
@@ -1,96 +1,96 @@
/* nvd3 version 1.8.4 (https://github.com/novus/nvd3) 2016-07-03 */
-.nvd3 .nv-axis {
--- End diff --
@zentol, I’ll fix it.
> Web interface does not render job information properly
> --
>
> Key: FLINK-3555
> URL: https://issues.apache.org/jira/browse/FLINK-3555
> Project: Flink
> Issue Type: Bug
> Components: Webfrontend
>Affects Versions: 1.0.0
>Reporter: Till Rohrmann
>Assignee: Sergey Sokur
>Priority: Minor
> Attachments: Chrome.png, Safari.png
>
>
> In Chrome and Safari, the different tabs of the detailed job view are not
> properly rendered. The text goes beyond the surrounding box. I would guess
> that this is some kind of css issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3555) Web interface does not render job information properly
[
https://issues.apache.org/jira/browse/FLINK-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695905#comment-15695905
]
ASF GitHub Bot commented on FLINK-3555:
---
GitHub user bitchelov opened a pull request:
https://github.com/apache/flink/pull/2869
[FLINK-3555] Web interface does not render job information properly
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bitchelov/flink FLINK-3555
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2869.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2869
commit cd3d79cc704f45d41c494173abe16bc98d818b86
Author: sergey_sokur
Date: 2016-11-25T11:45:08Z
[FLINK-3555] Web interface does not render job information properly
> Web interface does not render job information properly
> --
>
> Key: FLINK-3555
> URL: https://issues.apache.org/jira/browse/FLINK-3555
> Project: Flink
> Issue Type: Bug
> Components: Webfrontend
>Affects Versions: 1.0.0
>Reporter: Till Rohrmann
>Assignee: Sergey Sokur
>Priority: Minor
> Attachments: Chrome.png, Safari.png
>
>
> In Chrome and Safari, the different tabs of the detailed job view are not
> properly rendered. The text goes beyond the surrounding box. I would guess
> that this is some kind of css issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
