[jira] [Commented] (FLINK-4359) Add INTERVAL type
[ https://issues.apache.org/jira/browse/FLINK-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417270#comment-15417270 ] Timo Walther commented on FLINK-4359: - Once the roadmap for that is defined (most likely with a corresponding FLIP). You are very welcome to help. I think we will discuss this in the next 1-2 weeks. > Add INTERVAL type > - > > Key: FLINK-4359 > URL: https://issues.apache.org/jira/browse/FLINK-4359 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > Fix For: 1.2.0 > > > In order to start with StreamSQL windows we need a way to define intervals in > time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4359) Add INTERVAL type
[ https://issues.apache.org/jira/browse/FLINK-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417187#comment-15417187 ] Jark Wu commented on FLINK-4359: Okay, I see. I'm interested in this, and I'm glad if I can help anything. > Add INTERVAL type > - > > Key: FLINK-4359 > URL: https://issues.apache.org/jira/browse/FLINK-4359 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > Fix For: 1.2.0 > > > In order to start with StreamSQL windows we need a way to define intervals in > time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4359) Add INTERVAL type
[ https://issues.apache.org/jira/browse/FLINK-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417152#comment-15417152 ] Timo Walther commented on FLINK-4359: - [~jark] no we don't know how we want to implement it yet. We have to discuss this with the Calcite guys. > Add INTERVAL type > - > > Key: FLINK-4359 > URL: https://issues.apache.org/jira/browse/FLINK-4359 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > Fix For: 1.2.0 > > > In order to start with StreamSQL windows we need a way to define intervals in > time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4359) Add INTERVAL type
[ https://issues.apache.org/jira/browse/FLINK-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417146#comment-15417146 ] ASF GitHub Bot commented on FLINK-4359: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2348 > Add INTERVAL type > - > > Key: FLINK-4359 > URL: https://issues.apache.org/jira/browse/FLINK-4359 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > > In order to start with StreamSQL windows we need a way to define intervals in > time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4359) Add INTERVAL type
[ https://issues.apache.org/jira/browse/FLINK-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417126#comment-15417126 ] ASF GitHub Bot commented on FLINK-4359: --- Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2348 Merging this... > Add INTERVAL type > - > > Key: FLINK-4359 > URL: https://issues.apache.org/jira/browse/FLINK-4359 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > > In order to start with StreamSQL windows we need a way to define intervals in > time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4359) Add INTERVAL type
[ https://issues.apache.org/jira/browse/FLINK-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416671#comment-15416671 ] ASF GitHub Bot commented on FLINK-4359: --- Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2348 Ok, I figured as much. A bit ugly but I guess everyone has to do it like this. From a quick glance the API and implementation look good. > Add INTERVAL type > - > > Key: FLINK-4359 > URL: https://issues.apache.org/jira/browse/FLINK-4359 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > > In order to start with StreamSQL windows we need a way to define intervals in > time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4359) Add INTERVAL type
[ https://issues.apache.org/jira/browse/FLINK-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416179#comment-15416179 ] ASF GitHub Bot commented on FLINK-4359: --- Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2348 The first line is Scala Table API, second line is Java Table API and the string with the INTERVAL prefix is standard SQL. So we cannot change the standard ;) Yes, I think that is the reason. Calcite does it like that and Oracle too. https://docs.oracle.com/cd/B19306_01/server.102/b14200/sql_elements003.htm#i38598 > Add INTERVAL type > - > > Key: FLINK-4359 > URL: https://issues.apache.org/jira/browse/FLINK-4359 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > > In order to start with StreamSQL windows we need a way to define intervals in > time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4359) Add INTERVAL type
[ https://issues.apache.org/jira/browse/FLINK-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415303#comment-15415303 ] ASF GitHub Bot commented on FLINK-4359: --- Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2348 Is the `INTERVAL` prefix needed to make it work with the parser? Otherwise it would be nice to just write `2 DAYS`, or something like that. By the way, the reason for the two different interval types is that the millis type does not have enough range to represent years? > Add INTERVAL type > - > > Key: FLINK-4359 > URL: https://issues.apache.org/jira/browse/FLINK-4359 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > > In order to start with StreamSQL windows we need a way to define intervals in > time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4359) Add INTERVAL type
[
https://issues.apache.org/jira/browse/FLINK-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415205#comment-15415205
]
ASF GitHub Bot commented on FLINK-4359:
---
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2348
[FLINK-4359] [table] Add INTERVAL type
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
This PR introduces INTERVAL types for Table API/SQL. Here are some examples
how intervals can be used in the APIs. More examples can be found in
`TemporalTypesTest`.
```
testAllApis(
1.year,
"1.year",
"INTERVAL '1' YEAR",
"+1-00")
testAllApis(
'f0 + 2.day,
"f0 + 2.day",
"f0 + INTERVAL '2' DAY",
"1990-10-16")
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-4359
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2348.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2348
commit 67540ed4f6da59c0853e1c56134166173329c1d9
Author: twalthr
Date: 2016-08-08T08:15:49Z
[FLINK-4359] [table] Add INTERVAL type
> Add INTERVAL type
> -
>
> Key: FLINK-4359
> URL: https://issues.apache.org/jira/browse/FLINK-4359
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Timo Walther
>
> In order to start with StreamSQL windows we need a way to define intervals in
> time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4359) Add INTERVAL type
[ https://issues.apache.org/jira/browse/FLINK-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415204#comment-15415204 ] Jark Wu commented on FLINK-4359: Do we have any ideas how to implement StreamSQL window? Because currently calcite doesn't support window in StreamSQL. > Add INTERVAL type > - > > Key: FLINK-4359 > URL: https://issues.apache.org/jira/browse/FLINK-4359 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > > In order to start with StreamSQL windows we need a way to define intervals in > time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4359) Add INTERVAL type
[ https://issues.apache.org/jira/browse/FLINK-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415206#comment-15415206 ] ASF GitHub Bot commented on FLINK-4359: --- Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2348 @aljoscha would be great if you could have a quick look on it. > Add INTERVAL type > - > > Key: FLINK-4359 > URL: https://issues.apache.org/jira/browse/FLINK-4359 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > > In order to start with StreamSQL windows we need a way to define intervals in > time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
