[jira] [Commented] (FLINK-4590) Some Table API tests are failing when debug lvl is set to DEBUG
[
https://issues.apache.org/jira/browse/FLINK-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523591#comment-15523591
]
ASF GitHub Bot commented on FLINK-4590:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2504
> Some Table API tests are failing when debug lvl is set to DEBUG
> ---
>
> Key: FLINK-4590
> URL: https://issues.apache.org/jira/browse/FLINK-4590
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>Assignee: Timo Walther
>
> For debugging another issue, I've set the log level on travis to DEBUG.
> After that, the Table API tests started failing
> {code}
> Failed tests:
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> {code}
> Probably Calcite is executing additional assertions depending on the debug
> level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4590) Some Table API tests are failing when debug lvl is set to DEBUG
[
https://issues.apache.org/jira/browse/FLINK-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516659#comment-15516659
]
ASF GitHub Bot commented on FLINK-4590:
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2504#discussion_r80259892
--- Diff:
flink-libraries/flink-table/src/test/resources/log4j-test.properties ---
@@ -0,0 +1,27 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+# Set root logger level to OFF to not flood build logs
+# set manually to INFO for debugging purposes
+log4j.rootLogger=OFF, testlogger
--- End diff --
Ah OK. The PR description didn't say that the missing cost functions were
causing the failing tests.
> Some Table API tests are failing when debug lvl is set to DEBUG
> ---
>
> Key: FLINK-4590
> URL: https://issues.apache.org/jira/browse/FLINK-4590
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>Assignee: Timo Walther
>
> For debugging another issue, I've set the log level on travis to DEBUG.
> After that, the Table API tests started failing
> {code}
> Failed tests:
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> {code}
> Probably Calcite is executing additional assertions depending on the debug
> level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4590) Some Table API tests are failing when debug lvl is set to DEBUG
[
https://issues.apache.org/jira/browse/FLINK-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516662#comment-15516662
]
ASF GitHub Bot commented on FLINK-4590:
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2504
+1 to merge
> Some Table API tests are failing when debug lvl is set to DEBUG
> ---
>
> Key: FLINK-4590
> URL: https://issues.apache.org/jira/browse/FLINK-4590
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>Assignee: Timo Walther
>
> For debugging another issue, I've set the log level on travis to DEBUG.
> After that, the Table API tests started failing
> {code}
> Failed tests:
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> {code}
> Probably Calcite is executing additional assertions depending on the debug
> level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4590) Some Table API tests are failing when debug lvl is set to DEBUG
[
https://issues.apache.org/jira/browse/FLINK-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516635#comment-15516635
]
ASF GitHub Bot commented on FLINK-4590:
---
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2504#discussion_r80258489
--- Diff:
flink-libraries/flink-table/src/test/resources/log4j-test.properties ---
@@ -0,0 +1,27 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+# Set root logger level to OFF to not flood build logs
+# set manually to INFO for debugging purposes
+log4j.rootLogger=OFF, testlogger
--- End diff --
As I explained in my PR description: "This PR fixes the estimated costs for
minus and union DataSet RelNodes". This was the root cause for the failing
Calcite assumptions. I just added the log4j file to easily enable assertions in
future.
> Some Table API tests are failing when debug lvl is set to DEBUG
> ---
>
> Key: FLINK-4590
> URL: https://issues.apache.org/jira/browse/FLINK-4590
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>Assignee: Timo Walther
>
> For debugging another issue, I've set the log level on travis to DEBUG.
> After that, the Table API tests started failing
> {code}
> Failed tests:
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> {code}
> Probably Calcite is executing additional assertions depending on the debug
> level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4590) Some Table API tests are failing when debug lvl is set to DEBUG
[
https://issues.apache.org/jira/browse/FLINK-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516579#comment-15516579
]
ASF GitHub Bot commented on FLINK-4590:
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2504#discussion_r80252345
--- Diff:
flink-libraries/flink-table/src/test/resources/log4j-test.properties ---
@@ -0,0 +1,27 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+# Set root logger level to OFF to not flood build logs
+# set manually to INFO for debugging purposes
+log4j.rootLogger=OFF, testlogger
--- End diff --
I assume this is the actual fix for the referenced bug, right?
> Some Table API tests are failing when debug lvl is set to DEBUG
> ---
>
> Key: FLINK-4590
> URL: https://issues.apache.org/jira/browse/FLINK-4590
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>Assignee: Timo Walther
>
> For debugging another issue, I've set the log level on travis to DEBUG.
> After that, the Table API tests started failing
> {code}
> Failed tests:
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> {code}
> Probably Calcite is executing additional assertions depending on the debug
> level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4590) Some Table API tests are failing when debug lvl is set to DEBUG
[
https://issues.apache.org/jira/browse/FLINK-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495808#comment-15495808
]
ASF GitHub Bot commented on FLINK-4590:
---
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2504
[FLINK-4590] [table] Some Table API tests are failing when debug lvl is set
to DEBUG
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
This PR fixes the estimated costs for minus and union DataSet RelNodes. I
went through all RelNodes and also fixed multiple potential null pointers,
bugs, and warnings.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-4590
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2504.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2504
commit a13e30799cb4a5d59de813b96d3519a337461aa6
Author: twalthr
Date: 2016-09-16T08:52:28Z
[FLINK-4590] [table] Some Table API tests are failing when debug lvl is set
to DEBUG
> Some Table API tests are failing when debug lvl is set to DEBUG
> ---
>
> Key: FLINK-4590
> URL: https://issues.apache.org/jira/browse/FLINK-4590
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>Assignee: Timo Walther
>
> For debugging another issue, I've set the log level on travis to DEBUG.
> After that, the Table API tests started failing
> {code}
> Failed tests:
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> {code}
> Probably Calcite is executing additional assertions depending on the debug
> level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
