[jira] [Commented] (FLINK-4655) Add tests for validation of Expressions

2017-02-28 Thread Timo Walther (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888268#comment-15888268
 ] 

Timo Walther commented on FLINK-4655:
-

Yes, it is still not covered properly.

> Add tests for validation of Expressions
> ---
>
> Key: FLINK-4655
> URL: https://issues.apache.org/jira/browse/FLINK-4655
> Project: Flink
>  Issue Type: Test
>  Components: Table API & SQL
>Reporter: Timo Walther
>
> Currently, it is only tested if Table API expressions work if the input is 
> correct. The validation method of expressions is not tested. The 
> {{ExpressionTestBase}} should be extended to provide means to also test 
> invalid expressions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (FLINK-4655) Add tests for validation of Expressions

2017-02-28 Thread Ufuk Celebi (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888260#comment-15888260
 ] 

Ufuk Celebi commented on FLINK-4655:


[~twalthr], [~fhueske] is this issue still relevant?

> Add tests for validation of Expressions
> ---
>
> Key: FLINK-4655
> URL: https://issues.apache.org/jira/browse/FLINK-4655
> Project: Flink
>  Issue Type: Test
>  Components: Table API & SQL
>Reporter: Timo Walther
>
> Currently, it is only tested if Table API expressions work if the input is 
> correct. The validation method of expressions is not tested. The 
> {{ExpressionTestBase}} should be extended to provide means to also test 
> invalid expressions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)