[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-03-12 Thread Adnan Khan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358863#comment-14358863 ] Adnan Khan commented on FLINK-1388: --- Also - Why should pass the name of all the fields

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-03-12 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358878#comment-14358878 ] Fabian Hueske commented on FLINK-1388: -- Sure you can do that. I thought it might be a

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-03-11 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357170#comment-14357170 ] Robert Metzger commented on FLINK-1388: --- Hi, yes, Tuple types are subclassed. Flink

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-03-11 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357234#comment-14357234 ] Fabian Hueske commented on FLINK-1388: -- Watch out, PojoTypeInformation is not

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-03-11 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357577#comment-14357577 ] Fabian Hueske commented on FLINK-1388: -- That is right, but the OutputFormat itself is

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-03-11 Thread Adnan Khan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357418#comment-14357418 ] Adnan Khan commented on FLINK-1388: --- so i understand - why does it matter if

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-03-11 Thread Adnan Khan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357717#comment-14357717 ] Adnan Khan commented on FLINK-1388: --- Does that make any references to TypeInformation in

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-03-11 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357866#comment-14357866 ] Fabian Hueske commented on FLINK-1388: -- It just won't work and throw an exception

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-03-09 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353460#comment-14353460 ] Robert Metzger commented on FLINK-1388: --- Thank you for updating your changes. There

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-02-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14325971#comment-14325971 ] Robert Metzger commented on FLINK-1388: --- Yes, adding additional tests is always

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-02-17 Thread Adnan Khan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14325020#comment-14325020 ] Adnan Khan commented on FLINK-1388: --- Hey thanks. * What exactly do you mean by

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-02-15 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321961#comment-14321961 ] Robert Metzger commented on FLINK-1388: --- Cool. Some feedback: - I think an

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-02-15 Thread Adnan Khan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321756#comment-14321756 ] Adnan Khan commented on FLINK-1388: --- Heya, Can I get some feedback on the CSV writer

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-02-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321635#comment-14321635 ] Robert Metzger commented on FLINK-1388: --- Yes, for private fields you need to make

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-02-14 Thread Adnan Khan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321633#comment-14321633 ] Adnan Khan commented on FLINK-1388: --- Hey Timo, So the rules for defining a POJO

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-02-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321645#comment-14321645 ] Robert Metzger commented on FLINK-1388: --- How about

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-02-14 Thread Adnan Khan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321642#comment-14321642 ] Adnan Khan commented on FLINK-1388: --- Okay thanks, that sounds good. Also - Where should

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-02-08 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311342#comment-14311342 ] Timo Walther commented on FLINK-1388: - Hey Adnan, for testing purposes you can create

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-02-08 Thread Adnan Khan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311329#comment-14311329 ] Adnan Khan commented on FLINK-1388: --- Hey Fabian, I've been digging through those two

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-02-06 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308934#comment-14308934 ] Fabian Hueske commented on FLINK-1388: -- Hi, the PojoTypeInfo contains all

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-02-04 Thread Adnan Khan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14305996#comment-14305996 ] Adnan Khan commented on FLINK-1388: --- I'll work on this one. POJO support for

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278333#comment-14278333 ] ASF GitHub Bot commented on FLINK-1388: --- GitHub user msdevanms opened a pull