[jira] [Commented] (FLINK-629) Add support for null values to the java api
[ https://issues.apache.org/jira/browse/FLINK-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14291060#comment-14291060 ] Robert Metzger commented on FLINK-629: -- Cool. I'm glad its working. I'll push the fix to master and release-0.8 branch. Thank you for verifying the fix. Add support for null values to the java api --- Key: FLINK-629 URL: https://issues.apache.org/jira/browse/FLINK-629 Project: Flink Issue Type: Improvement Components: Java API Reporter: Stephan Ewen Assignee: Gyula Fora Priority: Critical Labels: github-import Fix For: pre-apache Attachments: Selection_006.png, SimpleTweetInputFormat.java, Tweet.java, model.tar.gz Currently, many runtime operations fail when encountering a null value. Tuple serialization should allow null fields. I suggest to add a method to the tuples called `getFieldNotNull()` which throws a meaningful exception when the accessed field is null. That way, we simplify the logic of operators that should not dead with null fields, like key grouping or aggregations. Even though SQL allows grouping and aggregating of null values, I suggest to exclude this from the java api, because the SQL semantics of aggregating null fields are messy. Imported from GitHub Url: https://github.com/stratosphere/stratosphere/issues/629 Created by: [StephanEwen|https://github.com/StephanEwen] Labels: enhancement, java api, Milestone: Release 0.5.1 Created at: Wed Mar 26 00:27:49 CET 2014 State: open -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-629) Add support for null values to the java api
[ https://issues.apache.org/jira/browse/FLINK-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289753#comment-14289753 ] mustafa elbehery commented on FLINK-629: [~rmetzger] I need this fix into release-0.8 maven repo, I have cherry picked the fix into 0.8 branch, would I push it and you merge it ? Add support for null values to the java api --- Key: FLINK-629 URL: https://issues.apache.org/jira/browse/FLINK-629 Project: Flink Issue Type: Improvement Components: Java API Reporter: Stephan Ewen Assignee: Gyula Fora Priority: Critical Labels: github-import Fix For: pre-apache Attachments: Selection_006.png, SimpleTweetInputFormat.java, Tweet.java, model.tar.gz Currently, many runtime operations fail when encountering a null value. Tuple serialization should allow null fields. I suggest to add a method to the tuples called `getFieldNotNull()` which throws a meaningful exception when the accessed field is null. That way, we simplify the logic of operators that should not dead with null fields, like key grouping or aggregations. Even though SQL allows grouping and aggregating of null values, I suggest to exclude this from the java api, because the SQL semantics of aggregating null fields are messy. Imported from GitHub Url: https://github.com/stratosphere/stratosphere/issues/629 Created by: [StephanEwen|https://github.com/StephanEwen] Labels: enhancement, java api, Milestone: Release 0.5.1 Created at: Wed Mar 26 00:27:49 CET 2014 State: open -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-629) Add support for null values to the java api
[ https://issues.apache.org/jira/browse/FLINK-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14287392#comment-14287392 ] mustafa elbehery commented on FLINK-629: Its on Flink 9, I have to stick right now to Flink 8.0 .. I can not upgrade now Add support for null values to the java api --- Key: FLINK-629 URL: https://issues.apache.org/jira/browse/FLINK-629 Project: Flink Issue Type: Improvement Components: Java API Reporter: Stephan Ewen Assignee: Gyula Fora Priority: Critical Labels: github-import Fix For: pre-apache Attachments: Selection_006.png, SimpleTweetInputFormat.java, Tweet.java, model.tar.gz Currently, many runtime operations fail when encountering a null value. Tuple serialization should allow null fields. I suggest to add a method to the tuples called `getFieldNotNull()` which throws a meaningful exception when the accessed field is null. That way, we simplify the logic of operators that should not dead with null fields, like key grouping or aggregations. Even though SQL allows grouping and aggregating of null values, I suggest to exclude this from the java api, because the SQL semantics of aggregating null fields are messy. Imported from GitHub Url: https://github.com/stratosphere/stratosphere/issues/629 Created by: [StephanEwen|https://github.com/StephanEwen] Labels: enhancement, java api, Milestone: Release 0.5.1 Created at: Wed Mar 26 00:27:49 CET 2014 State: open -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-629) Add support for null values to the java api
[ https://issues.apache.org/jira/browse/FLINK-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288646#comment-14288646 ] mustafa elbehery commented on FLINK-629: Its working now, Thanks a lot robert for your support :) :) Add support for null values to the java api --- Key: FLINK-629 URL: https://issues.apache.org/jira/browse/FLINK-629 Project: Flink Issue Type: Improvement Components: Java API Reporter: Stephan Ewen Assignee: Gyula Fora Priority: Critical Labels: github-import Fix For: pre-apache Attachments: Selection_006.png, SimpleTweetInputFormat.java, Tweet.java, model.tar.gz Currently, many runtime operations fail when encountering a null value. Tuple serialization should allow null fields. I suggest to add a method to the tuples called `getFieldNotNull()` which throws a meaningful exception when the accessed field is null. That way, we simplify the logic of operators that should not dead with null fields, like key grouping or aggregations. Even though SQL allows grouping and aggregating of null values, I suggest to exclude this from the java api, because the SQL semantics of aggregating null fields are messy. Imported from GitHub Url: https://github.com/stratosphere/stratosphere/issues/629 Created by: [StephanEwen|https://github.com/StephanEwen] Labels: enhancement, java api, Milestone: Release 0.5.1 Created at: Wed Mar 26 00:27:49 CET 2014 State: open -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-629) Add support for null values to the java api
[ https://issues.apache.org/jira/browse/FLINK-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286016#comment-14286016 ] Stephan Ewen commented on FLINK-629: Concerning the fix: Some classes are not instantiable by our utils, of by Kryo/Objenesis. I would suggest to catch exceptions and return null in that case. Add support for null values to the java api --- Key: FLINK-629 URL: https://issues.apache.org/jira/browse/FLINK-629 Project: Flink Issue Type: Improvement Components: Java API Reporter: Stephan Ewen Assignee: Gyula Fora Priority: Critical Labels: github-import Fix For: pre-apache Attachments: Selection_006.png, SimpleTweetInputFormat.java, Tweet.java, model.tar.gz Currently, many runtime operations fail when encountering a null value. Tuple serialization should allow null fields. I suggest to add a method to the tuples called `getFieldNotNull()` which throws a meaningful exception when the accessed field is null. That way, we simplify the logic of operators that should not dead with null fields, like key grouping or aggregations. Even though SQL allows grouping and aggregating of null values, I suggest to exclude this from the java api, because the SQL semantics of aggregating null fields are messy. Imported from GitHub Url: https://github.com/stratosphere/stratosphere/issues/629 Created by: [StephanEwen|https://github.com/StephanEwen] Labels: enhancement, java api, Milestone: Release 0.5.1 Created at: Wed Mar 26 00:27:49 CET 2014 State: open -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-629) Add support for null values to the java api
[ https://issues.apache.org/jira/browse/FLINK-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14284534#comment-14284534 ] mustafa elbehery commented on FLINK-629: It is proper POJO with all the setters and getters. And I have set the type explicitly as mentioned above, in the InputFormat. I have attached the Pojo and the InputFormat .Java, Thanks in advance. Add support for null values to the java api --- Key: FLINK-629 URL: https://issues.apache.org/jira/browse/FLINK-629 Project: Flink Issue Type: Improvement Components: Java API Reporter: Stephan Ewen Assignee: Gyula Fora Priority: Critical Labels: github-import Fix For: pre-apache Attachments: Selection_006.png, SimpleTweetInputFormat.java, Tweet.java, model.tar.gz Currently, many runtime operations fail when encountering a null value. Tuple serialization should allow null fields. I suggest to add a method to the tuples called `getFieldNotNull()` which throws a meaningful exception when the accessed field is null. That way, we simplify the logic of operators that should not dead with null fields, like key grouping or aggregations. Even though SQL allows grouping and aggregating of null values, I suggest to exclude this from the java api, because the SQL semantics of aggregating null fields are messy. Imported from GitHub Url: https://github.com/stratosphere/stratosphere/issues/629 Created by: [StephanEwen|https://github.com/StephanEwen] Labels: enhancement, java api, Milestone: Release 0.5.1 Created at: Wed Mar 26 00:27:49 CET 2014 State: open -- This message was sent by Atlassian JIRA (v6.3.4#6332)
