[GitHub] [flink] AHeise commented on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops
AHeise commented on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops URL: https://github.com/apache/flink/pull/9383#issuecomment-526128412 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] AHeise commented on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops
AHeise commented on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops URL: https://github.com/apache/flink/pull/9383#issuecomment-524801835 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] AHeise commented on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops
AHeise commented on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops URL: https://github.com/apache/flink/pull/9383#issuecomment-524614723 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] AHeise commented on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops
AHeise commented on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops URL: https://github.com/apache/flink/pull/9383#issuecomment-521938038 > > Implementation wise, it looks like the main (task level) mailbox (`TaskMailboxImpl`) became an implicit delegate of mailbox of operator at index 0. > > Instead, I think, it still could be a proper mailbox that can allow executing any letters. In particular, some timer triggers and checkpoints are operator neutral. They still could progress independently of operators. > > It may require, to adjust this implementation, to also execute letters that are not addressed directly to downstream operators. (It's possible also to place such letters as `Mail` with operator index `MAX_INT`). > > Yes, MAX_INT makes more sense than 0 in any case. That was actually my original intent. After some discussions, we moved it to -1 instead and just treat priority mail with MAX_INT. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] AHeise commented on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops
AHeise commented on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops URL: https://github.com/apache/flink/pull/9383#issuecomment-521637692 > You are removing the `ExecutorService` from the `MailboxExecutorImpl` implementation in the last commit. > Are there any limitations/reasons to do so? > > Initially, this functionality was added for convenience to have futures that result with a mailbox letter. > So far, this was used for checkpoints triggers via mailbox (in a different branch, that not PRed yet) The basic idea of removing the ExecutorService interface is to get rid of the life-cycle methods. Since each Mailbox view is wrapped into an MailboxExecutor, each Mailbox view would also need to have life-cycle methods, which is a total mess. Instead, we just support the Executor interface, which is enough to support the nice CompletableFuture usages. The MailboxProcessor will then invoke the life-cycle methods on TaskMailbox, both are owned by the task. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] AHeise commented on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops
AHeise commented on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops URL: https://github.com/apache/flink/pull/9383#issuecomment-521636762 > Implementation wise, it looks like the main (task level) mailbox (`TaskMailboxImpl`) became an implicit delegate of mailbox of operator at index 0. > > Instead, I think, it still could be a proper mailbox that can allow executing any letters. In particular, some timer triggers and checkpoints are operator neutral. They still could progress independently of operators. > It may require, to adjust this implementation, to also execute letters that are not addressed directly to downstream operators. (It's possible also to place such letters as `Mail` with operator index `MAX_INT`). Yes, MAX_INT makes more sense than 0 in any case. That was actually my original intent. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
