[GitHub] [flink] AHeise commented on pull request #17061: [FLINK-23977][elasticsearch] Added DynamicElasticsearchSink for Dynamic ES Cluster Routing

2021-09-30 Thread GitBox
AHeise commented on pull request #17061: URL: https://github.com/apache/flink/pull/17061#issuecomment-931463319 It's very similar to

[GitHub] [flink] AHeise commented on pull request #17061: [FLINK-23977][elasticsearch] Added DynamicElasticsearchSink for Dynamic ES Cluster Routing

2021-09-30 Thread GitBox
AHeise commented on pull request #17061: URL: https://github.com/apache/flink/pull/17061#issuecomment-931429813 To open it to more use cases, we pretty much just need to replace the lower bounds with a more generic interface. You are not using much from the ESSink directly. However, we

[GitHub] [flink] AHeise commented on pull request #17061: [FLINK-23977][elasticsearch] Added DynamicElasticsearchSink for Dynamic ES Cluster Routing

2021-09-27 Thread GitBox
AHeise commented on pull request #17061: URL: https://github.com/apache/flink/pull/17061#issuecomment-927862688 Hi @rionmonster , thank you very much for your contribution. I think, this is a very neat addition. I'm wondering why you scoped it to ES only. In theory, we demulitplex